You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ChoMinGi (via GitHub)" <gi...@apache.org> on 2026/09/14 17:15:32 UTC
[PR] MINOR: Remove unused allowOverride from addStateStore [kafka]
ChoMinGi opened a new pull request, #23461:
URL: https://github.com/apache/kafka/pull/23461
Follow-up to #22102.
`allowOverride` no longer has any `true` callers. This removes the unused overload and uses `putIfAbsent` to preserve the existing compatible store factory.
`InternalTopologyBuilderTest` and `StreamsBuilderTest` pass locally.
Reviewers: Chia-Ping Tsai <ch...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Remove unused allowOverride from addStateStore [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #23461:
URL: https://github.com/apache/kafka/pull/23461#discussion_r4031722632
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##########
@@ -598,33 +598,25 @@ private void verifyParents(final String processorName, final String... predecess
public final void addStateStore(final StoreBuilder<?> storeBuilder,
final String... processorNames) {
Objects.requireNonNull(storeBuilder, "storeBuilder cannot be null");
- addStateStore(StoreBuilderWrapper.wrapStoreBuilder(storeBuilder), false, processorNames);
+ addStateStore(StoreBuilderWrapper.wrapStoreBuilder(storeBuilder), processorNames);
}
public final void addStateStore(final StoreFactory storeFactory,
final String... processorNames) {
- addStateStore(storeFactory, false, processorNames);
- }
-
- public final void addStateStore(final StoreFactory storeFactory,
- final boolean allowOverride,
- final String... processorNames) {
Objects.requireNonNull(storeFactory, "stateStoreFactory cannot be null");
Review Comment:
typo: `stateStoreFactory` -> `storeFactory`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Remove unused allowOverride from addStateStore [kafka]
Posted by "ChoMinGi (via GitHub)" <gi...@apache.org>.
ChoMinGi commented on code in PR #23461:
URL: https://github.com/apache/kafka/pull/23461#discussion_r4033104155
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##########
@@ -598,33 +598,25 @@ private void verifyParents(final String processorName, final String... predecess
public final void addStateStore(final StoreBuilder<?> storeBuilder,
final String... processorNames) {
Objects.requireNonNull(storeBuilder, "storeBuilder cannot be null");
- addStateStore(StoreBuilderWrapper.wrapStoreBuilder(storeBuilder), false, processorNames);
+ addStateStore(StoreBuilderWrapper.wrapStoreBuilder(storeBuilder), processorNames);
}
public final void addStateStore(final StoreFactory storeFactory,
final String... processorNames) {
- addStateStore(storeFactory, false, processorNames);
- }
-
- public final void addStateStore(final StoreFactory storeFactory,
- final boolean allowOverride,
- final String... processorNames) {
Objects.requireNonNull(storeFactory, "stateStoreFactory cannot be null");
Review Comment:
@chia7712
Thanks for catching this!
I checked similar messages in the codebase and this was the only actual variable-name mismatch I found.
Fixed in [cf73d353ae](https://github.com/apache/kafka/pull/23461/changes/cf73d353ae842543add7e1f2c9cb06b076c7d7bc)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Remove unused allowOverride from addStateStore [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #23461:
URL: https://github.com/apache/kafka/pull/23461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org