[GitHub] [hive] henrib commented on a diff in pull request #4299: HIVE-27319: HMS server should throw InvalidObjectException in get_par…

["henrib (via GitHub)" <gi...@apache.org>]

henrib commented on code in PR #4299:
URL: https://github.com/apache/hive/pull/4299#discussion_r1187546032


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ExceptionHandler.java:
##########
@@ -127,7 +128,7 @@ public ExceptionHandler toMetaExceptionIfInstance(String message, Class<?>... cl
    */
   public static void rethrowException(Exception e) throws TException {
     throw handleException(e)
-        .throwIfInstance(MetaException.class, NoSuchObjectException.class)
+        .throwIfInstance(MetaException.class, NoSuchObjectException.class, InvalidObjectException.class)

Review Comment:
   May be explicitly call `
   throw handleException(e) .throwIfInstance(MetaException.class,NoSuchObjectException.class,InvalidObjectException.class)
   ` instead of modifying rethrowException ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org