[jira] [Commented] (HDFS-12340) Ozone: C/C++ implementation of ozone client using curl

["Mukul Kumar Singh (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-12340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247404#comment-16247404 ] 

Mukul Kumar Singh commented on HDFS-12340:
------------------------------------------


1) #add_definitions(-DLIBOZONECLIENT_DLL_EXPORT), has been commented out from the second CMakeLists.txt, should this be removed ?

2) main.c - 19: a space between ozone and client
3) main.c - 135, memory has already been allocated at 118, that needs to be de-allocated
4) Comments are needed in main.c to explain the code flow.
5) main.c:142, memory is being malloc'ed here without any check,
6) main.c:144, there are commented lines of code
7) these series of elseif can be replcaced with switch cases and enums, and then lets have small helper functions for each command type.



> Ozone: C/C++ implementation of ozone client using curl
> ------------------------------------------------------
>
>                 Key: HDFS-12340
>                 URL: https://issues.apache.org/jira/browse/HDFS-12340
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Shashikant Banerjee
>            Assignee: Shashikant Banerjee
>              Labels: OzonePostMerge
>             Fix For: HDFS-7240
>
>         Attachments: HDFS-12340-HDFS-7240.001.patch, HDFS-12340-HDFS-7240.002.patch, HDFS-12340-HDFS-7240.003.patch, main.C, ozoneClient.C, ozoneClient.h
>
>
> This Jira is introduced for implementation of ozone client in C/C++ using curl library.
> All these calls will make use of HTTP protocol and would require libcurl. The libcurl API are referenced from here:
> https://curl.haxx.se/libcurl/
> Additional details would be posted along with the patches.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org