You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/09 08:31:56 UTC
[GitHub] [incubator-shardingsphere] SteNicholas opened a new pull request
#4212: Standard List usage
SteNicholas opened a new pull request #4212: Standard List usage
URL: https://github.com/apache/incubator-shardingsphere/pull/4212
According to standard, use `LinkedList` in priority, not use `Lists.newArrayList()` of Guava.
Changes proposed in this pull request:
- Modify `Lists.newArrayList()` to `new LinkedList<>`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4212:
Standard List usage
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4212: Standard List usage
URL: https://github.com/apache/incubator-shardingsphere/pull/4212#issuecomment-583821285
## Pull Request Test Coverage Report for [Build 9394](https://coveralls.io/builds/28613699)
* **1** of **3** **(33.33%)** changed or added relevant lines in **2** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **64.577%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDDLVisitor.java](https://coveralls.io/builds/28613699/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDDLVisitor.java#L339) | 0 | 2 | 0.0%
<!-- | **Total:** | **1** | **3** | **33.33%** | -->
| Totals | [](https://coveralls.io/builds/28613699) |
| :-- | --: |
| Change from base [Build 9392](https://coveralls.io/builds/28613475): | 0.0% |
| Covered Lines: | 10960 |
| Relevant Lines: | 16972 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4212:
Standard List usage
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #4212: Standard List usage
URL: https://github.com/apache/incubator-shardingsphere/pull/4212
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4212: Standard List usage
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4212: Standard List usage
URL: https://github.com/apache/incubator-shardingsphere/pull/4212#issuecomment-583821285
## Pull Request Test Coverage Report for [Build 1653](https://coveralls.io/builds/28613709)
* **1** of **3** **(33.33%)** changed or added relevant lines in **2** files are covered.
* **2** unchanged lines in **1** file lost coverage.
* Overall coverage increased (+**0.006%**) to **64.583%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDDLVisitor.java](https://coveralls.io/builds/28613709/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDDLVisitor.java#L339) | 0 | 2 | 0.0%
<!-- | **Total:** | **1** | **3** | **33.33%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28613709/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L74) | 2 | 80.0% |
<!-- | **Total:** | **2** | | -->
| Totals | [](https://coveralls.io/builds/28613709) |
| :-- | --: |
| Change from base [Build 9392](https://coveralls.io/builds/28613475): | 0.006% |
| Covered Lines: | 10961 |
| Relevant Lines: | 16972 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services