You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ij...@apache.org on 2016/05/04 00:54:32 UTC
kafka git commit: MINOR: Clean up of ConsumerCoordinator and
PartitionAssignor
Repository: kafka
Updated Branches:
refs/heads/trunk b3d2c0dab -> af0137884
MINOR: Clean up of ConsumerCoordinator and PartitionAssignor
Author: Liquan Pei <li...@gmail.com>
Reviewers: Jason Gustafson <ja...@confluent.io>, Ismael Juma <is...@juma.me.uk>
Closes #1306 from Ishiihara/minor-consumer-cleanup
Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/af013788
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/af013788
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/af013788
Branch: refs/heads/trunk
Commit: af013788436ae5652b531184770f2620f8914123
Parents: b3d2c0d
Author: Liquan Pei <li...@gmail.com>
Authored: Tue May 3 23:42:03 2016 +0100
Committer: Ismael Juma <is...@juma.me.uk>
Committed: Tue May 3 23:42:03 2016 +0100
----------------------------------------------------------------------
.../kafka/clients/consumer/internals/ConsumerCoordinator.java | 2 +-
.../apache/kafka/clients/consumer/internals/PartitionAssignor.java | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kafka/blob/af013788/clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
----------------------------------------------------------------------
diff --git a/clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java b/clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
index 887f47c..7486969 100644
--- a/clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
+++ b/clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
@@ -62,7 +62,7 @@ public final class ConsumerCoordinator extends AbstractCoordinator {
private static final Logger log = LoggerFactory.getLogger(ConsumerCoordinator.class);
private final List<PartitionAssignor> assignors;
- private final org.apache.kafka.clients.Metadata metadata;
+ private final Metadata metadata;
private final ConsumerCoordinatorMetrics sensors;
private final SubscriptionState subscriptions;
private final OffsetCommitCallback defaultOffsetCommitCallback;
http://git-wip-us.apache.org/repos/asf/kafka/blob/af013788/clients/src/main/java/org/apache/kafka/clients/consumer/internals/PartitionAssignor.java
----------------------------------------------------------------------
diff --git a/clients/src/main/java/org/apache/kafka/clients/consumer/internals/PartitionAssignor.java b/clients/src/main/java/org/apache/kafka/clients/consumer/internals/PartitionAssignor.java
index 46bfa75..df8f2f1 100644
--- a/clients/src/main/java/org/apache/kafka/clients/consumer/internals/PartitionAssignor.java
+++ b/clients/src/main/java/org/apache/kafka/clients/consumer/internals/PartitionAssignor.java
@@ -39,7 +39,7 @@ public interface PartitionAssignor {
* Return a serializable object representing the local member's subscription. This can include
* additional information as well (e.g. local host/rack information) which can be leveraged in
* {@link #assign(Cluster, Map)}.
- * @param topics Topics subscribed to through {@link org.apache.kafka.clients.consumer.KafkaConsumer#subscribe(List)}
+ * @param topics Topics subscribed to through {@link org.apache.kafka.clients.consumer.KafkaConsumer#subscribe(java.util.Collection)}
* and variants
* @return Non-null subscription with optional user data
*/