You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2019/11/17 02:29:57 UTC
[GitHub] [helix] alirezazamani commented on a change in pull request #608:
Stabilize the TestAlertingRebalancerFailure test
alirezazamani commented on a change in pull request #608: Stabilize the TestAlertingRebalancerFailure test
URL: https://github.com/apache/helix/pull/608#discussion_r347115199
##########
File path: helix-core/src/test/java/org/apache/helix/integration/TestAlertingRebalancerFailure.java
##########
@@ -164,6 +164,7 @@ public void testTagSetIncorrect() throws Exception {
BuiltInStateModelDefinitions.MasterSlave.name(), RebalanceMode.FULL_AUTO.name());
ZkHelixClusterVerifier verifier = new BestPossibleExternalViewVerifier.Builder(CLUSTER_NAME)
.setZkAddr(ZK_ADDR).setResources(new HashSet<>(Collections.singleton(testDb))).build();
+ _gSetupTool.getClusterManagementTool().rebalance(CLUSTER_NAME, testDb, 3);
Review comment:
@narendly
We discussed offline and since in other parts of the test "3" has been used instead of _replica, we decided to keep the PR simple and keep it as it is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org