You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by Tumati Venky <tu...@gmail.com> on 2018/10/28 06:17:03 UTC
ZOOKEEPER-3183
Hi Team,
I see some improvement in WatcherCleaner worker thread.WatcherCleaner
thread is waiting to get certain dead watchers, the shut down can happen
when WatcherCleaner thread is waiting. It will be better if we Interrupt or
notify to avoid the long waiting as shut down is initiated. And also
complete the remaining dead watchers when interrupt happened.
I have created ticket "ZOOKEEPER-3183" for this improvement. I would
like to take up this improvement.
Can I proceed to make this change?
Thanks,
Tumati
Re: ZOOKEEPER-3183
Posted by Fangmin Lv <lv...@gmail.com>.
Great, thanks!
On Fri, Nov 2, 2018 at 12:01 PM Tumati Venky <tu...@gmail.com> wrote:
> Sure Fangmin.I will send PR in a day.
>
> Thanks,
> Tumati
>
> On Sat, Nov 3, 2018 at 12:08 AM Fangmin Lv <lv...@gmail.com> wrote:
>
>> Thanks Tumati for providing the improvement, please open a pull request
>> and I'll review it.
>>
>> Best,
>> Fangmin
>>
>> On Thu, Nov 1, 2018 at 3:22 PM Andor Molnár <an...@apache.org> wrote:
>>
>>> Hi Tumati!
>>>
>>>
>>> Of course. Your contribution is much appreciated.
>>>
>>> Would you please open a github pull request, when you're ready with code
>>> change to let the community review it?
>>>
>>>
>>> Thanks,
>>>
>>> Andor
>>>
>>>
>>> On 10/28/18 07:17, Tumati Venky wrote:
>>> > Hi Team,
>>> >
>>> > I see some improvement in WatcherCleaner worker thread.WatcherCleaner
>>> > thread is waiting to get certain dead watchers, the shut down can
>>> happen
>>> > when WatcherCleaner thread is waiting. It will be better if we
>>> Interrupt or
>>> > notify to avoid the long waiting as shut down is initiated. And also
>>> > complete the remaining dead watchers when interrupt happened.
>>> >
>>> > I have created ticket "ZOOKEEPER-3183" for this improvement. I would
>>> > like to take up this improvement.
>>> >
>>> > Can I proceed to make this change?
>>> >
>>> > Thanks,
>>> > Tumati
>>> >
>>>
>>
Re: ZOOKEEPER-3183
Posted by Tumati Venky <tu...@gmail.com>.
Sure Fangmin.I will send PR in a day.
Thanks,
Tumati
On Sat, Nov 3, 2018 at 12:08 AM Fangmin Lv <lv...@gmail.com> wrote:
> Thanks Tumati for providing the improvement, please open a pull request
> and I'll review it.
>
> Best,
> Fangmin
>
> On Thu, Nov 1, 2018 at 3:22 PM Andor Molnár <an...@apache.org> wrote:
>
>> Hi Tumati!
>>
>>
>> Of course. Your contribution is much appreciated.
>>
>> Would you please open a github pull request, when you're ready with code
>> change to let the community review it?
>>
>>
>> Thanks,
>>
>> Andor
>>
>>
>> On 10/28/18 07:17, Tumati Venky wrote:
>> > Hi Team,
>> >
>> > I see some improvement in WatcherCleaner worker thread.WatcherCleaner
>> > thread is waiting to get certain dead watchers, the shut down can happen
>> > when WatcherCleaner thread is waiting. It will be better if we
>> Interrupt or
>> > notify to avoid the long waiting as shut down is initiated. And also
>> > complete the remaining dead watchers when interrupt happened.
>> >
>> > I have created ticket "ZOOKEEPER-3183" for this improvement. I would
>> > like to take up this improvement.
>> >
>> > Can I proceed to make this change?
>> >
>> > Thanks,
>> > Tumati
>> >
>>
>
Re: ZOOKEEPER-3183
Posted by Fangmin Lv <lv...@gmail.com>.
Thanks Tumati for providing the improvement, please open a pull request and
I'll review it.
Best,
Fangmin
On Thu, Nov 1, 2018 at 3:22 PM Andor Molnár <an...@apache.org> wrote:
> Hi Tumati!
>
>
> Of course. Your contribution is much appreciated.
>
> Would you please open a github pull request, when you're ready with code
> change to let the community review it?
>
>
> Thanks,
>
> Andor
>
>
> On 10/28/18 07:17, Tumati Venky wrote:
> > Hi Team,
> >
> > I see some improvement in WatcherCleaner worker thread.WatcherCleaner
> > thread is waiting to get certain dead watchers, the shut down can happen
> > when WatcherCleaner thread is waiting. It will be better if we Interrupt
> or
> > notify to avoid the long waiting as shut down is initiated. And also
> > complete the remaining dead watchers when interrupt happened.
> >
> > I have created ticket "ZOOKEEPER-3183" for this improvement. I would
> > like to take up this improvement.
> >
> > Can I proceed to make this change?
> >
> > Thanks,
> > Tumati
> >
>
Re: ZOOKEEPER-3183
Posted by Andor Molnár <an...@apache.org>.
Hi Tumati!
Of course. Your contribution is much appreciated.
Would you please open a github pull request, when you're ready with code
change to let the community review it?
Thanks,
Andor
On 10/28/18 07:17, Tumati Venky wrote:
> Hi Team,
>
> I see some improvement in WatcherCleaner worker thread.WatcherCleaner
> thread is waiting to get certain dead watchers, the shut down can happen
> when WatcherCleaner thread is waiting. It will be better if we Interrupt or
> notify to avoid the long waiting as shut down is initiated. And also
> complete the remaining dead watchers when interrupt happened.
>
> I have created ticket "ZOOKEEPER-3183" for this improvement. I would
> like to take up this improvement.
>
> Can I proceed to make this change?
>
> Thanks,
> Tumati
>