You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/11/14 11:03:44 UTC

[GitHub] [hudi] xiarixiaoyao opened a new pull request #3994: [HUDI-2758] remove redundant code in the HoodieRealtimeInputFormatUtils.getRealtimeSplits

xiarixiaoyao opened a new pull request #3994:
URL: https://github.com/apache/hudi/pull/3994


   …ls.getRealtimeSplits
   
   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
   
   ## What is the purpose of the pull request
   remove redundant code in the HoodieRealtimeInputFormatUtils.getRealtimeSplits.
   
   ## Verify this pull request
   
   exist UTs, 
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #3994: [HUDI-2758] remove redundant code in the HoodieRealtimeInputFormatUtils.getRealtimeSplits

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3994:
URL: https://github.com/apache/hudi/pull/3994#issuecomment-968268738


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f0504a320e79ba365e1e4da59590d402eaeacec3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f0504a320e79ba365e1e4da59590d402eaeacec3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f0504a320e79ba365e1e4da59590d402eaeacec3 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #3994: [HUDI-2758] remove redundant code in the HoodieRealtimeInputFormatUtils.getRealtimeSplits

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3994:
URL: https://github.com/apache/hudi/pull/3994#issuecomment-968269110


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f0504a320e79ba365e1e4da59590d402eaeacec3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3360",
       "triggerID" : "f0504a320e79ba365e1e4da59590d402eaeacec3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f0504a320e79ba365e1e4da59590d402eaeacec3 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3360) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3994: [HUDI-2758] remove redundant code in the HoodieRealtimeInputFormatUtils.getRealtimeSplits

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3994:
URL: https://github.com/apache/hudi/pull/3994#issuecomment-968269110


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f0504a320e79ba365e1e4da59590d402eaeacec3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3360",
       "triggerID" : "f0504a320e79ba365e1e4da59590d402eaeacec3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f0504a320e79ba365e1e4da59590d402eaeacec3 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3360) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3994: [HUDI-2758] remove redundant code in the HoodieRealtimeInputFormatUtils.getRealtimeSplits

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3994:
URL: https://github.com/apache/hudi/pull/3994#issuecomment-968268738


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f0504a320e79ba365e1e4da59590d402eaeacec3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f0504a320e79ba365e1e4da59590d402eaeacec3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f0504a320e79ba365e1e4da59590d402eaeacec3 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3994: [HUDI-2758] remove redundant code in the HoodieRealtimeInputFormatUtils.getRealtimeSplits

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3994:
URL: https://github.com/apache/hudi/pull/3994#issuecomment-968276611


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f0504a320e79ba365e1e4da59590d402eaeacec3",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3360",
       "triggerID" : "f0504a320e79ba365e1e4da59590d402eaeacec3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f0504a320e79ba365e1e4da59590d402eaeacec3 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3360) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xiarixiaoyao commented on pull request #3994: [HUDI-2758] remove redundant code in the HoodieRealtimeInputFormatUtils.getRealtimeSplits

Posted by GitBox <gi...@apache.org>.
xiarixiaoyao commented on pull request #3994:
URL: https://github.com/apache/hudi/pull/3994#issuecomment-968268913


   @danny0405  could you help me review this pr , thanks.
   HUDI-2086  has split the read log of incremental query and realtime query.  
   when we create HoodieRealtimeFileSplit for realtime query,  no need to add extra logical deal with BaseFileWithLogsSplit; original logcial can cover that case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] danny0405 merged pull request #3994: [HUDI-2758] remove redundant code in the HoodieRealtimeInputFormatUtils.getRealtimeSplits

Posted by GitBox <gi...@apache.org>.
danny0405 merged pull request #3994:
URL: https://github.com/apache/hudi/pull/3994


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org