Re: svn commit: r1834898 - /httpd/httpd/branches/2.4.x/STATUS

[Marion et Christophe JAILLET <ch...@wanadoo.fr>]

Le 02/07/2018 à 22:51, druggeri@apache.org a écrit :
> +     druggeri: Why no +1, jallietc36?
> +
>
I vote when I can test or when trivial enough.
But it does not prevent me from proposing what looks interesting, so 
that the other ones, with more technical background or experience than 
me, have a change to vote and backport it, if my intuition (or in this 
particular case, the log message) is correct.

In such a case, just running the test framework is not enough, IMHO. One 
need a deeper understanding of what is changed (what can be the 
consequences of inserting an error bucket? Should be none, but...). It 
also looks not that easy to test and trigger the issue (" When a 
post-handshake check fails"...).
This could look trivial, but the devil is in the detail (and mod_ssl is 
a to big beast for me, with too many differences between 2.4.x and trunk 
(but easy backport proposal are on the way :))

So, just proposing, is my only contribution in such a case.
Hoping it helps.

CJ

Re: svn commit: r1834898 - /httpd/httpd/branches/2.4.x/STATUS

[Yann Ylavic <yl...@gmail.com>]

On Mon, Jul 2, 2018 at 11:08 PM, Eric Covener <co...@gmail.com> wrote:
>> So, just proposing, is my only contribution in such a case.
>> Hoping it helps.
>
> pointing out these lost revisions is very helpful!

+1

Re: svn commit: r1834898 - /httpd/httpd/branches/2.4.x/STATUS

[Eric Covener <co...@gmail.com>]

> So, just proposing, is my only contribution in such a case.
> Hoping it helps.

pointing out these lost revisions is very helpful!