You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/03/25 18:23:36 UTC

[GitHub] [flink] rmetzger opened a new pull request #11514: [FLINK-16778][e2e] Make sure all java e2e tests are running

rmetzger opened a new pull request #11514: [FLINK-16778][e2e] Make sure all java e2e tests are running
URL: https://github.com/apache/flink/pull/11514
 
 
   ## What is the purpose of the change
   
   Some profiles were not activated for the Java e2e tests.
   
   
   ## Brief change log
   
   - Enable missing profiles
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11514: [FLINK-16778][e2e] Make sure all java e2e tests are running

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11514: [FLINK-16778][e2e] Make sure all java e2e tests are running
URL: https://github.com/apache/flink/pull/11514#issuecomment-604008970
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 29696958b984e42139d8f411b389448e1b03ad16 (Wed Mar 25 18:26:42 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on a change in pull request #11514: [FLINK-16778][e2e] Make sure all java e2e tests are running

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11514: [FLINK-16778][e2e] Make sure all java e2e tests are running
URL: https://github.com/apache/flink/pull/11514#discussion_r398086968
 
 

 ##########
 File path: flink-end-to-end-tests/run-nightly-tests.sh
 ##########
 @@ -228,7 +228,7 @@ MVN_COMMON_OPTIONS="-nsu -B -Dflink.forkCount=2 -Dflink.forkCountTestPackage=2 -
 e2e_modules=$(find flink-end-to-end-tests -mindepth 2 -maxdepth 5 -name 'pom.xml' -printf '%h\n' | sort -u | tr '\n' ',')
 e2e_modules="${e2e_modules},$(find flink-walkthroughs -mindepth 2 -maxdepth 2 -name 'pom.xml' -printf '%h\n' | sort -u | tr '\n' ',')"
 
-PROFILE="$PROFILE -Pe2e-travis1 -Pe2e-travis2 -Pe2e-travis3 -Pe2e-travis4 -Pe2e-travis5 -Pe2e-travis6"
+PROFILE="$PROFILE -Pe2e-travis1 -Pe2e-travis2 -Pe2e-travis3 -Pe2e-travis4 -Pe2e-travis5 -Pe2e-travis6 -Pe2e-hadoop -Pe2e-pre-commit"
 
 Review comment:
   hmm I would probably put this into `build-apache-repo.yml`, to make it easier to add a hadoop-free nightly run. If you were to try that with this approach the test would naturally fail.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11514: [FLINK-16778][e2e] Make sure all java e2e tests are running

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11514: [FLINK-16778][e2e] Make sure all java e2e tests are running
URL: https://github.com/apache/flink/pull/11514#issuecomment-604018077
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "29696958b984e42139d8f411b389448e1b03ad16",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155181986",
       "triggerID" : "29696958b984e42139d8f411b389448e1b03ad16",
       "triggerType" : "PUSH"
     }, {
       "hash" : "29696958b984e42139d8f411b389448e1b03ad16",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6645",
       "triggerID" : "29696958b984e42139d8f411b389448e1b03ad16",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 29696958b984e42139d8f411b389448e1b03ad16 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/155181986) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6645) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11514: [FLINK-16778][e2e] Make sure all java e2e tests are running

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11514: [FLINK-16778][e2e] Make sure all java e2e tests are running
URL: https://github.com/apache/flink/pull/11514#issuecomment-604018077
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "29696958b984e42139d8f411b389448e1b03ad16",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "29696958b984e42139d8f411b389448e1b03ad16",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 29696958b984e42139d8f411b389448e1b03ad16 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11514: [FLINK-16778][e2e] Make sure all java e2e tests are running

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11514: [FLINK-16778][e2e] Make sure all java e2e tests are running
URL: https://github.com/apache/flink/pull/11514#issuecomment-604018077
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "29696958b984e42139d8f411b389448e1b03ad16",
       "status" : "CANCELED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155181986",
       "triggerID" : "29696958b984e42139d8f411b389448e1b03ad16",
       "triggerType" : "PUSH"
     }, {
       "hash" : "29696958b984e42139d8f411b389448e1b03ad16",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6645",
       "triggerID" : "29696958b984e42139d8f411b389448e1b03ad16",
       "triggerType" : "PUSH"
     }, {
       "hash" : "278df8de92e78dc29b55a6788b23cac3d60ed311",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "278df8de92e78dc29b55a6788b23cac3d60ed311",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 29696958b984e42139d8f411b389448e1b03ad16 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/155181986) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6645) 
   * 278df8de92e78dc29b55a6788b23cac3d60ed311 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rmetzger commented on issue #11514: [FLINK-16778][e2e] Make sure all java e2e tests are running

Posted by GitBox <gi...@apache.org>.
rmetzger commented on issue #11514: [FLINK-16778][e2e] Make sure all java e2e tests are running
URL: https://github.com/apache/flink/pull/11514#issuecomment-604035160
 
 
   Addressed all comments.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11514: [FLINK-16778][e2e] Make sure all java e2e tests are running

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11514: [FLINK-16778][e2e] Make sure all java e2e tests are running
URL: https://github.com/apache/flink/pull/11514#issuecomment-604018077
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "29696958b984e42139d8f411b389448e1b03ad16",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155181986",
       "triggerID" : "29696958b984e42139d8f411b389448e1b03ad16",
       "triggerType" : "PUSH"
     }, {
       "hash" : "29696958b984e42139d8f411b389448e1b03ad16",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6645",
       "triggerID" : "29696958b984e42139d8f411b389448e1b03ad16",
       "triggerType" : "PUSH"
     }, {
       "hash" : "278df8de92e78dc29b55a6788b23cac3d60ed311",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "278df8de92e78dc29b55a6788b23cac3d60ed311",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 29696958b984e42139d8f411b389448e1b03ad16 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/155181986) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6645) 
   * 278df8de92e78dc29b55a6788b23cac3d60ed311 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11514: [FLINK-16778][e2e] Make sure all java e2e tests are running

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11514: [FLINK-16778][e2e] Make sure all java e2e tests are running
URL: https://github.com/apache/flink/pull/11514#issuecomment-604018077
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "29696958b984e42139d8f411b389448e1b03ad16",
       "status" : "CANCELED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155181986",
       "triggerID" : "29696958b984e42139d8f411b389448e1b03ad16",
       "triggerType" : "PUSH"
     }, {
       "hash" : "29696958b984e42139d8f411b389448e1b03ad16",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6645",
       "triggerID" : "29696958b984e42139d8f411b389448e1b03ad16",
       "triggerType" : "PUSH"
     }, {
       "hash" : "278df8de92e78dc29b55a6788b23cac3d60ed311",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "278df8de92e78dc29b55a6788b23cac3d60ed311",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 29696958b984e42139d8f411b389448e1b03ad16 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/155181986) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6645) 
   * 278df8de92e78dc29b55a6788b23cac3d60ed311 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rmetzger commented on a change in pull request #11514: [FLINK-16778][e2e] Make sure all java e2e tests are running

Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #11514: [FLINK-16778][e2e] Make sure all java e2e tests are running
URL: https://github.com/apache/flink/pull/11514#discussion_r398107668
 
 

 ##########
 File path: flink-end-to-end-tests/run-nightly-tests.sh
 ##########
 @@ -228,7 +228,7 @@ MVN_COMMON_OPTIONS="-nsu -B -Dflink.forkCount=2 -Dflink.forkCountTestPackage=2 -
 e2e_modules=$(find flink-end-to-end-tests -mindepth 2 -maxdepth 5 -name 'pom.xml' -printf '%h\n' | sort -u | tr '\n' ',')
 e2e_modules="${e2e_modules},$(find flink-walkthroughs -mindepth 2 -maxdepth 2 -name 'pom.xml' -printf '%h\n' | sort -u | tr '\n' ',')"
 
-PROFILE="$PROFILE -Pe2e-travis1 -Pe2e-travis2 -Pe2e-travis3 -Pe2e-travis4 -Pe2e-travis5 -Pe2e-travis6"
+PROFILE="$PROFILE -Pe2e-travis1 -Pe2e-travis2 -Pe2e-travis3 -Pe2e-travis4 -Pe2e-travis5 -Pe2e-travis6 -Pe2e-hadoop -Pe2e-pre-commit"
 
 Review comment:
   Oops, I see. The nightly hadoop free build would have probably failed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rmetzger merged pull request #11514: [FLINK-16778][e2e] Make sure all java e2e tests are running

Posted by GitBox <gi...@apache.org>.
rmetzger merged pull request #11514: [FLINK-16778][e2e] Make sure all java e2e tests are running
URL: https://github.com/apache/flink/pull/11514
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services