[GitHub] [superset] betodealmeida commented on a change in pull request #12529: fix: Update Limit Control with SQL_ROW_MAX value

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #12529:
URL: https://github.com/apache/superset/pull/12529#discussion_r557779442



##########
File path: superset-frontend/src/SqlLab/components/SqlEditor.jsx
##########
@@ -539,7 +539,15 @@ class SqlEditor extends React.PureComponent {
   }
 
   renderQueryLimit() {
-    const menuDropdown = (
+    // Update the limit dropdown with SQL_ROW_MAX value
+    const { maxRow } = this.props;

Review comment:
       This should be `DISPLAY_MAX_ROW`, not `SQL_ROW_MAX`. `SQL_MAX_ROW` is for results backend and CSV export.
   
   Also, what happens if the user sets a `DEFAULT_SQLLAB_LIMIT` that's not a multiple of 10?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org