[GitHub] svalaskevicius commented on issue #363: reinit url after app freezes

[GitBox <gi...@apache.org>]

svalaskevicius commented on issue #363: reinit url after app freezes
URL: https://github.com/apache/cordova-ios/pull/363#issuecomment-389210263
 
 
   Hi @shazron , I've changed the function as requested, however I'm having problems with the test...
   
   I've tried adding this test:
   ```
   -(void)testIfItLoadsAppUrlIfCurrentViewIsBlank{
       CDVViewController* viewController = [self viewController];
       [viewController view];
       NSString* html = @"<html><body></body></html>";
       [viewController.webViewEngine loadHTMLString:html baseURL:@"about:blank"];
       XCTAssertTrue([viewController checkAndReinitViewUrl]);
       XCTAssertFalse([viewController checkAndReinitViewUrl]);
   }
   ```
   
   However, `loadRequest` does not load anything when running tests, and the url is always null.. 
   
   Any chance you could take this PR from here and add the missing test? I suspect it should not be difficult, however might require some more background knowledge about cordova/ios.. 
   
   I can also confirm that the approach to solve the initial problem (frozen apps for users) has been fixed by this PR (after also checking if it's not null *and* not "about:blank") 
   
   Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org