You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/24 15:12:48 UTC
[GitHub] [airflow] ashb opened a new pull request #18503: When calling `dr.get_task_instance` automatically set `dag_run` relationship
ashb opened a new pull request #18503:
URL: https://github.com/apache/airflow/pull/18503
We know that this TI belongs to this relationship, so setting this
avoids a lookup in a few places.
This somehow feels like we are fighting SQLAlchemy a bit, but from what
I can work out the only way to do this would either be an eager load of
one form or another (which would make a more complex query or an extra
query) or to look at `self.task_instances` -- which means the filtering
would be done in python space -- which we want to avoid for large dags
(it's not totally unheard of to have dags with 10 or 20k tasks in them!)
Relates to #18359 (but is in addition to that PR)
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb closed pull request #18503: When calling `dr.get_task_instance` automatically set `dag_run` relationship
Posted by GitBox <gi...@apache.org>.
ashb closed pull request #18503:
URL: https://github.com/apache/airflow/pull/18503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr closed pull request #18503: When calling `dr.get_task_instance` automatically set `dag_run` relationship
Posted by GitBox <gi...@apache.org>.
uranusjr closed pull request #18503:
URL: https://github.com/apache/airflow/pull/18503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #18503: When calling `dr.get_task_instance` automatically set `dag_run` relationship
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #18503:
URL: https://github.com/apache/airflow/pull/18503#discussion_r716153637
##########
File path: airflow/models/dagrun.py
##########
@@ -381,11 +382,14 @@ def get_task_instance(self, task_id: str, session: Session = None) -> Optional[T
:param session: Sqlalchemy ORM Session
:type session: Session
"""
- return (
+ ti = (
session.query(TI)
.filter(TI.dag_id == self.dag_id, TI.run_id == self.run_id, TI.task_id == task_id)
.one_or_none()
)
+ if ti:
+ set_committed_value(ti, 'dag_run', self)
+ return ti
Review comment:
I think the same can be achieved with `options(joinedload(TI.dag_run))`? (See `get_task_instances()` above)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #18503: When calling `dr.get_task_instance` automatically set `dag_run` relationship
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #18503:
URL: https://github.com/apache/airflow/pull/18503#issuecomment-928202842
We don't need this now with Ephraim's latest pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #18503: When calling `dr.get_task_instance` automatically set `dag_run` relationship
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #18503:
URL: https://github.com/apache/airflow/pull/18503#discussion_r716193475
##########
File path: airflow/models/dagrun.py
##########
@@ -381,11 +382,14 @@ def get_task_instance(self, task_id: str, session: Session = None) -> Optional[T
:param session: Sqlalchemy ORM Session
:type session: Session
"""
- return (
+ ti = (
session.query(TI)
.filter(TI.dag_id == self.dag_id, TI.run_id == self.run_id, TI.task_id == task_id)
.one_or_none()
)
+ if ti:
+ set_committed_value(ti, 'dag_run', self)
+ return ti
Review comment:
It can - the difference here is the extra join - that would result in a more complex query, and _we know_ that the ti belongs to those dag run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #18503: When calling `dr.get_task_instance` automatically set `dag_run` relationship
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #18503:
URL: https://github.com/apache/airflow/pull/18503#issuecomment-928202842
We don't need this now with Ephraim's latest pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb closed pull request #18503: When calling `dr.get_task_instance` automatically set `dag_run` relationship
Posted by GitBox <gi...@apache.org>.
ashb closed pull request #18503:
URL: https://github.com/apache/airflow/pull/18503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18503: When calling `dr.get_task_instance` automatically set `dag_run` relationship
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18503:
URL: https://github.com/apache/airflow/pull/18503#issuecomment-926713467
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org