You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/05/07 15:19:00 UTC

[jira] [Commented] (LUCENE-9362) ExpressionValueSource has buggy rewrite method

    [ https://issues.apache.org/jira/browse/LUCENE-9362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101768#comment-17101768 ] 

ASF subversion and git services commented on LUCENE-9362:
---------------------------------------------------------

Commit 4c408a5820970e77c4278e97017d37fe75ea8950 in lucene-solr's branch refs/heads/master from Dmitry Emets
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=4c408a5 ]

LUCENE-9362: Fix rewriting check in ExpressionValueSource (#1485)



> ExpressionValueSource has buggy rewrite method
> ----------------------------------------------
>
>                 Key: LUCENE-9362
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9362
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/expressions
>            Reporter: Dmitry Emets
>            Priority: Minor
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> ExpressionValuesSource does not actually rewrite itself due to small mistake in check of inner rewrites.
> {code:java}
> changed |= (rewritten[i] == variables[i]);
> {code}
> should be changed to
> {code:java}
> changed |= (rewritten[i] != variables[i]);
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org