[GitHub] [hbase] ndimiduk commented on a change in pull request #1064: HBASE-23707 Add IntelliJ check style plugin configuration

[GitBox <gi...@apache.org>]

ndimiduk commented on a change in pull request #1064: HBASE-23707 Add IntelliJ check style plugin configuration
URL: https://github.com/apache/hbase/pull/1064#discussion_r369207415
 
 

 ##########
 File path: .idea/checkstyle-idea.xml
 ##########
 @@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project version="4">
+  <component name="CheckStyle-IDEA">
+    <option name="configuration">
+      <map>
+        <entry key="checkstyle-version" value="8.28" />
+        <entry key="copy-libs" value="false" />
+        <entry key="location-0" value="BUNDLED:(bundled):Sun Checks" />
+        <entry key="location-1" value="BUNDLED:(bundled):Google Checks" />
+        <entry key="scan-before-checkin" value="false" />
+        <entry key="scanscope" value="JavaOnly" />
 
 Review comment:
   IIRC, our POM is configured to ignore tests at the moment. I think we can/should be more strict, but that's not what we're starting from. Maybe it's worth discussing with @busbey and @HorizonNet ; I think those two have done the most work with Checkstyle, as far as I am aware.
   
   Given we don't error out the build on violations, I think it would be fine to cover the test code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services