[GitHub] [flink-kubernetes-operator] gyfora opened a new pull request, #681: [FLINK-33107] Use correct upgrade mode when executing rollback, simpl…

["gyfora (via GitHub)" <gi...@apache.org>]

gyfora opened a new pull request, #681:
URL: https://github.com/apache/flink-kubernetes-operator/pull/681

   ## What is the purpose of the change
   
   Rollbacks have recently been improved to use the same `upgrade` mechanism that we use during user spec changes to cover more cases.
   
   However the previous implementation has a few shortcomings / bugs:
    - The code is a bit scattered around in the reconciler, making it difficult to understand
    - The upgradeMode was picked up from the last-stable spec, which in many cases can cause unintentional state loss. It should be picked up from the lastReconciledSpec
    - During upgrade the shutdown upgrade mode is not recorded correctly anywhere which may cause state loss or unrecoverable situations
   
   This PR aims at improving the rollback flow and solve the current issues highlighted previously.
   
   ## Brief change log
   
     - *Refactor upgrade flow and remove extra reconcile cycle previously added when rollback was initiated*
     - *Use upgradeMode from lastReconciledSpec instead of lastStableSpec when rolling back*
     - *Record upgradeMode in lastReconciledSpec correctly when suspend was performed in ROLLING_BACK state*
   
   ## Verifying this change
   
    - Existing unit tests have been extended + new unit tests added to cover the previously not working corner cases.
    - Manual verification on local k8s
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changes to the `CustomResourceDescriptors`: no
     - Core observer or reconciler logic that is regularly executed: yes
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #681: [FLINK-33107] Use correct upgrade mode when executing rollback, simpl…

["gyfora (via GitHub)" <gi...@apache.org>]

gyfora merged PR #681:
URL: https://github.com/apache/flink-kubernetes-operator/pull/681


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #681: [FLINK-33107] Use correct upgrade mode when executing rollback, simpl…

["gyfora (via GitHub)" <gi...@apache.org>]

gyfora commented on PR #681:
URL: https://github.com/apache/flink-kubernetes-operator/pull/681#issuecomment-1730115391

   cc @ashangit 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org