You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/11/25 11:37:18 UTC

[GitHub] [dolphinscheduler] ruanwenjun commented on a change in pull request #6981: [Improvement-6866][Api] Add transaction for service

ruanwenjun commented on a change in pull request #6981:
URL: https://github.com/apache/dolphinscheduler/pull/6981#discussion_r756812186



##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ExecutorServiceImpl.java
##########
@@ -127,6 +128,7 @@
      * @return execute process instance code
      */
     @Override
+    @Transactional(rollbackFor = RuntimeException.class)

Review comment:
       Maybe remove `rollbackFor = RuntimeException.class` is better? What do you think?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org