[GitHub] massakam commented on a change in pull request #836: In C++ partitioned consumer, do not append partition index in subscription name

[GitBox <gi...@apache.org>]

massakam commented on a change in pull request #836: In C++ partitioned consumer, do not append partition index in subscription name
URL: https://github.com/apache/incubator-pulsar/pull/836#discussion_r145585568
 
 

 ##########
 File path: pulsar-client-cpp/tests/BasicEndToEndTest.cc
 ##########
 @@ -429,6 +429,30 @@ TEST(BasicEndToEndTest, testPartitionedProducerConsumer)
     client.shutdown();
 }
 
+TEST(BasicEndToEndTest, testPartitionedProducerConsumerSubscriptionName)
+{
+    Client client(lookupUrl);
+    std::string topicName = "persistent://prop/unit/ns/testPartitionedProducerConsumerSubscriptionName";
+
+    // call admin api to make it partitioned
+    std::string url = adminUrl + "admin/persistent/prop/unit/ns/testPartitionedProducerConsumerSubscriptionName/partitions";
+    int res = makePutRequest(url, "3");
+
+    LOG_INFO("res = "<<res);
+    ASSERT_FALSE(res != 204 && res != 409);
+
+    Consumer partitionedConsumer;
+    Result result = client.subscribe(topicName, "subscription-A", consumer);
 
 Review comment:
   Is the variable name `consumer` (not `partitionedConsumer`) correct?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services