You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2025/07/04 12:06:04 UTC
[PR] fix spelling of Algorithm [pekko]
pjfanning opened a new pull request, #1932:
URL: https://github.com/apache/pekko/pull/1932
these are internal classes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] fix spelling of Algorithm [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #1932:
URL: https://github.com/apache/pekko/pull/1932#discussion_r2185316737
##########
serialization-jackson/src/main/scala/org/apache/pekko/serialization/jackson/JacksonSerializer.scala:
##########
@@ -162,10 +162,10 @@ import pekko.util.OptionVal
JacksonObjectMapperProvider(system).getOrCreate(bindingName, Some(new CBORFactory)))
@InternalApi object Compression {
- sealed trait Algoritm
- object Off extends Algoritm
- final case class GZip(largerThan: Long) extends Algoritm
- final case class LZ4(largerThan: Long) extends Algoritm
+ sealed trait Algorithm
Review Comment:
`@InternalApi` marked in line 164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] fix spelling of Algorithm [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #1932:
URL: https://github.com/apache/pekko/pull/1932#discussion_r2185315265
##########
serialization-jackson/src/main/scala/org/apache/pekko/serialization/jackson/JacksonSerializer.scala:
##########
@@ -162,10 +162,10 @@ import pekko.util.OptionVal
JacksonObjectMapperProvider(system).getOrCreate(bindingName, Some(new CBORFactory)))
@InternalApi object Compression {
- sealed trait Algoritm
- object Off extends Algoritm
- final case class GZip(largerThan: Long) extends Algoritm
- final case class LZ4(largerThan: Long) extends Algoritm
+ sealed trait Algorithm
Review Comment:
it's an internal class - I don't see why we need to worry about renaming it now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] fix spelling of Algorithm [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #1932:
URL: https://github.com/apache/pekko/pull/1932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] fix spelling of Algorithm [pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #1932:
URL: https://github.com/apache/pekko/pull/1932#discussion_r2185304834
##########
serialization-jackson/src/main/scala/org/apache/pekko/serialization/jackson/JacksonSerializer.scala:
##########
@@ -162,10 +162,10 @@ import pekko.util.OptionVal
JacksonObjectMapperProvider(system).getOrCreate(bindingName, Some(new CBORFactory)))
@InternalApi object Compression {
- sealed trait Algoritm
- object Off extends Algoritm
- final case class GZip(largerThan: Long) extends Algoritm
- final case class LZ4(largerThan: Long) extends Algoritm
+ sealed trait Algorithm
Review Comment:
I think we can just add a Algorithm trait and make Algoritm extends it, and in 2.0 we can do the migration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org