[GitHub] [samza] xiefan46 edited a comment on issue #1301: Samza-2478: Add new metrics to track key and value size of records written to RocksDb

[GitBox <gi...@apache.org>]

xiefan46 edited a comment on issue #1301: Samza-2478: Add new metrics to track key and value size of records written to RocksDb
URL: https://github.com/apache/samza/pull/1301#issuecomment-595943041
 
 
   **Feature:** Add new metrics to track key and value size of records written to RocksDb
   
   **Changes:** Add two SamzaHistogram metrics **recordKeySizeBytes** and **recordValueSizeBytes** in **SerializedKeyValueStoreMetrics** class
   
   **Tests:** Added a unit test call **TestKeyValueSizeHistogramMetric** to verify that those metrics are written to SamzaHistogram correctly and can be access by MetricVisitor. 
   
   **API Changes:** None
   **Upgrade instructions:** None
   **Usage instructions:** Every time a record is written to KeyValue store via SerializedKeyValueStore, its size will be recorded in those histograms. A metrics reporter can use MetricVisitor to get access to this two metrics. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services