You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/25 14:46:04 UTC

[jira] [Commented] (NIFI-3737) Optimize png resources with optipng

    [ https://issues.apache.org/jira/browse/NIFI-3737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982984#comment-15982984 ] 

ASF GitHub Bot commented on NIFI-3737:
--------------------------------------

GitHub user brosander opened a pull request:

    https://github.com/apache/nifi/pull/1693

    NIFI-3737 - Ran optipng on all png files

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [X] - N/A - Have you written or updated unit tests to verify your changes?
    - [X] - N/A - If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [X] - N/A - If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [X] - N/A - If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [X] - N/A - If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [X] - N/A - Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/brosander/nifi NIFI-3737

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1693.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1693
    
----
commit 599a25015cb9287b3e79852c44e4759702a4c52c
Author: Bryan Rosander <br...@apache.org>
Date:   2017-04-25T05:03:22Z

    NIFI-3737 - Ran optipng on all png files

----


> Optimize png resources with optipng
> -----------------------------------
>
>                 Key: NIFI-3737
>                 URL: https://issues.apache.org/jira/browse/NIFI-3737
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Bryan Rosander
>            Assignee: Bryan Rosander
>            Priority: Trivial
>
> [Optipng|http://optipng.sourceforge.net/] is a utility that tweaks compression parameters in png files to reduce their size without losing quality.  Running this on all the png resources in NiFi reduces their total size by about 35% (12M -> 7.4M).
> This isn't a huge change but it should be very low impact and will hopefully make the ui feel a bit snappier with smaller resources.
> [Command to optimize all pngs|http://stackoverflow.com/questions/21801085/optimize-images-in-directory-using-multiple-cpu-cores#answer-21998589]:
> {code}
> find ./ -iname '*.png' -print0 | xargs -0 -n 1 -P 4 optipng -o7
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)