You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/11/06 02:26:49 UTC

[GitHub] michellethomas opened a new pull request #6277: Avoid clearing metric when saving from datasource editor

michellethomas opened a new pull request #6277: Avoid clearing metric when saving from datasource editor
URL: https://github.com/apache/incubator-superset/pull/6277
 
 
   Clicking save from the datasource editor would clear your metrics field because we were comparing objects in MetricsControl to see if columns or saved metrics changed. We should be doing a deep compare.
   
   Thanks @graceguo-supercat for helping track this down!
   
   @mistercrunch @john-bodley @graceguo-supercat 
   
   Fixes #6275

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org