You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/11/29 15:02:24 UTC
[GitHub] [dubbo-go] sanxun0325 opened a new pull request #1625: [WIP]hessian2 supports setting the type of Java method parameters
sanxun0325 opened a new pull request #1625:
URL: https://github.com/apache/dubbo-go/pull/1625
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md before commit pull request.
-->
**What this PR does**:
hessian2 supports setting the type of Java method parameters
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes https://github.com/apache/dubbo-go/issues/1624
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] sanxun0325 commented on pull request #1625: hessian2 supports setting the type of Java method parameters
Posted by GitBox <gi...@apache.org>.
sanxun0325 commented on pull request #1625:
URL: https://github.com/apache/dubbo-go/pull/1625#issuecomment-986355366
@LaurenceLiZhixin ready to merge, need to trigger the CI again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin merged pull request #1625: hessian2 supports setting the type of Java method parameters
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin merged pull request #1625:
URL: https://github.com/apache/dubbo-go/pull/1625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #1625: hessian2 supports setting the type of Java method parameters
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1625:
URL: https://github.com/apache/dubbo-go/pull/1625#issuecomment-986391132
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1625?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1625](https://codecov.io/gh/apache/dubbo-go/pull/1625?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (26e3a78) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/7bb88bfc87a28e08b0376f1a2ed22ad8aaffb628?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7bb88bf) will **decrease** coverage by `0.03%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/1625?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1625 +/- ##
==========================================
- Coverage 41.16% 41.12% -0.04%
==========================================
Files 253 253
Lines 14506 14509 +3
==========================================
- Hits 5971 5967 -4
- Misses 7844 7853 +9
+ Partials 691 689 -2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1625?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [protocol/dubbo/impl/hessian.go](https://codecov.io/gh/apache/dubbo-go/pull/1625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9oZXNzaWFuLmdv) | `34.37% <100.00%> (+3.14%)` | :arrow_up: |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/1625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `26.49% <0.00%> (-8.61%)` | :arrow_down: |
| [metrics/prometheus/reporter.go](https://codecov.io/gh/apache/dubbo-go/pull/1625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0cmljcy9wcm9tZXRoZXVzL3JlcG9ydGVyLmdv) | `26.85% <0.00%> (-1.72%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1625?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1625?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7bb88bf...26e3a78](https://codecov.io/gh/apache/dubbo-go/pull/1625?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] justxuewei commented on a change in pull request #1625: hessian2 supports setting the type of Java method parameters
Posted by GitBox <gi...@apache.org>.
justxuewei commented on a change in pull request #1625:
URL: https://github.com/apache/dubbo-go/pull/1625#discussion_r762712796
##########
File path: protocol/dubbo/impl/hessian.go
##########
@@ -490,6 +490,10 @@ func getArgType(v interface{}) string {
}
switch t.Kind() {
case reflect.Struct:
+ p, ok := v.(hessian.Param)
Review comment:
`Param name` make me confused, I think it's better if it is called `inherited names` and `interfaces` respective.
BTW, I think `inherited names` and `interfaces` should return a string array to fit all inheritance scenarios. For instance, class A inherits from class B, and class B inherits from class C, so the return value of `inherited names` is []string{B, C}.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on pull request #1625: hessian2 supports setting the type of Java method parameters
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #1625:
URL: https://github.com/apache/dubbo-go/pull/1625#issuecomment-986006755
maybe u should add an ut for this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] sanxun0325 commented on pull request #1625: hessian2 supports setting the type of Java method parameters
Posted by GitBox <gi...@apache.org>.
sanxun0325 commented on pull request #1625:
URL: https://github.com/apache/dubbo-go/pull/1625#issuecomment-986023629
> maybe u should add an ut for this pr.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on a change in pull request #1625: hessian2 supports setting the type of Java method parameters
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #1625:
URL: https://github.com/apache/dubbo-go/pull/1625#discussion_r762969627
##########
File path: protocol/dubbo/impl/hessian.go
##########
@@ -490,6 +490,10 @@ func getArgType(v interface{}) string {
}
switch t.Kind() {
case reflect.Struct:
+ p, ok := v.(hessian.Param)
Review comment:
这个看上去应该给hessian 提交个issue？ @justxuewei
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] justxuewei commented on a change in pull request #1625: hessian2 supports setting the type of Java method parameters
Posted by GitBox <gi...@apache.org>.
justxuewei commented on a change in pull request #1625:
URL: https://github.com/apache/dubbo-go/pull/1625#discussion_r762712796
##########
File path: protocol/dubbo/impl/hessian.go
##########
@@ -490,6 +490,10 @@ func getArgType(v interface{}) string {
}
switch t.Kind() {
case reflect.Struct:
+ p, ok := v.(hessian.Param)
Review comment:
`Param name` makes me confused, I think it's better if it is called `inherited names` and `interfaces` respectively.
BTW, I think `inherited names` and `interfaces` should return a string array to fit all inheritance scenarios. For instance, class A inherits from class B, and class B inherits from class C, so the return value of `inherited names` is []string{B, C}.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] justxuewei commented on a change in pull request #1625: hessian2 supports setting the type of Java method parameters
Posted by GitBox <gi...@apache.org>.
justxuewei commented on a change in pull request #1625:
URL: https://github.com/apache/dubbo-go/pull/1625#discussion_r762712796
##########
File path: protocol/dubbo/impl/hessian.go
##########
@@ -490,6 +490,10 @@ func getArgType(v interface{}) string {
}
switch t.Kind() {
case reflect.Struct:
+ p, ok := v.(hessian.Param)
Review comment:
`Param name` make me confused, I think it's better if called `inherited names` and `interfaces` respective.
BTW, I think `inherited names` and `interfaces` should return a string array to fit all inheritance scenarios. For instance, class A inherits from class B, and class B inherits from class C, so the return value of `inherited names` is []string{B, C}.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] sanxun0325 commented on pull request #1625: [WIP]hessian2 supports setting the type of Java method parameters
Posted by GitBox <gi...@apache.org>.
sanxun0325 commented on pull request #1625:
URL: https://github.com/apache/dubbo-go/pull/1625#issuecomment-981719053
merge cannot be performed at the moment. Wait until hessian2 releases the new version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] justxuewei commented on a change in pull request #1625: hessian2 supports setting the type of Java method parameters
Posted by GitBox <gi...@apache.org>.
justxuewei commented on a change in pull request #1625:
URL: https://github.com/apache/dubbo-go/pull/1625#discussion_r762712796
##########
File path: protocol/dubbo/impl/hessian.go
##########
@@ -490,6 +490,10 @@ func getArgType(v interface{}) string {
}
switch t.Kind() {
case reflect.Struct:
+ p, ok := v.(hessian.Param)
Review comment:
`Param name` make me confused, I think it's better if called `inherited names` and `interfaces` respective. BTW, I think `inherited names` and `interfaces` should return a string array to fit the multiple inheritance scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] justxuewei commented on a change in pull request #1625: hessian2 supports setting the type of Java method parameters
Posted by GitBox <gi...@apache.org>.
justxuewei commented on a change in pull request #1625:
URL: https://github.com/apache/dubbo-go/pull/1625#discussion_r762712796
##########
File path: protocol/dubbo/impl/hessian.go
##########
@@ -490,6 +490,10 @@ func getArgType(v interface{}) string {
}
switch t.Kind() {
case reflect.Struct:
+ p, ok := v.(hessian.Param)
Review comment:
`Param name` make me confused, I think it's better if it is called `inherited names` and `interfaces` respectively.
BTW, I think `inherited names` and `interfaces` should return a string array to fit all inheritance scenarios. For instance, class A inherits from class B, and class B inherits from class C, so the return value of `inherited names` is []string{B, C}.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org