You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/08/12 08:19:12 UTC
[GitHub] [shardingsphere] tuichenchuxin opened a new pull request, #20115: remove SQLStatementDatabaseHolder.java
tuichenchuxin opened a new pull request, #20115:
URL: https://github.com/apache/shardingsphere/pull/20115
For #20005
Changes proposed in this pull request:
- remove SQLStatementDatabaseHolder.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #20115: remove SQLStatementDatabaseHolder.java
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #20115:
URL: https://github.com/apache/shardingsphere/pull/20115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #20115: remove SQLStatementDatabaseHolder.java
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #20115:
URL: https://github.com/apache/shardingsphere/pull/20115#issuecomment-1221500032
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/20115?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20115](https://codecov.io/gh/apache/shardingsphere/pull/20115?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (63c5d3a) into [master](https://codecov.io/gh/apache/shardingsphere/commit/e0b3d6d1c2ddbe6b8d87427ad563b9f88ab5775a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e0b3d6d) will **decrease** coverage by `0.01%`.
> The diff coverage is `76.08%`.
```diff
@@ Coverage Diff @@
## master #20115 +/- ##
============================================
- Coverage 60.40% 60.39% -0.02%
Complexity 2438 2438
============================================
Files 3915 3917 +2
Lines 55353 55364 +11
Branches 9410 9407 -3
============================================
+ Hits 33437 33438 +1
- Misses 19057 19071 +14
+ Partials 2859 2855 -4
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/20115?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...l/prepare/driver/DriverExecutionPrepareEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/20115/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9wcmVwYXJlL2RyaXZlci9Ecml2ZXJFeGVjdXRpb25QcmVwYXJlRW5naW5lLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../proxy/backend/communication/ProxySQLExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/20115/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL1Byb3h5U1FMRXhlY3V0b3IuamF2YQ==) | `31.25% <0.00%> (-0.50%)` | :arrow_down: |
| [...ackend/communication/ReactiveProxySQLExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/20115/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL1JlYWN0aXZlUHJveHlTUUxFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ackend/handler/distsql/rul/sql/PreviewHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/20115/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcnVsL3NxbC9QcmV2aWV3SGFuZGxlci5qYXZh) | `3.44% <0.00%> (ø)` | |
| [...g/apache/shardingsphere/infra/binder/LogicSQL.java](https://codecov.io/gh/apache/shardingsphere/pull/20115/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtYmluZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9iaW5kZXIvTG9naWNTUUwuamF2YQ==) | `87.50% <87.50%> (ø)` | |
| [...ore/statement/ShardingSpherePreparedStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/20115/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2NvcmUvc3RhdGVtZW50L1NoYXJkaW5nU3BoZXJlUHJlcGFyZWRTdGF0ZW1lbnQuamF2YQ==) | `64.42% <100.00%> (+0.36%)` | :arrow_up: |
| [...r/jdbc/core/statement/ShardingSphereStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/20115/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2NvcmUvc3RhdGVtZW50L1NoYXJkaW5nU3BoZXJlU3RhdGVtZW50LmphdmE=) | `50.51% <100.00%> (+0.17%)` | :arrow_up: |
| [...nication/jdbc/JDBCDatabaseCommunicationEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/20115/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvSkRCQ0RhdGFiYXNlQ29tbXVuaWNhdGlvbkVuZ2luZS5qYXZh) | `84.37% <100.00%> (+0.16%)` | :arrow_up: |
| [...unication/jdbc/statement/JDBCBackendStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/20115/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvc3RhdGVtZW50L0pEQkNCYWNrZW5kU3RhdGVtZW50LmphdmE=) | `26.08% <100.00%> (-5.92%)` | :arrow_down: |
| [...xy/backend/handler/ProxyBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/20115/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL1Byb3h5QmFja2VuZEhhbmRsZXJGYWN0b3J5LmphdmE=) | `66.17% <100.00%> (+2.94%)` | :arrow_up: |
| ... and [25 more](https://codecov.io/gh/apache/shardingsphere/pull/20115/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org