You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "joshartman (via GitHub)" <gi...@apache.org> on 2023/04/29 13:35:52 UTC
[GitHub] [qpid-protonj2] joshartman opened a new pull request, #6: When using RabbitMQ, the virtualHost API call was ignored.
joshartman opened a new pull request, #6:
URL: https://github.com/apache/qpid-protonj2/pull/6
When using RabbitMQ, the virtualHost API call was ignored. The virtualHost settings were ignored when set in ConnectionOptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-protonj2] joshartman commented on a diff in pull request #6: When using RabbitMQ, the virtualHost API call was ignored.
Posted by "joshartman (via GitHub)" <gi...@apache.org>.
joshartman commented on code in PR #6:
URL: https://github.com/apache/qpid-protonj2/pull/6#discussion_r1181225346
##########
protonj2-client/src/main/java/org/apache/qpid/protonj2/client/impl/ClientConnection.java:
##########
@@ -886,10 +886,11 @@ private void initializeProtonResources(ReconnectLocation location) throws Client
protonConnection.setContainerId(connectionId);
}
+ final String hostname = (options.virtualHost() == null || options.virtualHost().length() < 1) ? location.getHost() : options.virtualHost();
Review Comment:
Code updated as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-protonj2] jiridanek commented on a diff in pull request #6: When using RabbitMQ, the virtualHost API call was ignored.
Posted by "jiridanek (via GitHub)" <gi...@apache.org>.
jiridanek commented on code in PR #6:
URL: https://github.com/apache/qpid-protonj2/pull/6#discussion_r1181081677
##########
protonj2-client/src/main/java/org/apache/qpid/protonj2/client/impl/ClientConnection.java:
##########
@@ -886,10 +886,11 @@ private void initializeProtonResources(ReconnectLocation location) throws Client
protonConnection.setContainerId(connectionId);
}
+ final String hostname = (options.virtualHost() == null || options.virtualHost().length() < 1) ? location.getHost() : options.virtualHost();
Review Comment:
nit: I'd go with `options.virtualHost().isEmpty()` for the second part of the condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-protonj2] tabish121 commented on pull request #6: When using RabbitMQ, the virtualHost API call was ignored.
Posted by "tabish121 (via GitHub)" <gi...@apache.org>.
tabish121 commented on PR #6:
URL: https://github.com/apache/qpid-protonj2/pull/6#issuecomment-1530122280
There's a fair bit more to it than just setting the value as it needs to apply to both the Open and to the SASL init frames in the same way and we need a way to trigger a null host value which should be done similar to how it is done in Qpid JMS. This should be addressed by febc0aea5306a21bb65f388abb79c0950b5270d7 along with tests that are required for ensuring it remains fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-protonj2] tabish121 closed pull request #6: When using RabbitMQ, the virtualHost API call was ignored.
Posted by "tabish121 (via GitHub)" <gi...@apache.org>.
tabish121 closed pull request #6: When using RabbitMQ, the virtualHost API call was ignored.
URL: https://github.com/apache/qpid-protonj2/pull/6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org