[GitHub] [kafka] cadonna commented on a diff in pull request #12659: [DO NOT MERGE] KAFKA-10199: Integrate Topology Pause/Resume with StateUpdater

[GitBox <gi...@apache.org>]

cadonna commented on code in PR #12659:
URL: https://github.com/apache/kafka/pull/12659#discussion_r976201996


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##########
@@ -785,6 +787,22 @@ private void addTasksToStateUpdater() {
         }
     }
 
+    private void pauseTasksInStateUpdater() {
+        for (final Task task : stateUpdater.getUpdatingTasks()) {

Review Comment:
   Actually, read-only tasks are currently only generated in `getTasks()` which is not called by `getUpdatingTasks()`. However, if we decide to expose `getUpdatingTasks()` we should also generate read-only tasks there.   
   
   We could pause topologies instead of tasks in the state updater. Instead of `pause(task)` and `resume(task)`, we would then have `pause(topology)` and `resume(topology)` in the state updater interface. Within the default updater we could store the paused topologies and process tasks according to whether they are part of a paused topology or not.
   
   WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org