You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "TezQA (JIRA)" <ji...@apache.org> on 2019/04/22 16:57:00 UTC
[jira] [Commented] (TEZ-4062) Speculative attempt scheduling should
be aborted when Task has complelted
[ https://issues.apache.org/jira/browse/TEZ-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16823237#comment-16823237 ]
TezQA commented on TEZ-4062:
----------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 8m 16s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 3m 21s{color} | {color:red} tez-dag in master failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 16s{color} | {color:red} tez-dag in master failed. {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 1m 17s{color} | {color:orange} The patch fails to run checkstyle in tez-dag {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 15s{color} | {color:red} tez-dag in master failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 40s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 14s{color} | {color:red} tez-dag in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 15s{color} | {color:red} tez-dag in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 15s{color} | {color:red} tez-dag in the patch failed. {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 5s{color} | {color:orange} The patch fails to run checkstyle in tez-dag {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 14s{color} | {color:red} tez-dag in the patch failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 14s{color} | {color:red} tez-dag in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 20s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 16m 2s{color} | {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/tez:d4a62de |
| JIRA Issue | TEZ-4062 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12966636/TEZ-4062.001.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs checkstyle compile |
| uname | Linux 7458f843f5a9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | master / 8395a95 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| mvninstall | https://builds.apache.org/job/PreCommit-TEZ-Build/138/artifact/out/branch-mvninstall-tez-dag.txt |
| compile | https://builds.apache.org/job/PreCommit-TEZ-Build/138/artifact/out/branch-compile-tez-dag.txt |
| checkstyle | https://builds.apache.org/job/PreCommit-TEZ-Build/138/artifact/out//testptch/patchprocess/maven-branch-checkstyle-tez-dag.txt |
| findbugs | https://builds.apache.org/job/PreCommit-TEZ-Build/138/artifact/out/branch-findbugs-tez-dag.txt |
| mvninstall | https://builds.apache.org/job/PreCommit-TEZ-Build/138/artifact/out/patch-mvninstall-tez-dag.txt |
| compile | https://builds.apache.org/job/PreCommit-TEZ-Build/138/artifact/out/patch-compile-tez-dag.txt |
| javac | https://builds.apache.org/job/PreCommit-TEZ-Build/138/artifact/out/patch-compile-tez-dag.txt |
| checkstyle | https://builds.apache.org/job/PreCommit-TEZ-Build/138/artifact/out//testptch/patchprocess/maven-patch-checkstyle-tez-dag.txt |
| findbugs | https://builds.apache.org/job/PreCommit-TEZ-Build/138/artifact/out/patch-findbugs-tez-dag.txt |
| unit | https://builds.apache.org/job/PreCommit-TEZ-Build/138/artifact/out/patch-unit-tez-dag.txt |
| Test Results | https://builds.apache.org/job/PreCommit-TEZ-Build/138/testReport/ |
| Max. process+thread count | 88 (vs. ulimit of 10000) |
| modules | C: tez-dag U: tez-dag |
| Console output | https://builds.apache.org/job/PreCommit-TEZ-Build/138/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Speculative attempt scheduling should be aborted when Task has complelted
> -------------------------------------------------------------------------
>
> Key: TEZ-4062
> URL: https://issues.apache.org/jira/browse/TEZ-4062
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Yingda Chen
> Assignee: Ying Han
> Priority: Major
> Attachments: TEZ-4062.001.patch
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> In RedundantScheduleTransition (inside TaskImpl), we try to find the oldest running attempt and use it as the causual attempt when doing "addAndScheduleAttempt".
>
> However, the task may have completed at this moment, i.e., the task attempt that was considered running and long-tailed by speculator is now completed. In this case, we may not be able to find any unfinished attempt, which will lead to NPE in following logic (even without NPE, it still makes no sense to proceed with scheduling speculative attempt anyway)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)