You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "fjtirado (via GitHub)" <gi...@apache.org> on 2025/02/07 16:12:10 UTC
[PR] Fix #2170 [incubator-kie-kogito-apps]
fjtirado opened a new pull request, #2191:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2191
Fix https://github.com/apache/incubator-kie-kogito-apps/issues/2169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix #2169 Allow filtering over processInstances.definition and definition.metadata [incubator-kie-kogito-apps]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on code in PR #2191:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2191#discussion_r1955955662
##########
data-index/data-index-storage/data-index-storage-jpa/src/main/resources/kie-flyway/db/data-index/ansi/V1.45.1.0__metadata_as_column.sql:
##########
@@ -0,0 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+ALTER TABLE definitions ADD COLUMN metadata varchar(max);
+
Review Comment:
I commented deletion of the old data and added how the scripts to migrate data should look like for different dbs (in case users want to apply manually)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix #2169 Allow filtering over processInstances.definition and definition.metadata [incubator-kie-kogito-apps]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on code in PR #2191:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2191#discussion_r1954509723
##########
data-index/data-index-storage/data-index-storage-infinispan/src/main/java/org/kie/kogito/index/infinispan/protostream/ProcessDefinitionMarshaller.java:
##########
@@ -61,7 +62,7 @@ public ProcessDefinition readFrom(ProtoStreamReader reader) throws IOException {
pd.setName(reader.readString(NAME));
pd.setDescription(reader.readString(DESCRIPTION));
pd.setAnnotations(reader.readCollection(ANNOTATIONS, new HashSet<>(), String.class));
- pd.setMetadata(buildMetadata(reader));
+ pd.setMetadata(Collections.unmodifiableMap(buildMetadata(reader)));
Review Comment:
This is a compilation trick to reuse the Map<String,String> stored in Hibernate as Map<String,Object> as required by the model change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix #2169 Allow filtering over processInstances.definition and definition.metadata [incubator-kie-kogito-apps]
Posted by "kie-ci3 (via GitHub)" <gi...@apache.org>.
kie-ci3 commented on PR #2191:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2191#issuecomment-2644205473
**PR job** `#5` was: **UNSTABLE**
Possible explanation: This should be test failures
<details>
<summary><b>Reproducer</b></summary>
build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u https://github.com/apache/incubator-kie-kogito-apps/pull/2191 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution
</details>
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/5/display/redirect
**Test results:**
- PASSED: 1776
- FAILED: 34
Those are the test failures:
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/5/testReport/org.kie.kogito.index.mongodb/ProcessDataIndexMongoDBHttpIT/testProcessInstanceEvents/">org.kie.kogito.index.mongodb.ProcessDataIndexMongoDBHttpIT.testProcessInstanceEvents</a></summary>
Cannot invoke method size() on null object
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/5/testReport/org.kie.kogito.index.mongodb/ProcessDataIndexMongoDBKafkaIT/testProcessInstanceEvents/">org.kie.kogito.index.mongodb.ProcessDataIndexMongoDBKafkaIT.testProcessInstanceEvents</a></summary>
Cannot invoke method size() on null object
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/5/testReport/org.kie.kogito.index/ProcessDataIndexMongoDBIT/testProcessInstanceEvents/">org.kie.kogito.index.ProcessDataIndexMongoDBIT.testProcessInstanceEvents</a></summary>
Cannot invoke method size() on null object
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/5/testReport/org.kie.kogito.index/ProcessDataIndexPostgreSqlIT/testProcessInstanceEvents/">org.kie.kogito.index.ProcessDataIndexPostgreSqlIT.testProcessInstanceEvents</a></summary>
Cannot invoke method size() on null object
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/5/testReport/org.kie.kogito.index.service/InmemoryPostgreSqlIndexingServiceIT/testConcurrentProcessInstanceIndex/">org.kie.kogito.index.service.InmemoryPostgreSqlIndexingServiceIT.testConcurrentProcessInstanceIndex</a></summary>
Assertion condition defined as a org.kie.kogito.index.service.AbstractIndexingServiceIT 1 expectation failed.<br/>JSON path data.ProcessInstances[0].id doesn't match.<br/>Expected: is "d748c65c-0503-4a87-8ff6-3fdc8672084e"<br/> Actual: null<br/> within 30 seconds.
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/5/testReport/org.kie.kogito.index.service/InmemoryPostgreSqlIndexingServiceIT/testProcessInstanceIndex/">org.kie.kogito.index.service.InmemoryPostgreSqlIndexingServiceIT.testProcessInstanceIndex</a></summary>
Assertion condition defined as a org.kie.kogito.index.service.AbstractIndexingServiceIT 1 expectation failed.<br/>JSON path data.ProcessInstances[0].id doesn't match.<br/>Expected: is "bd7d003a-3755-4a56-9632-dc9c53d541d2"<br/> Actual: null<br/> within 30 seconds.
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/5/testReport/org.kie.kogito.index.service/InmemoryPostgreSqlIndexingServiceIT/testDefaultGraphqlTypes/">org.kie.kogito.index.service.InmemoryPostgreSqlIndexingServiceIT.testDefaultGraphqlTypes</a></summary>
JDBC exception executing SQL [delete from definitions pde1_0] [ERROR: update or delete on table "definitions" violates foreign key constraint "fk7jdn9rdvtq3ktsajobr9x1sx1" on table "processes"<br/> Detail: Key (id, version)=(travels, 1.0) is still referenced from table "processes".] [n/a]
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/5/testReport/org.kie.kogito.index.service/InmemoryPostgreSqlIndexingServiceIT/testProcessInstancePagination/">org.kie.kogito.index.service.InmemoryPostgreSqlIndexingServiceIT.testProcessInstancePagination</a></summary>
Assertion condition defined as a org.kie.kogito.index.service.AbstractIndexingServiceIT 1 expectation failed.<br/>JSON path data.ProcessInstances.size() doesn't match.<br/>Expected: is <1><br/> Actual: <2><br/> within 30 seconds.
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/5/testReport/org.kie.kogito.index.service/InmemoryPostgreSqlIndexingServiceIT/testJobIndex/">org.kie.kogito.index.service.InmemoryPostgreSqlIndexingServiceIT.testJobIndex</a></summary>
JDBC exception executing SQL [delete from definitions pde1_0] [ERROR: update or delete on table "definitions" violates foreign key constraint "fk7jdn9rdvtq3ktsajobr9x1sx1" on table "processes"<br/> Detail: Key (id, version)=(travels, 1.0) is still referenced from table "processes".] [n/a]
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/5/testReport/org.kie.kogito.index.service/InmemoryPostgreSqlIndexingServiceIT/testUserTaskInstanceIndex/">org.kie.kogito.index.service.InmemoryPostgreSqlIndexingServiceIT.testUserTaskInstanceIndex</a></summary>
JDBC exception executing SQL [delete from definitions pde1_0] [ERROR: update or delete on table "definitions" violates foreign key constraint "fk7jdn9rdvtq3ktsajobr9x1sx1" on table "processes"<br/> Detail: Key (id, version)=(travels, 1.0) is still referenced from table "processes".] [n/a]
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/5/testReport/org.kie.kogito.index.service/InmemoryPostgreSqlIndexingServiceIT/testUserTaskInstancePagination/">org.kie.kogito.index.service.InmemoryPostgreSqlIndexingServiceIT.testUserTaskInstancePagination</a></summary>
Assertion condition defined as a org.kie.kogito.index.service.AbstractIndexingServiceIT 1 expectation failed.<br/>JSON path data.UserTaskInstances.size() doesn't match.<br/>Expected: is <1><br/> Actual: <2><br/> within 30 seconds.
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/5/testReport/org.kie.kogito.index.service/MongoDomainIndexingServiceIT/testProcessInstanceIndex/">org.kie.kogito.index.service.MongoDomainIndexingServiceIT.testProcessInstanceIndex</a></summary>
Assertion condition defined as a org.kie.kogito.index.service.AbstractIndexingServiceIT 1 expectation failed.<br/>JSON path data.ProcessDefinitions[0].id doesn't match.<br/>Expected: is "travels"<br/> Actual: null<br/> within 30 seconds.
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/5/testReport/org.kie.kogito.index.service.graphql.query/MongoGraphQLRuntimesQueriesIT/testProcessExecuteInstance/">org.kie.kogito.index.service.graphql.query.MongoGraphQLRuntimesQueriesIT.testProcessExecuteInstance</a></summary>
<br/>Wanted but not invoked:<br/>kogitoRuntimeClient.executeProcessInstance(<br/> ProcessDefinition{id='infra', name='null', version='1.0', type='null', roles=null, addons=null, endpoint='null', nodes='null'},<br/> ExecuteArgs[input={"assesmentVar":"assesmentValue","clientVar":"clientValue"}, businessKey=null, referenceId=null]<br/>);<br/>-> at org.kie.kogito.index.service.graphql.query.AbstractGraphQLRuntimesQueriesIT.testProcessExecuteInstance(AbstractGraphQLRuntimesQueriesIT.java:124)<br/>Actually, there were zero interactions with this mock.<br/>
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/5/testReport/org.kie.kogito.index.service.messaging/MongoDBMessagingHttpConsumerIT/testProcessDefinitionEventCollection/">org.kie.kogito.index.service.messaging.MongoDBMessagingHttpConsumerIT.testProcessDefinitionEventCollection</a></summary>
Cannot invoke method size() on null object
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/5/testReport/org.kie.kogito.index.service.messaging/MongoDBMessagingHttpConsumerIT/testProcessDefinitionEvent/">org.kie.kogito.index.service.messaging.MongoDBMessagingHttpConsumerIT.testProcessDefinitionEvent</a></summary>
Cannot invoke method size() on null object
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/5/testReport/org.kie.kogito.index.service.messaging/MongoDBMessagingKafkaConsumerIT/testProcessDefinitionEventCollection/">org.kie.kogito.index.service.messaging.MongoDBMessagingKafkaConsumerIT.testProcessDefinitionEventCollection</a></summary>
Cannot invoke method size() on null object
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/5/testReport/org.kie.kogito.index.service.messaging/MongoDBMessagingKafkaConsumerIT/testProcessDefinitionEvent/">org.kie.kogito.index.service.messaging.MongoDBMessagingKafkaConsumerIT.testProcessDefinitionEvent</a></summary>
Cannot invoke method size() on null object
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/5/testReport/org.kie.kogito.index.service/PostgreSqlIndexingServiceIT/testConcurrentProcessInstanceIndex/">org.kie.kogito.index.service.PostgreSqlIndexingServiceIT.testConcurrentProcessInstanceIndex</a></summary>
Assertion condition defined as a org.kie.kogito.index.service.AbstractIndexingServiceIT 1 expectation failed.<br/>JSON path data.ProcessInstances[0].id doesn't match.<br/>Expected: is "9f26e44b-8709-4905-911c-67957c67be86"<br/> Actual: null<br/> within 30 seconds.
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/5/testReport/org.kie.kogito.index.service/PostgreSqlIndexingServiceIT/testProcessInstanceIndex/">org.kie.kogito.index.service.PostgreSqlIndexingServiceIT.testProcessInstanceIndex</a></summary>
Assertion condition defined as a org.kie.kogito.index.service.AbstractIndexingServiceIT 1 expectation failed.<br/>JSON path data.ProcessInstances[0].id doesn't match.<br/>Expected: is "97c32ec2-a95e-497d-84bc-7bdf49619af1"<br/> Actual: null<br/> within 30 seconds.
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/5/testReport/org.kie.kogito.index.service/PostgreSqlIndexingServiceIT/testProcessInstancePagination/">org.kie.kogito.index.service.PostgreSqlIndexingServiceIT.testProcessInstancePagination</a></summary>
Cannot invoke method size() on null object
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/5/testReport/org.kie.kogito.index.service.messaging/PostgreSqlMessagingHttpConsumerIT/testProcessInstanceEvent/">org.kie.kogito.index.service.messaging.PostgreSqlMessagingHttpConsumerIT.testProcessInstanceEvent</a></summary>
Cannot invoke method size() on null object
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/5/testReport/org.kie.kogito.index.service.messaging/PostgreSqlMessagingHttpConsumerIT/testProcessInstanceEventCollection/">org.kie.kogito.index.service.messaging.PostgreSqlMessagingHttpConsumerIT.testProcessInstanceEventCollection</a></summary>
Cannot invoke method size() on null object
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/5/testReport/org.kie.kogito.index.service.messaging/PostgreSqlMessagingKafkaConsumerIT/testProcessInstanceEvent/">org.kie.kogito.index.service.messaging.PostgreSqlMessagingKafkaConsumerIT.testProcessInstanceEvent</a></summary>
Cannot invoke method size() on null object
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/5/testReport/org.kie.kogito.index.service.messaging/PostgreSqlMessagingKafkaConsumerIT/testProcessInstanceEventCollection/">org.kie.kogito.index.service.messaging.PostgreSqlMessagingKafkaConsumerIT.testProcessInstanceEventCollection</a></summary>
Cannot invoke method size() on null object
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/5/testReport/org.kie.kogito.index.jdbc.query/H2ProcessDefinitionEntityQueryIT/testProcessDefinitionQuery/">org.kie.kogito.index.jdbc.query.H2ProcessDefinitionEntityQueryIT.testProcessDefinitionQuery</a></summary>
could not prepare statement [Column "PDE1_0.METADATA" not found; SQL statement:<br/>select pde1_0.id,pde1_0.version,pde1_0.description,pde1_0.endpoint,pde1_0.metadata,pde1_0.name,pde1_0.source,pde1_0.type,n1_0.process_id,n1_0.process_version,n1_0.id,n1_0.name,n1_0.type,n1_0.unique_id from definitions pde1_0 left join definitions_nodes n1_0 on pde1_0.id=n1_0.process_id and pde1_0.version=n1_0.process_version where (pde1_0.id,pde1_0.version) in ((?,?)) [42122-232]] [select pde1_0.id,pde1_0.version,pde1_0.description,pde1_0.endpoint,pde1_0.metadata,pde1_0.name,pde1_0.source,pde1_0.type,n1_0.process_id,n1_0.process_version,n1_0.id,n1_0.name,n1_0.type,n1_0.unique_id from definitions pde1_0 left join definitions_nodes n1_0 on pde1_0.id=n1_0.process_id and pde1_0.version=n1_0.process_version where (pde1_0.id,pde1_0.version) in ((?,?))]
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/5/testReport/org.kie.kogito.index.jdbc.storage/H2ProcessDefinitionStorageIT/testProcessDefinitionEntity/">org.kie.kogito.index.jdbc.storage.H2ProcessDefinitionStorageIT.testProcessDefinitionEntity</a></summary>
could not prepare statement [Column "PDE1_0.METADATA" not found; SQL statement:<br/>select pde1_0.id,pde1_0.version,pde1_0.description,pde1_0.endpoint,pde1_0.metadata,pde1_0.name,pde1_0.source,pde1_0.type from definitions pde1_0 where (pde1_0.id,pde1_0.version) in ((?,?)) [42122-232]] [select pde1_0.id,pde1_0.version,pde1_0.description,pde1_0.endpoint,pde1_0.metadata,pde1_0.name,pde1_0.source,pde1_0.type from definitions pde1_0 where (pde1_0.id,pde1_0.version) in ((?,?))]
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/5/testReport/org.kie.kogito.addons.quarkus.data.index.it/JPAQuarkusAddonDataIndexPersistenceTest/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.JPAQuarkusAddonDataIndexPersistenceTest.testDataIndexAddon</a></summary>
java.lang.RuntimeException: Failed to start quarkus
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/5/testReport/org.kie.kogito.addons.quarkus.data.index.it/JPAQuarkusAddonDataIndexPersistenceTest/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.JPAQuarkusAddonDataIndexPersistenceTest.testDataIndexAddon</a></summary>
java.lang.RuntimeException: Failed to start quarkus
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/5/testReport/org.kie.kogito.addons.quarkus.data.index.it/MongoQuarkusAddonDataIndexPersistenceIT/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.MongoQuarkusAddonDataIndexPersistenceIT.testDataIndexAddon</a></summary>
java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/5/testReport/org.kie.kogito.addons.quarkus.data.index.it/MongoQuarkusAddonDataIndexPersistenceIT/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.MongoQuarkusAddonDataIndexPersistenceIT.testDataIndexAddon</a></summary>
1 expectation failed.<br/>JSON path data.ProcessDefinitions[0].id doesn't match.<br/>Expected: is "greet"<br/> Actual: null<br/>
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/5/testReport/org.kie.kogito.addons.quarkus.data.index.it/JPAQuarkusAddonDataIndexIT/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.JPAQuarkusAddonDataIndexIT.testDataIndexAddon</a></summary>
java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/5/testReport/org.kie.kogito.addons.quarkus.data.index.it/JPAQuarkusAddonDataIndexIT/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.JPAQuarkusAddonDataIndexIT.testDataIndexAddon</a></summary>
java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/5/testReport/org.kie.kogito.addons.quarkus.data.index.it/MongoQuarkusAddonDataIndexIT/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.MongoQuarkusAddonDataIndexIT.testDataIndexAddon</a></summary>
java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/5/testReport/org.kie.kogito.addons.quarkus.data.index.it/MongoQuarkusAddonDataIndexIT/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.MongoQuarkusAddonDataIndexIT.testDataIndexAddon</a></summary>
java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix #2169 Allow filtering over processInstances.definition and definition.metadata [incubator-kie-kogito-apps]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on code in PR #2191:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2191#discussion_r1954646849
##########
data-index/data-index-storage/data-index-storage-mongodb/src/main/java/org/kie/kogito/index/mongodb/model/ProcessDefinitionEntity.java:
##########
@@ -148,11 +148,11 @@ public void setAnnotations(Set<String> annotations) {
this.annotations = annotations;
}
- public Map<String, String> getMetadata() {
+ public Map<String, Object> getMetadata() {
Review Comment:
I tested it works by performing a quick test
```
public class MongoDBTest {
public static void main(String[] args) {
String uri = "mongodb://localhost";
try (MongoClient mongoClient = MongoClients.create(uri)) {
MongoDatabase database = mongoClient.getDatabase("sample_mflix");
MongoCollection<Document> collection = database.getCollection("movies");
// Map<String,String> map = Map.of("name","pepe");
// Document insert = new Document();
//insert.put("person", map);
//collection.insertOne(new Document(insert));
Document doc = collection.find(eq("person.name", "pepe")).first();
Map<String,Object> map = (Map<String, Object>) doc.get("person");
if (doc != null) {
System.out.println(map);
} else {
System.out.println("No matching documents found.");
}
}
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [Fix #2169] Allow filtering over processInstances.definition and definition.metadata [incubator-kie-kogito-apps]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on code in PR #2191:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2191#discussion_r1959416202
##########
data-index/data-index-storage/data-index-storage-jpa/src/main/resources/kie-flyway/db/data-index/ansi/V1.45.1.0__metadata_as_column.sql:
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+ALTER TABLE definitions ADD COLUMN metadata varchar(max);
+
+/* Migration for postgresql and sql server
+ UPDATE definitions SET metadata =
+(SELECT string_agg(name || '=' || meta_value, ',') FROM definitions_metadata where process_id = a.process_id and process_version = a.process_version)
+FROM definitions_metadata as a
+WHERE process_id = a.process_id and process_version = a.process_version;
+*/
+
+
+/* Migration for h2 and oracle
+ UPDATE definitions SET metadata =
+(SELECT listagg(name || '=' || meta_value, ',') FROM definitions_metadata where process_id = a.process_id and process_version = a.process_version)
+FROM definitions_metadata as a
+WHERE process_id = a.process_id and process_version = a.process_version;
+*/
+
+/* Since migration is disable, do not delete not longer used table
+ * DROP TABLE definitions_metadata;*/
Review Comment:
I think, in this case, as an exception, it is worth to keep it in case users want to manually execute the script for their DB.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [Fix #2169] Allow filtering over processInstances.definition and definition.metadata [incubator-kie-kogito-apps]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on code in PR #2191:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2191#discussion_r1959418519
##########
data-index/data-index-storage/data-index-storage-postgresql/src/main/java/org/kie/kogito/index/postgresql/PostgresqlJsonHelper.java:
##########
@@ -101,11 +105,26 @@ private static Expression buildObjectExpression(CriteriaBuilder builder, Object
private static Expression buildPathExpression(CriteriaBuilder builder, Root<?> root, String attributeName, boolean isStr) {
String[] attributes = attributeName.split("\\.");
- Expression<?>[] arguments = new Expression[attributes.length];
- arguments[0] = root.get(attributes[0]);
- for (int i = 1; i < attributes.length; i++) {
- arguments[i] = builder.literal(attributes[i]);
+
+ Collection<Expression> arguments = new ArrayList<>();
+ if (attributes.length == 1)
+ return root.get(attributeName);
+ int startIndex;
+ // Check if the first attribute is a join, if it is, assume next attribute is the json property (not sure thats necessarily correct but it will work)
+ try {
+ Join join = root.join(attributes[0]);
Review Comment:
The idea here is that the first attribute might be joinable or be the json variable directly. It wont cover the case in which the json variable is in the third level, which so far does not exist and I do not think it will ever exist
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix #2169 Allow filtering over processInstances.definition and definition.metadata [incubator-kie-kogito-apps]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on code in PR #2191:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2191#discussion_r1955955662
##########
data-index/data-index-storage/data-index-storage-jpa/src/main/resources/kie-flyway/db/data-index/ansi/V1.45.1.0__metadata_as_column.sql:
##########
@@ -0,0 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+ALTER TABLE definitions ADD COLUMN metadata varchar(max);
+
Review Comment:
I commented deletion of the old data and added how the script to migrate data should look for different dbs (in case users want to apply manually)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix #2169 Allow filtering over processInstances.definition and definition.metadata [incubator-kie-kogito-apps]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on code in PR #2191:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2191#discussion_r1954501286
##########
data-index/data-index-storage/data-index-storage-jpa/src/main/resources/kie-flyway/db/data-index/ansi/V1.45.1.0__metadata_as_column.sql:
##########
@@ -0,0 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+ALTER TABLE definitions ADD COLUMN metadata varchar(max);
+
Review Comment:
I do not think we need data migration for metedata when using "ansi" JPA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix #2169 Allow filtering over processInstances.definition and definition.metadata [incubator-kie-kogito-apps]
Posted by "kie-ci3 (via GitHub)" <gi...@apache.org>.
kie-ci3 commented on PR #2191:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2191#issuecomment-2648787811
**PR job** `#6` was: **UNSTABLE**
Possible explanation: This should be test failures
<details>
<summary><b>Reproducer</b></summary>
build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u https://github.com/apache/incubator-kie-kogito-apps/pull/2191 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution
</details>
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/6/display/redirect
**Test results:**
- PASSED: 1778
- FAILED: 34
Those are the test failures:
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/6/testReport/org.kie.kogito.index.mongodb/ProcessDataIndexMongoDBHttpIT/testProcessInstanceEvents/">org.kie.kogito.index.mongodb.ProcessDataIndexMongoDBHttpIT.testProcessInstanceEvents</a></summary>
Cannot invoke method size() on null object
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/6/testReport/org.kie.kogito.index.mongodb/ProcessDataIndexMongoDBKafkaIT/testProcessInstanceEvents/">org.kie.kogito.index.mongodb.ProcessDataIndexMongoDBKafkaIT.testProcessInstanceEvents</a></summary>
Cannot invoke method size() on null object
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/6/testReport/org.kie.kogito.index/ProcessDataIndexMongoDBIT/testProcessInstanceEvents/">org.kie.kogito.index.ProcessDataIndexMongoDBIT.testProcessInstanceEvents</a></summary>
Cannot invoke method size() on null object
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/6/testReport/org.kie.kogito.index/ProcessDataIndexPostgreSqlIT/testProcessInstanceEvents/">org.kie.kogito.index.ProcessDataIndexPostgreSqlIT.testProcessInstanceEvents</a></summary>
Cannot invoke method size() on null object
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/6/testReport/org.kie.kogito.index.service/InmemoryPostgreSqlIndexingServiceIT/testConcurrentProcessInstanceIndex/">org.kie.kogito.index.service.InmemoryPostgreSqlIndexingServiceIT.testConcurrentProcessInstanceIndex</a></summary>
Assertion condition defined as a org.kie.kogito.index.service.AbstractIndexingServiceIT 1 expectation failed.<br/>JSON path data.ProcessInstances[0].id doesn't match.<br/>Expected: is "e0031a18-7a65-4042-ae43-5241af3063d0"<br/> Actual: null<br/> within 30 seconds.
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/6/testReport/org.kie.kogito.index.service/InmemoryPostgreSqlIndexingServiceIT/testProcessInstanceIndex/">org.kie.kogito.index.service.InmemoryPostgreSqlIndexingServiceIT.testProcessInstanceIndex</a></summary>
Assertion condition defined as a org.kie.kogito.index.service.AbstractIndexingServiceIT 1 expectation failed.<br/>JSON path data.ProcessInstances[0].id doesn't match.<br/>Expected: is "00c46faa-6309-4eca-9401-ff40902cab05"<br/> Actual: null<br/> within 30 seconds.
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/6/testReport/org.kie.kogito.index.service/InmemoryPostgreSqlIndexingServiceIT/testDefaultGraphqlTypes/">org.kie.kogito.index.service.InmemoryPostgreSqlIndexingServiceIT.testDefaultGraphqlTypes</a></summary>
JDBC exception executing SQL [delete from definitions pde1_0] [ERROR: update or delete on table "definitions" violates foreign key constraint "fk7jdn9rdvtq3ktsajobr9x1sx1" on table "processes"<br/> Detail: Key (id, version)=(travels, 1.0) is still referenced from table "processes".] [n/a]
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/6/testReport/org.kie.kogito.index.service/InmemoryPostgreSqlIndexingServiceIT/testProcessInstancePagination/">org.kie.kogito.index.service.InmemoryPostgreSqlIndexingServiceIT.testProcessInstancePagination</a></summary>
Assertion condition defined as a org.kie.kogito.index.service.AbstractIndexingServiceIT 1 expectation failed.<br/>JSON path data.ProcessInstances.size() doesn't match.<br/>Expected: is <1><br/> Actual: <2><br/> within 30 seconds.
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/6/testReport/org.kie.kogito.index.service/InmemoryPostgreSqlIndexingServiceIT/testJobIndex/">org.kie.kogito.index.service.InmemoryPostgreSqlIndexingServiceIT.testJobIndex</a></summary>
JDBC exception executing SQL [delete from definitions pde1_0] [ERROR: update or delete on table "definitions" violates foreign key constraint "fk7jdn9rdvtq3ktsajobr9x1sx1" on table "processes"<br/> Detail: Key (id, version)=(travels, 1.0) is still referenced from table "processes".] [n/a]
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/6/testReport/org.kie.kogito.index.service/InmemoryPostgreSqlIndexingServiceIT/testUserTaskInstanceIndex/">org.kie.kogito.index.service.InmemoryPostgreSqlIndexingServiceIT.testUserTaskInstanceIndex</a></summary>
JDBC exception executing SQL [delete from definitions pde1_0] [ERROR: update or delete on table "definitions" violates foreign key constraint "fk7jdn9rdvtq3ktsajobr9x1sx1" on table "processes"<br/> Detail: Key (id, version)=(travels, 1.0) is still referenced from table "processes".] [n/a]
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/6/testReport/org.kie.kogito.index.service/InmemoryPostgreSqlIndexingServiceIT/testUserTaskInstancePagination/">org.kie.kogito.index.service.InmemoryPostgreSqlIndexingServiceIT.testUserTaskInstancePagination</a></summary>
Assertion condition defined as a org.kie.kogito.index.service.AbstractIndexingServiceIT 1 expectation failed.<br/>JSON path data.UserTaskInstances.size() doesn't match.<br/>Expected: is <1><br/> Actual: <2><br/> within 30 seconds.
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/6/testReport/org.kie.kogito.index.service/MongoDomainIndexingServiceIT/testProcessInstanceIndex/">org.kie.kogito.index.service.MongoDomainIndexingServiceIT.testProcessInstanceIndex</a></summary>
Assertion condition defined as a org.kie.kogito.index.service.AbstractIndexingServiceIT 1 expectation failed.<br/>JSON path data.ProcessDefinitions[0].id doesn't match.<br/>Expected: is "travels"<br/> Actual: null<br/> within 30 seconds.
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/6/testReport/org.kie.kogito.index.service.graphql.query/MongoGraphQLRuntimesQueriesIT/testProcessExecuteInstance/">org.kie.kogito.index.service.graphql.query.MongoGraphQLRuntimesQueriesIT.testProcessExecuteInstance</a></summary>
<br/>Wanted but not invoked:<br/>kogitoRuntimeClient.executeProcessInstance(<br/> ProcessDefinition{id='infra', name='null', version='1.0', type='null', roles=null, addons=null, endpoint='null', nodes='null'},<br/> ExecuteArgs[input={"assesmentVar":"assesmentValue","clientVar":"clientValue"}, businessKey=null, referenceId=null]<br/>);<br/>-> at org.kie.kogito.index.service.graphql.query.AbstractGraphQLRuntimesQueriesIT.testProcessExecuteInstance(AbstractGraphQLRuntimesQueriesIT.java:124)<br/>Actually, there were zero interactions with this mock.<br/>
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/6/testReport/org.kie.kogito.index.service.messaging/MongoDBMessagingHttpConsumerIT/testProcessDefinitionEventCollection/">org.kie.kogito.index.service.messaging.MongoDBMessagingHttpConsumerIT.testProcessDefinitionEventCollection</a></summary>
Cannot invoke method size() on null object
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/6/testReport/org.kie.kogito.index.service.messaging/MongoDBMessagingHttpConsumerIT/testProcessDefinitionEvent/">org.kie.kogito.index.service.messaging.MongoDBMessagingHttpConsumerIT.testProcessDefinitionEvent</a></summary>
Cannot invoke method size() on null object
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/6/testReport/org.kie.kogito.index.service.messaging/MongoDBMessagingKafkaConsumerIT/testProcessDefinitionEventCollection/">org.kie.kogito.index.service.messaging.MongoDBMessagingKafkaConsumerIT.testProcessDefinitionEventCollection</a></summary>
Cannot invoke method size() on null object
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/6/testReport/org.kie.kogito.index.service.messaging/MongoDBMessagingKafkaConsumerIT/testProcessDefinitionEvent/">org.kie.kogito.index.service.messaging.MongoDBMessagingKafkaConsumerIT.testProcessDefinitionEvent</a></summary>
Cannot invoke method size() on null object
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/6/testReport/org.kie.kogito.index.service/PostgreSqlIndexingServiceIT/testConcurrentProcessInstanceIndex/">org.kie.kogito.index.service.PostgreSqlIndexingServiceIT.testConcurrentProcessInstanceIndex</a></summary>
Assertion condition defined as a org.kie.kogito.index.service.AbstractIndexingServiceIT 1 expectation failed.<br/>JSON path data.ProcessInstances[0].id doesn't match.<br/>Expected: is "c5d89771-6527-4b80-94a5-2f34d3ffa768"<br/> Actual: null<br/> within 30 seconds.
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/6/testReport/org.kie.kogito.index.service/PostgreSqlIndexingServiceIT/testProcessInstanceIndex/">org.kie.kogito.index.service.PostgreSqlIndexingServiceIT.testProcessInstanceIndex</a></summary>
Assertion condition defined as a org.kie.kogito.index.service.AbstractIndexingServiceIT 1 expectation failed.<br/>JSON path data.ProcessInstances[0].id doesn't match.<br/>Expected: is "946b6031-a49f-4945-9c3e-8b902d497b32"<br/> Actual: null<br/> within 30 seconds.
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/6/testReport/org.kie.kogito.index.service/PostgreSqlIndexingServiceIT/testProcessInstancePagination/">org.kie.kogito.index.service.PostgreSqlIndexingServiceIT.testProcessInstancePagination</a></summary>
Cannot invoke method size() on null object
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/6/testReport/org.kie.kogito.index.service.messaging/PostgreSqlMessagingHttpConsumerIT/testProcessInstanceEvent/">org.kie.kogito.index.service.messaging.PostgreSqlMessagingHttpConsumerIT.testProcessInstanceEvent</a></summary>
Cannot invoke method size() on null object
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/6/testReport/org.kie.kogito.index.service.messaging/PostgreSqlMessagingHttpConsumerIT/testProcessInstanceEventCollection/">org.kie.kogito.index.service.messaging.PostgreSqlMessagingHttpConsumerIT.testProcessInstanceEventCollection</a></summary>
Cannot invoke method size() on null object
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/6/testReport/org.kie.kogito.index.service.messaging/PostgreSqlMessagingKafkaConsumerIT/testProcessInstanceEvent/">org.kie.kogito.index.service.messaging.PostgreSqlMessagingKafkaConsumerIT.testProcessInstanceEvent</a></summary>
Cannot invoke method size() on null object
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/6/testReport/org.kie.kogito.index.service.messaging/PostgreSqlMessagingKafkaConsumerIT/testProcessInstanceEventCollection/">org.kie.kogito.index.service.messaging.PostgreSqlMessagingKafkaConsumerIT.testProcessInstanceEventCollection</a></summary>
Cannot invoke method size() on null object
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/6/testReport/org.kie.kogito.index.jdbc.query/H2ProcessDefinitionEntityQueryIT/testProcessDefinitionQuery/">org.kie.kogito.index.jdbc.query.H2ProcessDefinitionEntityQueryIT.testProcessDefinitionQuery</a></summary>
could not prepare statement [Column "PDE1_0.METADATA" not found; SQL statement:<br/>select pde1_0.id,pde1_0.version,pde1_0.description,pde1_0.endpoint,pde1_0.metadata,pde1_0.name,pde1_0.source,pde1_0.type,n1_0.process_id,n1_0.process_version,n1_0.id,n1_0.name,n1_0.type,n1_0.unique_id from definitions pde1_0 left join definitions_nodes n1_0 on pde1_0.id=n1_0.process_id and pde1_0.version=n1_0.process_version where (pde1_0.id,pde1_0.version) in ((?,?)) [42122-232]] [select pde1_0.id,pde1_0.version,pde1_0.description,pde1_0.endpoint,pde1_0.metadata,pde1_0.name,pde1_0.source,pde1_0.type,n1_0.process_id,n1_0.process_version,n1_0.id,n1_0.name,n1_0.type,n1_0.unique_id from definitions pde1_0 left join definitions_nodes n1_0 on pde1_0.id=n1_0.process_id and pde1_0.version=n1_0.process_version where (pde1_0.id,pde1_0.version) in ((?,?))]
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/6/testReport/org.kie.kogito.index.jdbc.storage/H2ProcessDefinitionStorageIT/testProcessDefinitionEntity/">org.kie.kogito.index.jdbc.storage.H2ProcessDefinitionStorageIT.testProcessDefinitionEntity</a></summary>
could not prepare statement [Column "PDE1_0.METADATA" not found; SQL statement:<br/>select pde1_0.id,pde1_0.version,pde1_0.description,pde1_0.endpoint,pde1_0.metadata,pde1_0.name,pde1_0.source,pde1_0.type from definitions pde1_0 where (pde1_0.id,pde1_0.version) in ((?,?)) [42122-232]] [select pde1_0.id,pde1_0.version,pde1_0.description,pde1_0.endpoint,pde1_0.metadata,pde1_0.name,pde1_0.source,pde1_0.type from definitions pde1_0 where (pde1_0.id,pde1_0.version) in ((?,?))]
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/6/testReport/org.kie.kogito.addons.quarkus.data.index.it/JPAQuarkusAddonDataIndexPersistenceTest/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.JPAQuarkusAddonDataIndexPersistenceTest.testDataIndexAddon</a></summary>
java.lang.RuntimeException: Failed to start quarkus
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/6/testReport/org.kie.kogito.addons.quarkus.data.index.it/JPAQuarkusAddonDataIndexPersistenceTest/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.JPAQuarkusAddonDataIndexPersistenceTest.testDataIndexAddon</a></summary>
java.lang.RuntimeException: Failed to start quarkus
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/6/testReport/org.kie.kogito.addons.quarkus.data.index.it/MongoQuarkusAddonDataIndexPersistenceIT/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.MongoQuarkusAddonDataIndexPersistenceIT.testDataIndexAddon</a></summary>
1 expectation failed.<br/>JSON path data.ProcessDefinitions[0].id doesn't match.<br/>Expected: is "hello"<br/> Actual: null<br/>
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/6/testReport/org.kie.kogito.addons.quarkus.data.index.it/MongoQuarkusAddonDataIndexPersistenceIT/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.MongoQuarkusAddonDataIndexPersistenceIT.testDataIndexAddon</a></summary>
java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/6/testReport/org.kie.kogito.addons.quarkus.data.index.it/JPAQuarkusAddonDataIndexIT/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.JPAQuarkusAddonDataIndexIT.testDataIndexAddon</a></summary>
java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/6/testReport/org.kie.kogito.addons.quarkus.data.index.it/JPAQuarkusAddonDataIndexIT/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.JPAQuarkusAddonDataIndexIT.testDataIndexAddon</a></summary>
java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/6/testReport/org.kie.kogito.addons.quarkus.data.index.it/MongoQuarkusAddonDataIndexIT/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.MongoQuarkusAddonDataIndexIT.testDataIndexAddon</a></summary>
Cannot invoke method size() on null object
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/6/testReport/org.kie.kogito.addons.quarkus.data.index.it/MongoQuarkusAddonDataIndexIT/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.MongoQuarkusAddonDataIndexIT.testDataIndexAddon</a></summary>
Cannot invoke method size() on null object
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix #2169 Allow filtering over processInstances.definition and definition.metadata [incubator-kie-kogito-apps]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on code in PR #2191:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2191#discussion_r1954514033
##########
data-index/data-index-storage/data-index-storage-mongodb/src/main/java/org/kie/kogito/index/mongodb/model/ProcessDefinitionEntity.java:
##########
@@ -148,11 +148,11 @@ public void setAnnotations(Set<String> annotations) {
this.annotations = annotations;
}
- public Map<String, String> getMetadata() {
+ public Map<String, Object> getMetadata() {
Review Comment:
MongoDb should handle the Map<String,Object> in a similar way than the Map<String,String>, but it will be good to test this manually with an existing mongodb table
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix #2169 Allow filtering over processInstances.definition and definition.metadata [incubator-kie-kogito-apps]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on code in PR #2191:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2191#discussion_r1954502914
##########
data-index/data-index-storage/data-index-storage-api/src/main/java/org/kie/kogito/index/model/ProcessDefinition.java:
##########
@@ -126,11 +126,11 @@ public void setAnnotations(Set<String> annotations) {
this.annotations = annotations;
}
- public Map<String, String> getMetadata() {
+ public Map<String, Object> getMetadata() {
Review Comment:
This is the only change in the model.
Moving from string to object allow us to use something different than a String (currently only supported by postgresql) and keep other Dbs basically unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix #2169 Allow filtering over processInstances.definition and definition.metadata [incubator-kie-kogito-apps]
Posted by "kie-ci3 (via GitHub)" <gi...@apache.org>.
kie-ci3 commented on PR #2191:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2191#issuecomment-2654718511
**PR job** `#13` was: **UNSTABLE**
Possible explanation: This should be test failures
<details>
<summary><b>Reproducer</b></summary>
build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u https://github.com/apache/incubator-kie-kogito-apps/pull/2191 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution
</details>
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/13/display/redirect
**Test results:**
- PASSED: 1816
- FAILED: 2
Those are the test failures:
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/13/testReport/org.kie.kogito.addons.quarkus.data.index.it/MongoQuarkusAddonDataIndexIT/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.MongoQuarkusAddonDataIndexIT.testDataIndexAddon</a></summary>
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors<br/> [error]: Build step io.quarkus.mongodb.deployment.DevServicesMongoProcessor#startMongo threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image docker.io/mongo:7.0<br/> at io.quarkus.mongodb.deployment.DevServicesMongoProcessor.startMongo(DevServicesMongoProcessor.java:122)<br/> at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732)<br/> at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)<br/> at io.quarkus.builder.BuildContext.run(BuildContext.java:256)<br/> at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)<br/> at org.jboss.threads.EnhancedQueueExecutor$Task.doRunWith(EnhancedQueueExecutor.java:2516)<br/> at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2495)<br/> at org.jboss.threads.E
nhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1521)<br/> at java.base/java.lang.Thread.run(Thread.java:840)<br/> at org.jboss.threads.JBossThread.run(JBossThread.java:483)<br/>Caused by: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image docker.io/mongo:7.0<br/> at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:359)<br/> at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:330)<br/> at io.quarkus.mongodb.deployment.DevServicesMongoProcessor.lambda$startMongo$0(DevServicesMongoProcessor.java:191)<br/> at java.base/java.util.Optional.orElseGet(Optional.java:364)<br/> at io.quarkus.mongodb.deployment.DevServicesMongoProcessor.startMongo(DevServicesMongoProcessor.java:208)<br/> at io.quarkus.mongodb.deployment.DevServicesMongoProcessor.startMongo(DevServicesMongoProcessor.java:112)<br/> ... 9 more<br/>Caused by: org.rnorth.ducttape.RetryCountExceededException: Retry limit hit
with exception<br/> at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:88)<br/> at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:344)<br/> ... 14 more<br/>Caused by: org.testcontainers.containers.ContainerLaunchException: Could not create/start container<br/> at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:563)<br/> at org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:354)<br/> at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81)<br/> ... 15 more<br/>Caused by: java.lang.IllegalStateException: Wait strategy failed. Container exited with code 132<br/> at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:533)<br/> ... 17 more<br/>Caused by: org.testcontainers.containers.ContainerLaunchException: Timed out waiting for log output matching '(?i).*waiting for connections.*'<br/> at org.testcontainers
.containers.wait.strategy.LogMessageWaitStrategy.waitUntilReady(LogMessageWaitStrategy.java:47)<br/> at org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:52)<br/> at org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:909)<br/> at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:500)<br/> ... 17 more<br/>
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/13/testReport/org.kie.kogito.addons.quarkus.data.index.it/MongoQuarkusAddonDataIndexIT/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.MongoQuarkusAddonDataIndexIT.testDataIndexAddon</a></summary>
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors<br/> [error]: Build step io.quarkus.mongodb.deployment.DevServicesMongoProcessor#startMongo threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image docker.io/mongo:7.0<br/> at io.quarkus.mongodb.deployment.DevServicesMongoProcessor.startMongo(DevServicesMongoProcessor.java:122)<br/> at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732)<br/> at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)<br/> at io.quarkus.builder.BuildContext.run(BuildContext.java:256)<br/> at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)<br/> at org.jboss.threads.EnhancedQueueExecutor$Task.doRunWith(EnhancedQueueExecutor.java:2516)<br/> at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2495)<br/> at org.jboss.threads.E
nhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1521)<br/> at java.base/java.lang.Thread.run(Thread.java:840)<br/> at org.jboss.threads.JBossThread.run(JBossThread.java:483)<br/>Caused by: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image docker.io/mongo:7.0<br/> at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:359)<br/> at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:330)<br/> at io.quarkus.mongodb.deployment.DevServicesMongoProcessor.lambda$startMongo$0(DevServicesMongoProcessor.java:191)<br/> at java.base/java.util.Optional.orElseGet(Optional.java:364)<br/> at io.quarkus.mongodb.deployment.DevServicesMongoProcessor.startMongo(DevServicesMongoProcessor.java:208)<br/> at io.quarkus.mongodb.deployment.DevServicesMongoProcessor.startMongo(DevServicesMongoProcessor.java:112)<br/> ... 9 more<br/>Caused by: org.rnorth.ducttape.RetryCountExceededException: Retry limit hit
with exception<br/> at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:88)<br/> at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:344)<br/> ... 14 more<br/>Caused by: org.testcontainers.containers.ContainerLaunchException: Could not create/start container<br/> at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:563)<br/> at org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:354)<br/> at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81)<br/> ... 15 more<br/>Caused by: java.lang.IllegalStateException: Wait strategy failed. Container exited with code 132<br/> at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:533)<br/> ... 17 more<br/>Caused by: org.testcontainers.containers.ContainerLaunchException: Timed out waiting for log output matching '(?i).*waiting for connections.*'<br/> at org.testcontainers
.containers.wait.strategy.LogMessageWaitStrategy.waitUntilReady(LogMessageWaitStrategy.java:47)<br/> at org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:52)<br/> at org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:909)<br/> at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:500)<br/> ... 17 more<br/>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [Fix #2169] Allow filtering over processInstances.definition and definition.metadata [incubator-kie-kogito-apps]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado merged PR #2191:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix #2169 Allow filtering over processInstances.definition and definition.metadata [incubator-kie-kogito-apps]
Posted by "kie-ci3 (via GitHub)" <gi...@apache.org>.
kie-ci3 commented on PR #2191:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2191#issuecomment-2654210707
**PR job** `#11` was: **UNSTABLE**
Possible explanation: This should be test failures
<details>
<summary><b>Reproducer</b></summary>
build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u https://github.com/apache/incubator-kie-kogito-apps/pull/2191 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution
</details>
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/11/display/redirect
**Test results:**
- PASSED: 1771
- FAILED: 16
Those are the test failures:
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/11/testReport/org.kie.kogito.index.service/InmemoryPostgreSqlIndexingServiceIT/testConcurrentProcessInstanceIndex/">org.kie.kogito.index.service.InmemoryPostgreSqlIndexingServiceIT.testConcurrentProcessInstanceIndex</a></summary>
Assertion condition defined as a org.kie.kogito.index.service.AbstractIndexingServiceIT 1 expectation failed.<br/>JSON path data.ProcessInstances[0].id doesn't match.<br/>Expected: is "9d3acc42-70e0-4c80-8b0b-544054d35da0"<br/> Actual: null<br/> within 30 seconds.
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/11/testReport/org.kie.kogito.index.service/InmemoryPostgreSqlIndexingServiceIT/testProcessInstanceIndex/">org.kie.kogito.index.service.InmemoryPostgreSqlIndexingServiceIT.testProcessInstanceIndex</a></summary>
Assertion condition defined as a org.kie.kogito.index.service.AbstractIndexingServiceIT 1 expectation failed.<br/>JSON path data.ProcessInstances[0].id doesn't match.<br/>Expected: is "c85f4582-7676-43d8-bf7e-e75cac9cb347"<br/> Actual: null<br/> within 30 seconds.
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/11/testReport/org.kie.kogito.index.service/InmemoryPostgreSqlIndexingServiceIT/testDefaultGraphqlTypes/">org.kie.kogito.index.service.InmemoryPostgreSqlIndexingServiceIT.testDefaultGraphqlTypes</a></summary>
JDBC exception executing SQL [delete from definitions pde1_0] [ERROR: update or delete on table "definitions" violates foreign key constraint "fk7jdn9rdvtq3ktsajobr9x1sx1" on table "processes"<br/> Detail: Key (id, version)=(travels, 1.0) is still referenced from table "processes".] [n/a]
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/11/testReport/org.kie.kogito.index.service/InmemoryPostgreSqlIndexingServiceIT/testProcessInstancePagination/">org.kie.kogito.index.service.InmemoryPostgreSqlIndexingServiceIT.testProcessInstancePagination</a></summary>
Assertion condition defined as a org.kie.kogito.index.service.AbstractIndexingServiceIT 1 expectation failed.<br/>JSON path data.ProcessInstances.size() doesn't match.<br/>Expected: is <1><br/> Actual: <2><br/> within 30 seconds.
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/11/testReport/org.kie.kogito.index.service/InmemoryPostgreSqlIndexingServiceIT/testJobIndex/">org.kie.kogito.index.service.InmemoryPostgreSqlIndexingServiceIT.testJobIndex</a></summary>
JDBC exception executing SQL [delete from definitions pde1_0] [ERROR: update or delete on table "definitions" violates foreign key constraint "fk7jdn9rdvtq3ktsajobr9x1sx1" on table "processes"<br/> Detail: Key (id, version)=(travels, 1.0) is still referenced from table "processes".] [n/a]
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/11/testReport/org.kie.kogito.index.service/InmemoryPostgreSqlIndexingServiceIT/testUserTaskInstanceIndex/">org.kie.kogito.index.service.InmemoryPostgreSqlIndexingServiceIT.testUserTaskInstanceIndex</a></summary>
JDBC exception executing SQL [delete from definitions pde1_0] [ERROR: update or delete on table "definitions" violates foreign key constraint "fk7jdn9rdvtq3ktsajobr9x1sx1" on table "processes"<br/> Detail: Key (id, version)=(travels, 1.0) is still referenced from table "processes".] [n/a]
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/11/testReport/org.kie.kogito.index.service/InmemoryPostgreSqlIndexingServiceIT/testUserTaskInstancePagination/">org.kie.kogito.index.service.InmemoryPostgreSqlIndexingServiceIT.testUserTaskInstancePagination</a></summary>
Assertion condition defined as a org.kie.kogito.index.service.AbstractIndexingServiceIT 1 expectation failed.<br/>JSON path data.UserTaskInstances.size() doesn't match.<br/>Expected: is <1><br/> Actual: <2><br/> within 30 seconds.
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/11/testReport/org.kie.kogito.index.service/PostgreSqlIndexingServiceIT/testConcurrentProcessInstanceIndex/">org.kie.kogito.index.service.PostgreSqlIndexingServiceIT.testConcurrentProcessInstanceIndex</a></summary>
Assertion condition defined as a org.kie.kogito.index.service.AbstractIndexingServiceIT 1 expectation failed.<br/>JSON path data.ProcessInstances[0].id doesn't match.<br/>Expected: is "7142b9bf-cf47-4d5c-9a77-6c93740dbec9"<br/> Actual: null<br/> within 30 seconds.
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/11/testReport/org.kie.kogito.index.service/PostgreSqlIndexingServiceIT/testProcessInstanceIndex/">org.kie.kogito.index.service.PostgreSqlIndexingServiceIT.testProcessInstanceIndex</a></summary>
Assertion condition defined as a org.kie.kogito.index.service.AbstractIndexingServiceIT 1 expectation failed.<br/>JSON path data.ProcessInstances[0].id doesn't match.<br/>Expected: is "7f01fdd5-35d9-4419-8cf9-77f6f0e2230f"<br/> Actual: null<br/> within 30 seconds.
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/11/testReport/org.kie.kogito.index.service/PostgreSqlIndexingServiceIT/testProcessInstancePagination/">org.kie.kogito.index.service.PostgreSqlIndexingServiceIT.testProcessInstancePagination</a></summary>
Cannot invoke method size() on null object
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/11/testReport/org.kie.kogito.index.service.messaging/PostgreSqlMessagingHttpConsumerIT/testProcessInstanceEvent/">org.kie.kogito.index.service.messaging.PostgreSqlMessagingHttpConsumerIT.testProcessInstanceEvent</a></summary>
Cannot invoke method size() on null object
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/11/testReport/org.kie.kogito.index.service.messaging/PostgreSqlMessagingHttpConsumerIT/testProcessInstanceEventCollection/">org.kie.kogito.index.service.messaging.PostgreSqlMessagingHttpConsumerIT.testProcessInstanceEventCollection</a></summary>
Cannot invoke method size() on null object
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/11/testReport/org.kie.kogito.index.service.messaging/PostgreSqlMessagingKafkaConsumerIT/testProcessInstanceEvent/">org.kie.kogito.index.service.messaging.PostgreSqlMessagingKafkaConsumerIT.testProcessInstanceEvent</a></summary>
Cannot invoke method size() on null object
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/11/testReport/org.kie.kogito.index.service.messaging/PostgreSqlMessagingKafkaConsumerIT/testProcessInstanceEventCollection/">org.kie.kogito.index.service.messaging.PostgreSqlMessagingKafkaConsumerIT.testProcessInstanceEventCollection</a></summary>
Cannot invoke method size() on null object
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/11/testReport/org.kie.kogito.addons.quarkus.data.index.it/MongoQuarkusAddonDataIndexIT/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.MongoQuarkusAddonDataIndexIT.testDataIndexAddon</a></summary>
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors<br/> [error]: Build step io.quarkus.mongodb.deployment.DevServicesMongoProcessor#startMongo threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image docker.io/mongo:7.0<br/> at io.quarkus.mongodb.deployment.DevServicesMongoProcessor.startMongo(DevServicesMongoProcessor.java:122)<br/> at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732)<br/> at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)<br/> at io.quarkus.builder.BuildContext.run(BuildContext.java:256)<br/> at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)<br/> at org.jboss.threads.EnhancedQueueExecutor$Task.doRunWith(EnhancedQueueExecutor.java:2516)<br/> at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2495)<br/> at org.jboss.threads.E
nhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1521)<br/> at java.base/java.lang.Thread.run(Thread.java:840)<br/> at org.jboss.threads.JBossThread.run(JBossThread.java:483)<br/>Caused by: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image docker.io/mongo:7.0<br/> at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:359)<br/> at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:330)<br/> at io.quarkus.mongodb.deployment.DevServicesMongoProcessor.lambda$startMongo$0(DevServicesMongoProcessor.java:191)<br/> at java.base/java.util.Optional.orElseGet(Optional.java:364)<br/> at io.quarkus.mongodb.deployment.DevServicesMongoProcessor.startMongo(DevServicesMongoProcessor.java:208)<br/> at io.quarkus.mongodb.deployment.DevServicesMongoProcessor.startMongo(DevServicesMongoProcessor.java:112)<br/> ... 9 more<br/>Caused by: org.rnorth.ducttape.RetryCountExceededException: Retry limit hit
with exception<br/> at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:88)<br/> at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:344)<br/> ... 14 more<br/>Caused by: org.testcontainers.containers.ContainerLaunchException: Could not create/start container<br/> at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:563)<br/> at org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:354)<br/> at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81)<br/> ... 15 more<br/>Caused by: java.lang.IllegalStateException: Wait strategy failed. Container exited with code 132<br/> at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:533)<br/> ... 17 more<br/>Caused by: org.testcontainers.containers.ContainerLaunchException: Timed out waiting for log output matching '(?i).*waiting for connections.*'<br/> at org.testcontainers
.containers.wait.strategy.LogMessageWaitStrategy.waitUntilReady(LogMessageWaitStrategy.java:47)<br/> at org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:52)<br/> at org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:909)<br/> at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:500)<br/> ... 17 more<br/>
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/11/testReport/org.kie.kogito.addons.quarkus.data.index.it/MongoQuarkusAddonDataIndexIT/PR_check___Build_projects___testDataIndexAddon/">PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.MongoQuarkusAddonDataIndexIT.testDataIndexAddon</a></summary>
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors<br/> [error]: Build step io.quarkus.mongodb.deployment.DevServicesMongoProcessor#startMongo threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image docker.io/mongo:7.0<br/> at io.quarkus.mongodb.deployment.DevServicesMongoProcessor.startMongo(DevServicesMongoProcessor.java:122)<br/> at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732)<br/> at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)<br/> at io.quarkus.builder.BuildContext.run(BuildContext.java:256)<br/> at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)<br/> at org.jboss.threads.EnhancedQueueExecutor$Task.doRunWith(EnhancedQueueExecutor.java:2516)<br/> at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2495)<br/> at org.jboss.threads.E
nhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1521)<br/> at java.base/java.lang.Thread.run(Thread.java:840)<br/> at org.jboss.threads.JBossThread.run(JBossThread.java:483)<br/>Caused by: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image docker.io/mongo:7.0<br/> at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:359)<br/> at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:330)<br/> at io.quarkus.mongodb.deployment.DevServicesMongoProcessor.lambda$startMongo$0(DevServicesMongoProcessor.java:191)<br/> at java.base/java.util.Optional.orElseGet(Optional.java:364)<br/> at io.quarkus.mongodb.deployment.DevServicesMongoProcessor.startMongo(DevServicesMongoProcessor.java:208)<br/> at io.quarkus.mongodb.deployment.DevServicesMongoProcessor.startMongo(DevServicesMongoProcessor.java:112)<br/> ... 9 more<br/>Caused by: org.rnorth.ducttape.RetryCountExceededException: Retry limit hit
with exception<br/> at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:88)<br/> at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:344)<br/> ... 14 more<br/>Caused by: org.testcontainers.containers.ContainerLaunchException: Could not create/start container<br/> at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:563)<br/> at org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:354)<br/> at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81)<br/> ... 15 more<br/>Caused by: java.lang.IllegalStateException: Wait strategy failed. Container exited with code 132<br/> at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:533)<br/> ... 17 more<br/>Caused by: org.testcontainers.containers.ContainerLaunchException: Timed out waiting for log output matching '(?i).*waiting for connections.*'<br/> at org.testcontainers
.containers.wait.strategy.LogMessageWaitStrategy.waitUntilReady(LogMessageWaitStrategy.java:47)<br/> at org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:52)<br/> at org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:909)<br/> at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:500)<br/> ... 17 more<br/>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [Fix #2169] Allow filtering over processInstances.definition and definition.metadata [incubator-kie-kogito-apps]
Posted by "kie-ci3 (via GitHub)" <gi...@apache.org>.
kie-ci3 commented on PR #2191:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2191#issuecomment-2660164461
**PR job** `#18` was: **UNSTABLE**
Possible explanation: This should be test failures
<details>
<summary><b>Reproducer</b></summary>
build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u https://github.com/apache/incubator-kie-kogito-apps/pull/2191 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution
</details>
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/18/display/redirect
**Test results:**
- PASSED: 1820
- FAILED: 1
Those are the test failures:
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2191/18/testReport/org.kie.kogito.index.mongodb/ProcessDataIndexMongoDBKafkaIT/testProcessInstanceEvents/">org.kie.kogito.index.mongodb.ProcessDataIndexMongoDBKafkaIT.testProcessInstanceEvents</a></summary>
1 expectation failed.<br/>JSON path data.UserTaskInstances[0].potentialGroups[0] doesn't match.<br/>Expected: managers<br/> Actual: null<br/>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix #2169 Allow filtering over processInstances.definition and definition.metadata [incubator-kie-kogito-apps]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on code in PR #2191:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2191#discussion_r1954646849
##########
data-index/data-index-storage/data-index-storage-mongodb/src/main/java/org/kie/kogito/index/mongodb/model/ProcessDefinitionEntity.java:
##########
@@ -148,11 +148,11 @@ public void setAnnotations(Set<String> annotations) {
this.annotations = annotations;
}
- public Map<String, String> getMetadata() {
+ public Map<String, Object> getMetadata() {
Review Comment:
I tested it worked by performing a quick test
```
public class MongoDBTest {
public static void main(String[] args) {
String uri = "mongodb://localhost";
try (MongoClient mongoClient = MongoClients.create(uri)) {
MongoDatabase database = mongoClient.getDatabase("sample_mflix");
MongoCollection<Document> collection = database.getCollection("movies");
// Map<String,String> map = Map.of("name","pepe");
// Document insert = new Document();
//insert.put("person", map);
//collection.insertOne(new Document(insert));
Document doc = collection.find(eq("person.name", "pepe")).first();
Map<String,Object> map = (Map<String, Object>) doc.get("person");
if (doc != null) {
System.out.println(map);
} else {
System.out.println("No matching documents found.");
}
}
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [Fix #2169] Allow filtering over processInstances.definition and definition.metadata [incubator-kie-kogito-apps]
Posted by "gmunozfe (via GitHub)" <gi...@apache.org>.
gmunozfe commented on code in PR #2191:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2191#discussion_r1956111600
##########
data-index/data-index-storage/data-index-storage-jpa/src/main/resources/kie-flyway/db/data-index/ansi/V1.45.1.0__metadata_as_column.sql:
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+ALTER TABLE definitions ADD COLUMN metadata varchar(max);
+
+/* Migration for postgresql and sql server
+ UPDATE definitions SET metadata =
+(SELECT string_agg(name || '=' || meta_value, ',') FROM definitions_metadata where process_id = a.process_id and process_version = a.process_version)
+FROM definitions_metadata as a
+WHERE process_id = a.process_id and process_version = a.process_version;
+*/
+
+
+/* Migration for h2 and oracle
+ UPDATE definitions SET metadata =
+(SELECT listagg(name || '=' || meta_value, ',') FROM definitions_metadata where process_id = a.process_id and process_version = a.process_version)
+FROM definitions_metadata as a
+WHERE process_id = a.process_id and process_version = a.process_version;
+*/
+
+/* Since migration is disable, do not delete not longer used table
+ * DROP TABLE definitions_metadata;*/
Review Comment:
should we keep commented code?
##########
data-index/data-index-storage/data-index-storage-postgresql/src/main/java/org/kie/kogito/index/postgresql/PostgresqlJsonHelper.java:
##########
@@ -101,11 +105,26 @@ private static Expression buildObjectExpression(CriteriaBuilder builder, Object
private static Expression buildPathExpression(CriteriaBuilder builder, Root<?> root, String attributeName, boolean isStr) {
String[] attributes = attributeName.split("\\.");
- Expression<?>[] arguments = new Expression[attributes.length];
- arguments[0] = root.get(attributes[0]);
- for (int i = 1; i < attributes.length; i++) {
- arguments[i] = builder.literal(attributes[i]);
+
+ Collection<Expression> arguments = new ArrayList<>();
+ if (attributes.length == 1)
+ return root.get(attributeName);
+ int startIndex;
+ // Check if the first attribute is a join, if it is, assume next attribute is the json property (not sure thats necessarily correct but it will work)
+ try {
+ Join join = root.join(attributes[0]);
Review Comment:
this a hack but will it work in some cases, for ex. when the first attribute is "joinable" but then (second attribute) there's something that doesn't admit to be joined (like a nested structure). Probably it's something out of the scope of this feature, but anticipating it for edge cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org