You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "lhsribas (via GitHub)" <gi...@apache.org> on 2023/05/02 15:42:19 UTC
[GitHub] [camel] lhsribas opened a new pull request, #9978: removing unused parameters from method signature for camel core
lhsribas opened a new pull request, #9978:
URL: https://github.com/apache/camel/pull/9978
# Description
- I have worked for removing unused parameters from method signature for camel core
# Tracking
- [ ] removing unused parameters from method signature for camel core (https://sonarcloud.io/project/issues?resolved=false&rules=java%3AS1172&id=apache_camel)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9978: removing unused parameters from method signature for camel core
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9978:
URL: https://github.com/apache/camel/pull/9978#issuecomment-1531699845
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:warning: Please note that the changes on this PR may be **tested automatically**.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on a diff in pull request #9978: removing unused parameters from method signature for camel core
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on code in PR #9978:
URL: https://github.com/apache/camel/pull/9978#discussion_r1182732854
##########
core/camel-support/src/main/java/org/apache/camel/support/DefaultContextReloadStrategy.java:
##########
@@ -64,11 +64,11 @@ public void onReload(Object source) {
}
}
- protected void reloadRoutes(Object source) throws Exception {
+ protected void reloadRoutes() throws Exception {
Review Comment:
I am not entirely sure we want to change the signature of `protected` methods.
I am wondering if wouldn't be better to document these methods if they are supposed to be extended by others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] lhsribas closed pull request #9978: removing unused parameters from method signature for camel core
Posted by "lhsribas (via GitHub)" <gi...@apache.org>.
lhsribas closed pull request #9978: removing unused parameters from method signature for camel core
URL: https://github.com/apache/camel/pull/9978
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org