You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "jihun4452 (via GitHub)" <gi...@apache.org> on 2025/08/15 15:10:12 UTC
[PR] [Improve][Doc] Update sql function result type (apache#9703) [seatunnel]
jihun4452 opened a new pull request, #9711:
URL: https://github.com/apache/seatunnel/pull/9711
### Purpose of this pull request
Add explicit **return type** information for each SQL function in the docs and unify the return type notation.
- Add a one-line “This method returns …” for every function with the type in UPPERCASE (e.g., **STRING**, **DOUBLE**, **BOOLEAN**, **TIMESTAMP WITH TIME ZONE**, etc.).
- Keep the wording consistent across sections (String / Numeric / Time & Date / System).
- Minor formatting fixes for examples (fenced code blocks) and small clarifications where a function’s return depends on input type (e.g., `FLOOR`, `ROUND`, `DATEADD`).
Reference: PostgreSQL function docs style for consistency: https://www.postgresql.org/docs/current/functions-math.html
Closes #9703.
---
### Does this PR introduce _any_ user-facing change?
Yes. Documentation only.
Previously, many SQL functions didn’t explicitly state their return types. Now each function clearly documents the return type, improving readability and reducing ambiguity. No runtime behavior change.
---
### How was this patch tested?
- Manually previewed the updated Markdown to ensure headings, code fences, and bolded return types render correctly.
- Checked for consistent casing of types across the file.
(Documentation change only; no code/tests affected.)
---
### Check list
* [x] Documentation updated: `docs/transform-v2/sql-functions.md`
* [x] No new binaries added
* [x] Not a connector change (no plugin mapping / dist / e2e updates required)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improve][Doc] Update sql function result type (apache#9703) [seatunnel]
Posted by "jihun4452 (via GitHub)" <gi...@apache.org>.
jihun4452 commented on PR #9711:
URL: https://github.com/apache/seatunnel/pull/9711#issuecomment-3191737071
Feedback is welcome. Thanks in advance for reviewing this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improve][Doc] Update sql function result type (apache#9703) [seatunnel]
Posted by "corgy-w (via GitHub)" <gi...@apache.org>.
corgy-w merged PR #9711:
URL: https://github.com/apache/seatunnel/pull/9711
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improve][Doc] Update sql function result type (apache#9703) [seatunnel]
Posted by "jihun4452 (via GitHub)" <gi...@apache.org>.
jihun4452 commented on PR #9711:
URL: https://github.com/apache/seatunnel/pull/9711#issuecomment-3193721456
I wasn’t aware of that. Thanks a lot for pointing it out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improve][Doc] Update sql function result type (apache#9703) [seatunnel]
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #9711:
URL: https://github.com/apache/seatunnel/pull/9711#discussion_r2283928611
##########
docs/en/transform-v2/sql-functions.md:
##########
@@ -8,352 +8,355 @@
```ASCII(string)```
-Returns the ```ASCII``` value of the first character in the string. This method returns an int.
+Returns the `ASCII` value of the first character in the string. This method returns an **INT**.
Review Comment:
```suggestion
Returns the `ASCII` value of the first character in the string.
```
##########
docs/en/transform-v2/sql-functions.md:
##########
@@ -8,352 +8,355 @@
```ASCII(string)```
Review Comment:
```suggestion
```ASCII(string) -> INT```
```
I perfer this style. It's more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improve][Doc] Update sql function result type (apache#9703) [seatunnel]
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #9711:
URL: https://github.com/apache/seatunnel/pull/9711#discussion_r2287432371
##########
docs/en/transform-v2/sql-functions.md:
##########
@@ -306,27 +306,27 @@ select SPLIT(test,';') as arrays
### SOUNDEX
-```SOUNDEX(string)```
+```SOUNDEX(string) -> STRING```
-Returns a four character code representing the sound of a string. This method returns a string, or null if parameter is null. See https://en.wikipedia.org/wiki/Soundex for more information.
Review Comment:
we should keep `or null if parameter is null. See https://en.wikipedia.org/wiki/Soundex for more information`
##########
docs/en/transform-v2/sql-functions.md:
##########
@@ -228,12 +226,12 @@ Flags values are limited to 'i', 'c', 'n', 'm'. Other symbols cause exception. M
Example:
-REGEXP_REPLACE('Hello World', ' +', ' ')
Review Comment:
This change should be revert. The demo it's intentional.
##########
docs/en/transform-v2/sql-functions.md:
##########
@@ -693,27 +693,27 @@ CURRENT_TIMESTAMP
### DATEADD / TIMESTAMPADD
-```DATEADD| TIMESTAMPADD(dateAndTime, addIntLong, datetimeFieldString)```
+```DATEADD| TIMESTAMPADD(dateAndTime, addIntLong, datetimeFieldString) -> dateAndTime (same type)```
-Adds units to a date-time value. The datetimeFieldString indicates the unit. Use negative values to subtract units. addIntLong may be a long value when manipulating milliseconds, microseconds, or nanoseconds otherwise its range is restricted to int. This method returns a value with the same type as specified value if unit is compatible with this value. If specified field is a HOUR, MINUTE, SECOND, MILLISECOND, etc and value is a DATE value DATEADD returns combined TIMESTAMP. Fields DAY, MONTH, YEAR, WEEK, etc are not allowed for TIME values.
Review Comment:
ditto
##########
docs/en/transform-v2/sql-functions.md:
##########
@@ -249,11 +247,11 @@ Flags values are limited to 'i', 'c', 'n', 'm'. Other symbols cause exception. M
Example:
-REGEXP_LIKE('Hello World', '[A-Z ]*', 'i')
Review Comment:
ditto
##########
docs/en/transform-v2/sql-functions.md:
##########
@@ -559,77 +559,77 @@ LOG(2, A)
### LOG10
-```LOG10(numeric)```
+```LOG10(numeric) -> DOUBLE```
-Calculates the base 10 logarithm as a double value. Argument must be a positive numeric value.
+Calculates the base 10 logarithm. Argument must be a positive numeric value.
Example:
LOG10(A)
### RADIANS
-```RADIANS(numeric)```
+```RADIANS(numeric) -> DOUBLE```
-See also Java Math.toRadians. This method returns a double.
+See also Java Math.toRadians.
Example:
RADIANS(A)
### SQRT
-```SQRT(numeric)```
+```SQRT(numeric) -> DOUBLE```
-See also Java Math.sqrt. This method returns a double.
+See also Java Math.sqrt.
Example:
SQRT(A)
### PI
-```PI()```
+```PI() -> DOUBLE```
-See also Java Math.PI. This method returns a double.
+See also Java Math.PI.
Example:
PI()
### POWER
-```POWER(numeric, numeric)```
+```POWER(numeric, numeric) -> DOUBLE```
-See also Java Math.pow. This method returns a double.
+See also Java Math.pow.
Example:
POWER(A, B)
### RAND / RANDOM
-```RAND | RANDOM([ int ])```
+```RAND | RANDOM([ int ]) -> DOUBLE```
-Calling the function without parameter returns the next a pseudo random number. Calling it with an parameter seeds the session's random number generator. This method returns a double between 0 (including) and 1 (excluding).
Review Comment:
ditto.
##########
docs/en/transform-v2/sql-functions.md:
##########
@@ -559,77 +559,77 @@ LOG(2, A)
### LOG10
-```LOG10(numeric)```
+```LOG10(numeric) -> DOUBLE```
-Calculates the base 10 logarithm as a double value. Argument must be a positive numeric value.
+Calculates the base 10 logarithm. Argument must be a positive numeric value.
Example:
LOG10(A)
### RADIANS
-```RADIANS(numeric)```
+```RADIANS(numeric) -> DOUBLE```
-See also Java Math.toRadians. This method returns a double.
+See also Java Math.toRadians.
Example:
RADIANS(A)
### SQRT
-```SQRT(numeric)```
+```SQRT(numeric) -> DOUBLE```
-See also Java Math.sqrt. This method returns a double.
+See also Java Math.sqrt.
Example:
SQRT(A)
### PI
-```PI()```
+```PI() -> DOUBLE```
-See also Java Math.PI. This method returns a double.
+See also Java Math.PI.
Example:
PI()
### POWER
-```POWER(numeric, numeric)```
+```POWER(numeric, numeric) -> DOUBLE```
-See also Java Math.pow. This method returns a double.
+See also Java Math.pow.
Example:
POWER(A, B)
### RAND / RANDOM
-```RAND | RANDOM([ int ])```
+```RAND | RANDOM([ int ]) -> DOUBLE```
-Calling the function without parameter returns the next a pseudo random number. Calling it with an parameter seeds the session's random number generator. This method returns a double between 0 (including) and 1 (excluding).
+Calling the function without parameter returns the next a pseudo random number. Calling it with an parameter seeds the session's random number generator.
Example:
RAND()
### ROUND
-```ROUND(numeric[, digitsInt])```
+```ROUND(numeric[, digitsInt]) -> numeric (same type)```
-Rounds to a number of fractional digits. This method returns value of the same type as argument, but with adjusted precision and scale, if applicable.
Review Comment:
ditto
##########
docs/en/transform-v2/sql-functions.md:
##########
@@ -639,19 +639,19 @@ SIGN(N)
### TRUNC
-```TRUNC | TRUNCATE(numeric[, digitsInt])```
+```TRUNC | TRUNCATE(numeric[, digitsInt]) -> numeric (same type)```
-When a numeric argument is specified, truncates it to a number of digits (to the next value closer to 0) and returns value of the same type as argument, but with adjusted precision and scale, if applicable.
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improve][Doc] Update sql function result type (apache#9703) [seatunnel]
Posted by "jihun4452 (via GitHub)" <gi...@apache.org>.
jihun4452 commented on PR #9711:
URL: https://github.com/apache/seatunnel/pull/9711#issuecomment-3199971173
I have checked and updated the missing descriptions and return type information in both the English and Chinese SQL function docs. Please take another look when you have a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improve][Doc] Update sql function result type (apache#9703) [seatunnel]
Posted by "jihun4452 (via GitHub)" <gi...@apache.org>.
jihun4452 commented on PR #9711:
URL: https://github.com/apache/seatunnel/pull/9711#issuecomment-3199291226
Thanks for the feedback. I have refined both en and zh docs accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improve][Doc] Update sql function result type (apache#9703) [seatunnel]
Posted by "jihun4452 (via GitHub)" <gi...@apache.org>.
jihun4452 commented on PR #9711:
URL: https://github.com/apache/seatunnel/pull/9711#issuecomment-3211195802
Applied both suggestions: reverted EXPLODE(ARRAY(...)) spacing and changed DATEADD/TIMESTAMPADD to -> type(dateAndTime). EN/ZH are aligned. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improve][Doc] Update sql function result type (apache#9703) [seatunnel]
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #9711:
URL: https://github.com/apache/seatunnel/pull/9711#discussion_r2284988887
##########
docs/en/transform-v2/sql-functions.md:
##########
@@ -6,1039 +6,878 @@
### ASCII
-```ASCII(string)```
+ ```ASCII(string) -> INT```
-Returns the ```ASCII``` value of the first character in the string. This method returns an int.
+ Returns the `ASCII` value of the first character in the string.
Example:
-
ASCII('Hi')
### BIT_LENGTH
-```BIT_LENGTH(bytes)```
+ ```BIT_LENGTH(bytes) -> LONG```
-Returns the number of bits in a binary string. This method returns a long.
+ Returns the number of bits in a binary string.
Example:
-
BIT_LENGTH(NAME)
### CHAR_LENGTH / LENGTH
-```CHAR_LENGTH | LENGTH (string)```
+ ```CHAR_LENGTH | LENGTH (string) -> LONG```
-Returns the number of characters in a character string. This method returns a long.
+ Returns the number of characters in a character string.
Example:
-
CHAR_LENGTH(NAME)
### OCTET_LENGTH
-```OCTET_LENGTH(bytes)```
+ ```OCTET_LENGTH(bytes) -> LONG```
-Returns the number of bytes in a binary string. This method returns a long.
+ Returns the number of bytes in a binary string.
Example:
-
OCTET_LENGTH(NAME)
### CHAR / CHR
-```CHAR | CHR (int)```
+ ```CHAR | CHR (int) -> STRING```
-Returns the character that represents the ASCII value. This method returns a string.
+ Returns the character that represents the ASCII value.
Example:
-
CHAR(65)
### CONCAT
-```CONCAT(string, string[, string ...] )```
+ ```CONCAT(string, string[, string ...]) -> STRING```
-Combines strings. Unlike with the operator ```||```, **NULL** parameters are ignored, and do not cause the result to become **NULL**. If all parameters are NULL the result is an empty string. This method returns a string.
Review Comment:
@jihun4452
##########
docs/en/transform-v2/sql-functions.md:
##########
@@ -6,1039 +6,878 @@
### ASCII
-```ASCII(string)```
+ ```ASCII(string) -> INT```
-Returns the ```ASCII``` value of the first character in the string. This method returns an int.
+ Returns the `ASCII` value of the first character in the string.
Example:
-
ASCII('Hi')
### BIT_LENGTH
-```BIT_LENGTH(bytes)```
+ ```BIT_LENGTH(bytes) -> LONG```
-Returns the number of bits in a binary string. This method returns a long.
+ Returns the number of bits in a binary string.
Example:
-
BIT_LENGTH(NAME)
### CHAR_LENGTH / LENGTH
-```CHAR_LENGTH | LENGTH (string)```
+ ```CHAR_LENGTH | LENGTH (string) -> LONG```
-Returns the number of characters in a character string. This method returns a long.
+ Returns the number of characters in a character string.
Example:
-
CHAR_LENGTH(NAME)
### OCTET_LENGTH
-```OCTET_LENGTH(bytes)```
+ ```OCTET_LENGTH(bytes) -> LONG```
-Returns the number of bytes in a binary string. This method returns a long.
+ Returns the number of bytes in a binary string.
Example:
-
OCTET_LENGTH(NAME)
### CHAR / CHR
-```CHAR | CHR (int)```
+ ```CHAR | CHR (int) -> STRING```
-Returns the character that represents the ASCII value. This method returns a string.
+ Returns the character that represents the ASCII value.
Example:
-
CHAR(65)
### CONCAT
-```CONCAT(string, string[, string ...] )```
+ ```CONCAT(string, string[, string ...]) -> STRING```
-Combines strings. Unlike with the operator ```||```, **NULL** parameters are ignored, and do not cause the result to become **NULL**. If all parameters are NULL the result is an empty string. This method returns a string.
+ Combines strings. Unlike with the operator `||`, **NULL** parameters are ignored and do not cause the result to become **NULL**.
Example:
-
CONCAT(NAME, '_')
### CONCAT_WS
-```CONCAT_WS(separatorString, string, string[, string ...] )```
+ ```CONCAT_WS(separatorString, string, string[, string ...]) -> STRING```
-Combines strings with separator. If separator is **NULL** it is treated like an empty string. Other **NULL** parameters are ignored. Remaining **non-NULL** parameters, if any, are concatenated with the specified separator. If there are no remaining parameters the result is an empty string. This method returns a string.
Review Comment:
@jihun4452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improve][Doc] Update sql function result type (apache#9703) [seatunnel]
Posted by "dybyte (via GitHub)" <gi...@apache.org>.
dybyte commented on PR #9711:
URL: https://github.com/apache/seatunnel/pull/9711#issuecomment-3193670205
Hi, thanks for the contribution!
For smooth review and merge, you may also need to enable the CI.
https://github.com/apache/seatunnel/pull/9711/checks?check_run_id=48218146223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improve][Doc] Update sql function result type (apache#9703) [seatunnel]
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #9711:
URL: https://github.com/apache/seatunnel/pull/9711#discussion_r2284397497
##########
docs/en/transform-v2/sql-functions.md:
##########
@@ -6,1133 +6,917 @@
### ASCII
-```ASCII(string)```
+ ```ASCII(string) -> INT```
-Returns the ```ASCII``` value of the first character in the string. This method returns an int.
+ Returns the `ASCII` value of the first character in the string.
Example:
-
ASCII('Hi')
### BIT_LENGTH
-```BIT_LENGTH(bytes)```
+ ```BIT_LENGTH(bytes) -> LONG```
-Returns the number of bits in a binary string. This method returns a long.
+ Returns the number of bits in a binary string.
Example:
-
BIT_LENGTH(NAME)
### CHAR_LENGTH / LENGTH
-```CHAR_LENGTH | LENGTH (string)```
+ ```CHAR_LENGTH | LENGTH (string) -> LONG```
-Returns the number of characters in a character string. This method returns a long.
+ Returns the number of characters in a character string.
Example:
-
CHAR_LENGTH(NAME)
### OCTET_LENGTH
-```OCTET_LENGTH(bytes)```
+ ```OCTET_LENGTH(bytes) -> LONG```
-Returns the number of bytes in a binary string. This method returns a long.
+ Returns the number of bytes in a binary string.
Example:
-
OCTET_LENGTH(NAME)
### CHAR / CHR
-```CHAR | CHR (int)```
+ ```CHAR | CHR (int) -> STRING```
-Returns the character that represents the ASCII value. This method returns a string.
+ Returns the character that represents the ASCII value.
Example:
-
CHAR(65)
### CONCAT
-```CONCAT(string, string[, string ...] )```
+ ```CONCAT(string, string[, string ...]) -> STRING```
-Combines strings. Unlike with the operator ```||```, **NULL** parameters are ignored, and do not cause the result to become **NULL**. If all parameters are NULL the result is an empty string. This method returns a string.
+ Combines strings. Unlike with the operator `||`, **NULL** parameters are ignored and do not cause the result to become **NULL**.
Example:
-
CONCAT(NAME, '_')
### CONCAT_WS
-```CONCAT_WS(separatorString, string, string[, string ...] )```
-
-Combines strings with separator. If separator is **NULL** it is treated like an empty string. Other **NULL** parameters are ignored. Remaining **non-NULL** parameters, if any, are concatenated with the specified separator. If there are no remaining parameters the result is an empty string. This method returns a string.
+ ```CONCAT_WS(separatorString, string, string[, string ...]) -> STRING```
Example:
-
CONCAT_WS(',', NAME, '_')
### HEXTORAW
-```HEXTORAW(string)```
+ ```HEXTORAW(string) -> STRING```
-Converts a hex representation of a string to a string. 4 hex characters per string character are used.
+ Converts a hex representation of a string to a string. 4 hex characters per string character are used.
Example:
-
HEXTORAW(DATA)
### RAWTOHEX
-```RAWTOHEX(string)```
+ ```RAWTOHEX(string | bytes) -> STRING```
-```RAWTOHEX(bytes)```
-
-Converts a string or bytes to the hex representation. 4 hex characters per string character are used. This method returns a string.
+ Converts a string or bytes to the hex representation. 4 hex characters per string character are used.
Example:
-
RAWTOHEX(DATA)
### INSERT
-```INSERT(originalString, startInt, lengthInt, addString)```
-
-Inserts a additional string into the original string at a specified start position. The length specifies the number of characters that are removed at the start position in the original string. This method returns a string.
Review Comment:
Some description be removed. Please check again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improve][Doc] Update sql function result type (apache#9703) [seatunnel]
Posted by "jihun4452 (via GitHub)" <gi...@apache.org>.
jihun4452 commented on PR #9711:
URL: https://github.com/apache/seatunnel/pull/9711#issuecomment-3208648703
Thank you for the feedback! I’ll address the issues carefully and resubmit the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improve][Doc] Update sql function result type (apache#9703) [seatunnel]
Posted by "jihun4452 (via GitHub)" <gi...@apache.org>.
jihun4452 commented on PR #9711:
URL: https://github.com/apache/seatunnel/pull/9711#issuecomment-3193387723
This PR updates the English documentation only.
I’m not fluent in Chinese, so I believe it would be clearer and safer if the zh-CN docs are updated in a separate follow-up PR by someone familiar with the language.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improve][Doc] Update sql function result type (apache#9703) [seatunnel]
Posted by "jihun4452 (via GitHub)" <gi...@apache.org>.
jihun4452 commented on PR #9711:
URL: https://github.com/apache/seatunnel/pull/9711#issuecomment-3201115813
Thanks for the review
I restored the original function descriptions and removed redundant return type notes.
Please let me know if there are any further adjustments or feedback needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improve][Doc] Update sql function result type (apache#9703) [seatunnel]
Posted by "jihun4452 (via GitHub)" <gi...@apache.org>.
jihun4452 commented on PR #9711:
URL: https://github.com/apache/seatunnel/pull/9711#issuecomment-3193680602
I created an empty commit (chore: trigger CI) to re-run the CI pipeline on my fork, since there were no code changes but the workflow needed to be triggered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improve][Doc] Update sql function result type (apache#9703) [seatunnel]
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #9711:
URL: https://github.com/apache/seatunnel/pull/9711#discussion_r2290441039
##########
docs/en/transform-v2/sql-functions.md:
##########
@@ -693,7 +693,7 @@ CURRENT_TIMESTAMP
### DATEADD / TIMESTAMPADD
-```DATEADD| TIMESTAMPADD(dateAndTime, addIntLong, datetimeFieldString)```
+```DATEADD | TIMESTAMPADD(dateAndTime, addIntLong, datetimeFieldString) -> dateAndTime (same type)```
Review Comment:
```suggestion
```DATEADD | TIMESTAMPADD(dateAndTime, addIntLong, datetimeFieldString) -> type(dateAndTime)```
```
##########
docs/en/transform-v2/sql-functions.md:
##########
@@ -1134,7 +1135,7 @@ OUTER EXPLODE: Returns NULL when array is NULL or empty, ensuring at least one r
EXPLODE(SPLIT(field_name, separator)): Splits a string into an array using the specified separator, then explodes it into rows.
-EXPLODE(ARRAY(value1, value2, ...)): Explodes a custom-defined array into multiple rows.
Review Comment:
this should be revert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org