You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/02/04 10:34:34 UTC
[GitHub] [cloudstack] ravening opened a new pull request #3863: Start all
(instead of Disconnected) Site-to-Site VPN connections when VPC VR starts
ravening opened a new pull request #3863: Start all (instead of Disconnected) Site-to-Site VPN connections when VPC VR starts
URL: https://github.com/apache/cloudstack/pull/3863
## Description
<!--- Describe your changes in detail -->
When we restart the VPC after destroying the master VR, the backup VR
becomes the master and the site to site connections are not in
the connected state. The passive VPN connection will be in the connected
state but the active VPN connection will be in a disconnected state
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
Steps to reproduce the issue
1 . Create two VPC's. Configure VPN customer gateway and VPN connection. The steps are clearly explained in [here](https://docs.cloudstack.apache.org/projects/cloudstack-administration/en/4.8/networking/site_to_site_vpn.html#site-to-site-vpn-connection-between-vpc-networks)
2 . Once everything is setup properly make sure that the VPN state is "Connected" in both VPC.
3 . Now navigate to "Infrastructure" → "Virtual Routers"
4 . Search for the routers which belong to one of the VPC created above
5 . Now stop the Backup router and eventually destroy it. It is important that you stop/destroy the Backup router and not the Master router
6 . Now navigate to "Networks" → Select "VPC" in the select view drop down menu and select the VPC for which the virtual router has been destroyed.
7 . Now restart the VPC without cleanup. This will create a new backup VR.
8 . Once the backup vr is created, stop/destroy the master router. The steps are similar to destroying the backup router
9 . Again navigate to Networks → vpc and restart the VPC without cleanup. The initial backup router will become the master and a new backup router will be created
10 . Now check the status of the VPN connection
Expected result:
Both the active and passive VPN connections should be in "Connected" state.
Actual result:
Passive VPN was in Connected state and the active VPN was in Disconnected state
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd closed pull request #3863: Start all (instead of
Disconnected) Site-to-Site VPN connections when VPC VR starts
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #3863: Start all (instead of Disconnected) Site-to-Site VPN connections when VPC VR starts
URL: https://github.com/apache/cloudstack/pull/3863
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3863: Start all
(instead of Disconnected) Site-to-Site VPN connections when VPC VR starts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3863: Start all (instead of Disconnected) Site-to-Site VPN connections when VPC VR starts
URL: https://github.com/apache/cloudstack/pull/3863#issuecomment-581941007
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd merged pull request #3863: Start all (instead of
Disconnected) Site-to-Site VPN connections when VPC VR starts
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #3863: Start all (instead of Disconnected) Site-to-Site VPN connections when VPC VR starts
URL: https://github.com/apache/cloudstack/pull/3863
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3863: Start all (instead of
Disconnected) Site-to-Site VPN connections when VPC VR starts
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3863: Start all (instead of Disconnected) Site-to-Site VPN connections when VPC VR starts
URL: https://github.com/apache/cloudstack/pull/3863#issuecomment-581892611
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3863: Start all
(instead of Disconnected) Site-to-Site VPN connections when VPC VR starts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3863: Start all (instead of Disconnected) Site-to-Site VPN connections when VPC VR starts
URL: https://github.com/apache/cloudstack/pull/3863#issuecomment-581913987
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-744
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] ravening opened a new pull request #3863: Start all
(instead of Disconnected) Site-to-Site VPN connections when VPC VR starts
Posted by GitBox <gi...@apache.org>.
ravening opened a new pull request #3863: Start all (instead of Disconnected) Site-to-Site VPN connections when VPC VR starts
URL: https://github.com/apache/cloudstack/pull/3863
## Description
<!--- Describe your changes in detail -->
When we restart the VPC after destroying the master VR, the backup VR
becomes the master and the site to site connections are not in
the connected state. The passive VPN connection will be in the connected
state but the active VPN connection will be in a disconnected state
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
Steps to reproduce the issue
1 . Create two VPC's. Configure VPN customer gateway and VPN connection. The steps are clearly explained in [here](https://docs.cloudstack.apache.org/projects/cloudstack-administration/en/4.8/networking/site_to_site_vpn.html#site-to-site-vpn-connection-between-vpc-networks)
2 . Once everything is setup properly make sure that the VPN state is "Connected" in both VPC.
3 . Now navigate to "Infrastructure" → "Virtual Routers"
4 . Search for the routers which belong to one of the VPC created above
5 . Now stop the Backup router and eventually destroy it. It is important that you stop/destroy the Backup router and not the Master router
6 . Now navigate to "Networks" → Select "VPC" in the select view drop down menu and select the VPC for which the virtual router has been destroyed.
7 . Now restart the VPC without cleanup. This will create a new backup VR.
8 . Once the backup vr is created, stop/destroy the master router. The steps are similar to destroying the backup router
9 . Again navigate to Networks → vpc and restart the VPC without cleanup. The initial backup router will become the master and a new backup router will be created
10 . Now check the status of the VPN connection
Expected result:
Both the active and passive VPN connections should be in "Connected" state.
Actual result:
Passive VPN was in Connected state and the active VPN was in Disconnected state
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3863: Start all
(instead of Disconnected) Site-to-Site VPN connections when VPC VR starts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3863: Start all (instead of Disconnected) Site-to-Site VPN connections when VPC VR starts
URL: https://github.com/apache/cloudstack/pull/3863#issuecomment-582207120
<b>Trillian test result (tid-888)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39403 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3863-t888-kvm-centos7.zip
Smoke tests completed. 79 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3863: Start all
(instead of Disconnected) Site-to-Site VPN connections when VPC VR starts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3863: Start all (instead of Disconnected) Site-to-Site VPN connections when VPC VR starts
URL: https://github.com/apache/cloudstack/pull/3863#issuecomment-581892763
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3863: Start all (instead of
Disconnected) Site-to-Site VPN connections when VPC VR starts
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3863: Start all (instead of Disconnected) Site-to-Site VPN connections when VPC VR starts
URL: https://github.com/apache/cloudstack/pull/3863#issuecomment-581940493
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services