You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/07/21 15:19:21 UTC
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7347: Fix the persistent session timeout mechanism bug.
wu-sheng commented on a change in pull request #7347:
URL: https://github.com/apache/skywalking/pull/7347#discussion_r674071469
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsPersistentWorker.java
##########
@@ -275,7 +275,8 @@ private void loadFromStorage(List<Metrics> metrics) {
// Mostly all updatable metadata level metrics are required to do this check.
if (metricsDAO.isExpiredCache(model, cachedValue, currentTimeMillis, metricsDataTTL)) {
- // The expired metrics should be tagged `not in cache` directly.
+ // The expired metrics should be removed from the context and tagged `not in cache` directly.
+ context.remove(m);
Review comment:
Why really need to remove? `return true` would make this in the `notInCacheMetrics`. Then `multiGet` should load and override it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org