You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pdfbox.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/03/20 15:43:00 UTC

[jira] [Commented] (PDFBOX-5136) Remove COSDocument#finalize

    [ https://issues.apache.org/jira/browse/PDFBOX-5136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17305485#comment-17305485 ] 

ASF subversion and git services commented on PDFBOX-5136:
---------------------------------------------------------

Commit 1887866 from lehmi@apache.org in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1887866 ]

PDFBOX-5136: don't override finalize anymore, remove now unused method setWarnMissingClose

> Remove COSDocument#finalize
> ---------------------------
>
>                 Key: PDFBOX-5136
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-5136
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: Parsing, PDModel
>    Affects Versions: 3.0.0 PDFBox
>            Reporter: Andreas Lehmkühler
>            Assignee: Andreas Lehmkühler
>            Priority: Major
>             Fix For: 3.0.0 PDFBox
>
>
> PDDocument implements the Closeable interface a closes the underlying instance of COSDocument once it is closed itself, so that there is no need to use the finalize method to perform a sanity check about not closed resources. Furthermore it is a bad idea to overwrite finalize for different good reasons.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org