You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cayenne.apache.org by "Thomas Bernhard (JIRA)" <de...@cayenne.apache.org> on 2007/10/31 18:24:50 UTC
[JIRA] Created: (CAY-911) CM Usability: JComboBox Autocompletion
CM Usability: JComboBox Autocompletion
--------------------------------------
Key: CAY-911
URL: https://issues.apache.org/cayenne/browse/CAY-911
Project: Cayenne
Issue Type: New Feature
Components: CayenneModeler GUI
Reporter: Thomas Bernhard
Assignee: Andrus Adamchik
Please use JComBox with autocompletion in CM at least in places that are very repetitive like selecting Field Types.
It is very simple to implement it and there are several extremly well documented examples how to do it. E.g.:
http://www.orbital-computer.de/JComboBox/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (CAY-911) CM Usability: JComboBox Autocompletion
Posted by Kevin Menard <km...@servprise.com>.
On May 23, 2008, at 1:51 AM, Andrey Razumovsky wrote:
> Well, 'the second' patch, which was originally the first was my
> first one
> and it is really bad-maken. Sorry for that, and it must be deleted.
You're right. Despite trying to make sure I grabbed the correct
patch, I seemed to have grabbed the wrong one anyway.
> Not exactly. You may see that 'byte' is quite far away from
> 'byte[]'. So if
> i want to select 'byte[]', and i type 'byte', 'byte[]' cannot be seen
> anywhere around. The problem is that auto-completion is now
> implemented as
> automatical search in combobox for a matching item and selecting it.
> Probably better solution would be to include in drop-down list only
> matching
> items - then 'byte' and 'byte[]' would be near each other no matter
> how
> close they were in original combo.
I can't fire up the modeler right now, but what you're saying makes
sense. I do think we want to narrow down the choices if we can,
rather than doing a reindex in the list. This also would address that
issue of ensuring only proper input. Just show an empty list if there
is no match.
> I also found the combo box editor deletion logic a bit odd. It didn't
>> actually delete what I typed, but rather changed the highlighted
>> area. It
>> was quite confusing. Any chance we can make the backspace key
>> actually
>> delete the selected text?
>
>
> Of course we can. The reason here is that that combobox doesn't allow
> anything that its predefined items. So selected item is always one of
> model's choices. Alternatively, we could set the item here only on
> 'enter'
> and cancel on focus lost (or set also on focus lost).
Yeah, I got how it worked after the confusion. But, when revising a
search, it's odd to be typing in an overwrite mode.
>
> Finally, CayenneWidgetFactory uses magic numbers for the maximum row
>> count. Please use a static field for such values.
>
>
> Understood. I'll do that in the next patch.
Great. Don't bother for things like window sizes. But others that
seem like configuration items we should. Take a look at the existing
code for inspiration. E.g., the part about determining how many
projects to show in the recent projects section.
>
>
> So how must a new patch be made? It should contain full auto-
> completion code
> or be 'a patch to previous patch'? And please let me know whether
> you agree
> or not with suggestions above.
Either approach would work for me. If you could do a full one, that
would be preferred since I haven't committed anything yet. Otherwise,
I'll just do it in two phases. Please note that I can't commit
anything until we get clarification on the licensing issue.
Re: [jira] Commented: (CAY-911) CM Usability: JComboBox Autocompletion
Posted by Andrey Razumovsky <ra...@gmail.com>.
Well, 'the second' patch, which was originally the first was my first one
and it is really bad-maken. Sorry for that, and it must be deleted.
I do think we want to handle auto-completion for ObjAttributes. In my
> experience, that's the combo box I'm most likely to start typing entries
> into. Also, I've just checked out CM and it looks to me like the
> ObjAttribute choices are sorted alphabetically. Since this is provided as a
> reason for not using auto-completion, please let me know if I'm mistaken.
Not exactly. You may see that 'byte' is quite far away from 'byte[]'. So if
i want to select 'byte[]', and i type 'byte', 'byte[]' cannot be seen
anywhere around. The problem is that auto-completion is now implemented as
automatical search in combobox for a matching item and selecting it.
Probably better solution would be to include in drop-down list only matching
items - then 'byte' and 'byte[]' would be near each other no matter how
close they were in original combo.
I also found the combo box editor deletion logic a bit odd. It didn't
> actually delete what I typed, but rather changed the highlighted area. It
> was quite confusing. Any chance we can make the backspace key actually
> delete the selected text?
Of course we can. The reason here is that that combobox doesn't allow
anything that its predefined items. So selected item is always one of
model's choices. Alternatively, we could set the item here only on 'enter'
and cancel on focus lost (or set also on focus lost).
Finally, CayenneWidgetFactory uses magic numbers for the maximum row
> count. Please use a static field for such values.
Understood. I'll do that in the next patch.
So how must a new patch be made? It should contain full auto-completion code
or be 'a patch to previous patch'? And please let me know whether you agree
or not with suggestions above.
[jira] Commented: (CAY-911) CM Usability: JComboBox Autocompletion
Posted by "Andrus Adamchik (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888#action_12888 ]
Andrus Adamchik commented on CAY-911:
-------------------------------------
BTW, a similar behavior was fixed per CAY-924, although I still have no idea why it behaved that way, and simply fixed it via experimentation.
> CM Usability: JComboBox Autocompletion
> --------------------------------------
>
> Key: CAY-911
> URL: https://issues.apache.org/cayenne/browse/CAY-911
> Project: Cayenne
> Issue Type: New Feature
> Components: CayenneModeler GUI
> Reporter: Thomas Bernhard
> Assignee: Kevin Menard
> Fix For: 3.0
>
> Attachments: patch-2008-05-11.txt, patch-CAY-911-25May.txt, patch-CAY-911.txt, screen.png
>
>
> Please use JComBox with autocompletion in CM at least in places that are very repetitive like selecting Field Types.
> It is very simple to implement it and there are several extremly well documented examples how to do it. E.g.:
> http://www.orbital-computer.de/JComboBox/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAY-911) CM Usability: JComboBox Autocompletion
Posted by "Andrus Adamchik (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887#action_12887 ]
Andrus Adamchik commented on CAY-911:
-------------------------------------
Just to make sure this is not related to me running from Eclipse, I just built a Mac assembly from trunk, and started the modeler from the assembled .dmg... Same thing :-/
> CM Usability: JComboBox Autocompletion
> --------------------------------------
>
> Key: CAY-911
> URL: https://issues.apache.org/cayenne/browse/CAY-911
> Project: Cayenne
> Issue Type: New Feature
> Components: CayenneModeler GUI
> Reporter: Thomas Bernhard
> Assignee: Kevin Menard
> Fix For: 3.0
>
> Attachments: patch-2008-05-11.txt, patch-CAY-911-25May.txt, patch-CAY-911.txt, screen.png
>
>
> Please use JComBox with autocompletion in CM at least in places that are very repetitive like selecting Field Types.
> It is very simple to implement it and there are several extremly well documented examples how to do it. E.g.:
> http://www.orbital-computer.de/JComboBox/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAY-911) CM Usability: JComboBox Autocompletion
Posted by "Kevin Menard (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014#action_13014 ]
Kevin Menard commented on CAY-911:
----------------------------------
This is getting to be an annoying issue. I can no longer duplicate the first issue of icon placement. I've never been able to duplicate the second issue you've reported.
Maybe 10.5.4 fixed the issue? Do you still see it? If you start with a clean prefs, do you see it (not that that *should* matter)?
> CM Usability: JComboBox Autocompletion
> --------------------------------------
>
> Key: CAY-911
> URL: https://issues.apache.org/cayenne/browse/CAY-911
> Project: Cayenne
> Issue Type: New Feature
> Components: CayenneModeler GUI
> Reporter: Thomas Bernhard
> Assignee: Kevin Menard
> Fix For: 3.0
>
> Attachments: patch-2008-05-11.txt, patch-CAY-911-25May.txt, patch-CAY-911.txt, screen.png, screen.png
>
>
> Please use JComBox with autocompletion in CM at least in places that are very repetitive like selecting Field Types.
> It is very simple to implement it and there are several extremly well documented examples how to do it. E.g.:
> http://www.orbital-computer.de/JComboBox/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAY-911) CM Usability: JComboBox Autocompletion
Posted by "Andrus Adamchik (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrus Adamchik updated CAY-911:
--------------------------------
Attachment: screen.png
Another OS X glitch. When I click on relationship targets, I get the entity image on the right
> CM Usability: JComboBox Autocompletion
> --------------------------------------
>
> Key: CAY-911
> URL: https://issues.apache.org/cayenne/browse/CAY-911
> Project: Cayenne
> Issue Type: New Feature
> Components: CayenneModeler GUI
> Reporter: Thomas Bernhard
> Assignee: Kevin Menard
> Fix For: 3.0
>
> Attachments: patch-2008-05-11.txt, patch-CAY-911-25May.txt, patch-CAY-911.txt, screen.png, screen.png
>
>
> Please use JComBox with autocompletion in CM at least in places that are very repetitive like selecting Field Types.
> It is very simple to implement it and there are several extremly well documented examples how to do it. E.g.:
> http://www.orbital-computer.de/JComboBox/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (CAY-911) CM Usability: JComboBox Autocompletion
Posted by "Kevin Menard (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Menard closed CAY-911.
----------------------------
Resolution: Fixed
Fix Version/s: 3.0
The third patch looks really good. I did have to do some minor cleaning up though. Please watch for code formatting, particularly with brace placement and spaces around parentheses on if/else/catch/etc. Also, please use braces even for one line statements. Finally, if code is commented out, there's no need to supply it with the patch.
Otherwise, I'm very pleased with the new feature. I like this autocompletion much better than the last patch and I think it's more consistent with what users will expect. The patch has been applied to trunk.
> CM Usability: JComboBox Autocompletion
> --------------------------------------
>
> Key: CAY-911
> URL: https://issues.apache.org/cayenne/browse/CAY-911
> Project: Cayenne
> Issue Type: New Feature
> Components: CayenneModeler GUI
> Reporter: Thomas Bernhard
> Assignee: Kevin Menard
> Fix For: 3.0
>
> Attachments: patch-2008-05-11.txt, patch-CAY-911-25May.txt, patch-CAY-911.txt
>
>
> Please use JComBox with autocompletion in CM at least in places that are very repetitive like selecting Field Types.
> It is very simple to implement it and there are several extremly well documented examples how to do it. E.g.:
> http://www.orbital-computer.de/JComboBox/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAY-911) CM Usability: JComboBox Autocompletion
Posted by "Kevin Menard (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864#action_12864 ]
Kevin Menard commented on CAY-911:
----------------------------------
I do think we want to handle auto-completion for ObjAttributes. In my experience, that's the combo box I'm most likely to start typing entries into. Also, I've just checked out CM and it looks to me like the ObjAttribute choices are sorted alphabetically. Since this is provided as a reason for not using auto-completion, please let me know if I'm mistaken.
I also found the combo box editor deletion logic a bit odd. It didn't actually delete what I typed, but rather changed the highlighted area. It was quite confusing. Any chance we can make the backspace key actually delete the selected text?
Finally, CayenneWidgetFactory uses magic numbers for the maximum row count. Please use a static field for such values.
> CM Usability: JComboBox Autocompletion
> --------------------------------------
>
> Key: CAY-911
> URL: https://issues.apache.org/cayenne/browse/CAY-911
> Project: Cayenne
> Issue Type: New Feature
> Components: CayenneModeler GUI
> Reporter: Thomas Bernhard
> Assignee: Kevin Menard
> Attachments: patch-2008-05-11.txt, patch-CAY-911.txt
>
>
> Please use JComBox with autocompletion in CM at least in places that are very repetitive like selecting Field Types.
> It is very simple to implement it and there are several extremly well documented examples how to do it. E.g.:
> http://www.orbital-computer.de/JComboBox/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAY-911) CM Usability: JComboBox Autocompletion
Posted by "Andrey Razumovsky (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13015#action_13015 ]
Andrey Razumovsky commented on CAY-911:
---------------------------------------
The first issue is probably because I do not consider insets when I paint renderer's component. In fact, this can be seen on Linux and Windows too, but less ugly (but different that original combobox appearance. This is not hard to fix, but I do not have Mac now. So if you could test it for me, that'll be great, I can supply the patch
> CM Usability: JComboBox Autocompletion
> --------------------------------------
>
> Key: CAY-911
> URL: https://issues.apache.org/cayenne/browse/CAY-911
> Project: Cayenne
> Issue Type: New Feature
> Components: CayenneModeler GUI
> Reporter: Thomas Bernhard
> Assignee: Kevin Menard
> Fix For: 3.0
>
> Attachments: patch-2008-05-11.txt, patch-CAY-911-25May.txt, patch-CAY-911.txt, screen.png, screen.png
>
>
> Please use JComBox with autocompletion in CM at least in places that are very repetitive like selecting Field Types.
> It is very simple to implement it and there are several extremly well documented examples how to do it. E.g.:
> http://www.orbital-computer.de/JComboBox/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAY-911) CM Usability: JComboBox Autocompletion
Posted by "Kevin Menard (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863#action_12863 ]
Kevin Menard commented on CAY-911:
----------------------------------
All in all, the code looks pretty good. The second patch could be cleaned up. It uses absolute paths rather than relative ones, so I had to modify that. The second patch also contain cruft unrelated to the core issue. Please make sure that non-significant whitespace changes (e.g., trailing whitespace) don't make their way into the patch. Same deal with the Eclipse project files, such as .classpath.
Unfortunately, I can't apply the patch to trunk quite yet because there may be a licensing issue. The patch contains code taken from the link mentioned in the issue body. All code contributions must be ASLv2 compatible. This code is listed as being released into the public domain, which I understand to be a forfeiture of copyright and thus no license at all. So, before we commit, I'd like get that issue squared away.
> CM Usability: JComboBox Autocompletion
> --------------------------------------
>
> Key: CAY-911
> URL: https://issues.apache.org/cayenne/browse/CAY-911
> Project: Cayenne
> Issue Type: New Feature
> Components: CayenneModeler GUI
> Reporter: Thomas Bernhard
> Assignee: Kevin Menard
> Attachments: patch-2008-05-11.txt, patch-CAY-911.txt
>
>
> Please use JComBox with autocompletion in CM at least in places that are very repetitive like selecting Field Types.
> It is very simple to implement it and there are several extremly well documented examples how to do it. E.g.:
> http://www.orbital-computer.de/JComboBox/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAY-911) CM Usability: JComboBox Autocompletion
Posted by "Kevin Menard (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12912#action_12912 ]
Kevin Menard commented on CAY-911:
----------------------------------
Odd, now I can see the problem. I also see it on the ObjectSelectQuery chooser.
> CM Usability: JComboBox Autocompletion
> --------------------------------------
>
> Key: CAY-911
> URL: https://issues.apache.org/cayenne/browse/CAY-911
> Project: Cayenne
> Issue Type: New Feature
> Components: CayenneModeler GUI
> Reporter: Thomas Bernhard
> Assignee: Kevin Menard
> Fix For: 3.0
>
> Attachments: patch-2008-05-11.txt, patch-CAY-911-25May.txt, patch-CAY-911.txt, screen.png
>
>
> Please use JComBox with autocompletion in CM at least in places that are very repetitive like selecting Field Types.
> It is very simple to implement it and there are several extremly well documented examples how to do it. E.g.:
> http://www.orbital-computer.de/JComboBox/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAY-911) CM Usability: JComboBox Autocompletion
Posted by "Kevin Menard (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085#action_13085 ]
Kevin Menard commented on CAY-911:
----------------------------------
Latest patch applied. Things seem to look good for me, but I was having difficulty reproducing anyway.
Andrus, can you see if the changes make a difference for you, please?
> CM Usability: JComboBox Autocompletion
> --------------------------------------
>
> Key: CAY-911
> URL: https://issues.apache.org/cayenne/browse/CAY-911
> Project: Cayenne
> Issue Type: New Feature
> Components: CayenneModeler GUI
> Reporter: Thomas Bernhard
> Assignee: Kevin Menard
> Fix For: 3.0
>
> Attachments: patch-2008-05-11.txt, patch-CAY-911-25May.txt, patch-CAY-911-3.txt, patch-CAY-911.txt, screen.png, screen.png
>
>
> Please use JComBox with autocompletion in CM at least in places that are very repetitive like selecting Field Types.
> It is very simple to implement it and there are several extremly well documented examples how to do it. E.g.:
> http://www.orbital-computer.de/JComboBox/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAY-911) CM Usability: JComboBox Autocompletion
Posted by "Andrey Razumovsky (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrey Razumovsky updated CAY-911:
----------------------------------
Attachment: patch-CAY-911.txt
The patch contains the implementation of the feature (the first one is discarded since it contains other functionality). Few notes:
1. Auto-completion implemented for entities, attributes and DB types selections (not objattr type selections since the combo is not sorted and auto-completion will lose its effect).
2. Auto-completion is a automatic selecting of matching item in combo. For existing selections, you cannot type items not present in the list.
3. For entities, the icon is hidden during editing.
4. Four classes from org.apache.cayenne.modeler.util.combo are responsible for auto-completion.
5. I've spent tons of time trying to figure out why *sometimes* editor in table is not fired or fired incorrectly (BTW, i think someone from the Team had already encountered this problem, because there are a lot of DefaultCellEditor.setClickToStart(1) lines. 1 is by default for comboboxes :) ).
Turns out this is because-of cancelEditing() invocation in CayenneTable, which is fired in the middle of showing editor. I removed that line and placed it in tableChanged() and also in popup handling. In most cases when changing selected line, editing is stopped automatically by Swing.
> CM Usability: JComboBox Autocompletion
> --------------------------------------
>
> Key: CAY-911
> URL: https://issues.apache.org/cayenne/browse/CAY-911
> Project: Cayenne
> Issue Type: New Feature
> Components: CayenneModeler GUI
> Reporter: Thomas Bernhard
> Assignee: Kevin Menard
> Attachments: patch-2008-05-11.txt, patch-CAY-911.txt
>
>
> Please use JComBox with autocompletion in CM at least in places that are very repetitive like selecting Field Types.
> It is very simple to implement it and there are several extremly well documented examples how to do it. E.g.:
> http://www.orbital-computer.de/JComboBox/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAY-911) CM Usability: JComboBox Autocompletion
Posted by "Andrey Razumovsky (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrey Razumovsky updated CAY-911:
----------------------------------
Attachment: patch-2008-05-11.txt
A patch containing sample auto-completion for comboboxes. By now this is embedded *only* for db type columns (in 'Db Entity Attributes' tab and 'Procedure Parameters' tab. Futher auto-completion (for other comboboxes of the project) might be implemented after some conferring with team
> CM Usability: JComboBox Autocompletion
> --------------------------------------
>
> Key: CAY-911
> URL: https://issues.apache.org/cayenne/browse/CAY-911
> Project: Cayenne
> Issue Type: New Feature
> Components: CayenneModeler GUI
> Reporter: Thomas Bernhard
> Assignee: Andrus Adamchik
> Attachments: patch-2008-05-11.txt
>
>
> Please use JComBox with autocompletion in CM at least in places that are very repetitive like selecting Field Types.
> It is very simple to implement it and there are several extremly well documented examples how to do it. E.g.:
> http://www.orbital-computer.de/JComboBox/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAY-911) CM Usability: JComboBox Autocompletion
Posted by "Andrey Razumovsky (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrey Razumovsky updated CAY-911:
----------------------------------
Attachment: patch-CAY-911-25May.txt
The next (and hopefully the last) patch. It is completely new, i.e. must be applied to repository code, not to previous patch.
Auto-completion works now really cool since it shows only matching items. For ObjAttributes it is even cooler because-of 'contains' matching (when you type 'char', both 'char' and 'java.lang.CHARacter' are seen).
For comboboxes not allowing user values you can quickly select items hitting 'Enter' without selecting item in the suggestion list - the first one will be taken. Otherwise, navigation keys can be used.
If there are no suggestions, no popups are shown.
Users can still open original popup by pressing arrow button or navigation key when suggestion list is not shown.
Also note that there is no licensing problem now since i've rewrited all from the clean sheet (only names are the same). This is at least correct for AutoCompletion class. ComboBoxCellEditor is still mostly the same, but it is not much of a class (i can reconsider it too if needed).
Implemetation details:
SuggestionList is a new class responsible for filtering and showing tips. Two combo-popups are used because Swing doesn't allow changing ComboPopup without inheriting UI class (and this is forbidden in our case).
There was a major problem with key actions, which are also bound to UI. I came up into completely replacing key behavior with my own - it is in AutoCompletion class.
> CM Usability: JComboBox Autocompletion
> --------------------------------------
>
> Key: CAY-911
> URL: https://issues.apache.org/cayenne/browse/CAY-911
> Project: Cayenne
> Issue Type: New Feature
> Components: CayenneModeler GUI
> Reporter: Thomas Bernhard
> Assignee: Kevin Menard
> Attachments: patch-2008-05-11.txt, patch-CAY-911-25May.txt, patch-CAY-911.txt
>
>
> Please use JComBox with autocompletion in CM at least in places that are very repetitive like selecting Field Types.
> It is very simple to implement it and there are several extremly well documented examples how to do it. E.g.:
> http://www.orbital-computer.de/JComboBox/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAY-911) CM Usability: JComboBox Autocompletion
Posted by "Andrey Razumovsky (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrey Razumovsky updated CAY-911:
----------------------------------
Attachment: patch-CAY-911-3.txt
New patch forces EditorTextField to use insets when painting value in combobox. Hope that helps
> CM Usability: JComboBox Autocompletion
> --------------------------------------
>
> Key: CAY-911
> URL: https://issues.apache.org/cayenne/browse/CAY-911
> Project: Cayenne
> Issue Type: New Feature
> Components: CayenneModeler GUI
> Reporter: Thomas Bernhard
> Assignee: Kevin Menard
> Fix For: 3.0
>
> Attachments: patch-2008-05-11.txt, patch-CAY-911-25May.txt, patch-CAY-911-3.txt, patch-CAY-911.txt, screen.png, screen.png
>
>
> Please use JComBox with autocompletion in CM at least in places that are very repetitive like selecting Field Types.
> It is very simple to implement it and there are several extremly well documented examples how to do it. E.g.:
> http://www.orbital-computer.de/JComboBox/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[JIRA] Commented: (CAY-911) CM Usability: JComboBox Autocompletion
Posted by "Andrus Adamchik (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12572 ]
Andrus Adamchik commented on CAY-911:
-------------------------------------
+1. good idea
> CM Usability: JComboBox Autocompletion
> --------------------------------------
>
> Key: CAY-911
> URL: https://issues.apache.org/cayenne/browse/CAY-911
> Project: Cayenne
> Issue Type: New Feature
> Components: CayenneModeler GUI
> Reporter: Thomas Bernhard
> Assignee: Andrus Adamchik
>
> Please use JComBox with autocompletion in CM at least in places that are very repetitive like selecting Field Types.
> It is very simple to implement it and there are several extremly well documented examples how to do it. E.g.:
> http://www.orbital-computer.de/JComboBox/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (CAY-911) CM Usability: JComboBox Autocompletion
Posted by "Kevin Menard (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Menard closed CAY-911.
----------------------------
Resolution: Fixed
No further comment, so I'm going to have to assumed it's fixed. I've been unable to reproduce. Please reopen if truly an issue.
> CM Usability: JComboBox Autocompletion
> --------------------------------------
>
> Key: CAY-911
> URL: https://issues.apache.org/cayenne/browse/CAY-911
> Project: Cayenne
> Issue Type: New Feature
> Components: CayenneModeler GUI
> Reporter: Thomas Bernhard
> Assignee: Kevin Menard
> Fix For: 3.0
>
> Attachments: patch-2008-05-11.txt, patch-CAY-911-25May.txt, patch-CAY-911-3.txt, patch-CAY-911.txt, screen.png, screen.png
>
>
> Please use JComBox with autocompletion in CM at least in places that are very repetitive like selecting Field Types.
> It is very simple to implement it and there are several extremly well documented examples how to do it. E.g.:
> http://www.orbital-computer.de/JComboBox/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (CAY-911) CM Usability: JComboBox Autocompletion
Posted by "Kevin Menard (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Menard reopened CAY-911:
------------------------------
Reopening pending resolution of the modeler glitches on MacOS X 10.5.
> CM Usability: JComboBox Autocompletion
> --------------------------------------
>
> Key: CAY-911
> URL: https://issues.apache.org/cayenne/browse/CAY-911
> Project: Cayenne
> Issue Type: New Feature
> Components: CayenneModeler GUI
> Reporter: Thomas Bernhard
> Assignee: Kevin Menard
> Fix For: 3.0
>
> Attachments: patch-2008-05-11.txt, patch-CAY-911-25May.txt, patch-CAY-911.txt, screen.png
>
>
> Please use JComBox with autocompletion in CM at least in places that are very repetitive like selecting Field Types.
> It is very simple to implement it and there are several extremly well documented examples how to do it. E.g.:
> http://www.orbital-computer.de/JComboBox/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAY-911) CM Usability: JComboBox Autocompletion
Posted by "Kevin Menard (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Menard reassigned CAY-911:
--------------------------------
Assignee: Kevin Menard (was: Andrus Adamchik)
> CM Usability: JComboBox Autocompletion
> --------------------------------------
>
> Key: CAY-911
> URL: https://issues.apache.org/cayenne/browse/CAY-911
> Project: Cayenne
> Issue Type: New Feature
> Components: CayenneModeler GUI
> Reporter: Thomas Bernhard
> Assignee: Kevin Menard
> Attachments: patch-2008-05-11.txt
>
>
> Please use JComBox with autocompletion in CM at least in places that are very repetitive like selecting Field Types.
> It is very simple to implement it and there are several extremly well documented examples how to do it. E.g.:
> http://www.orbital-computer.de/JComboBox/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAY-911) CM Usability: JComboBox Autocompletion
Posted by "Andrus Adamchik (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrus Adamchik updated CAY-911:
--------------------------------
Attachment: screen.png
On Mac Comboxoboxes look a bit off when unfocused (see screenshot attached)... Icon sticks outside the border if there is an icon, and there is a white border around the black (proper) border. Focused fields look ok.
> CM Usability: JComboBox Autocompletion
> --------------------------------------
>
> Key: CAY-911
> URL: https://issues.apache.org/cayenne/browse/CAY-911
> Project: Cayenne
> Issue Type: New Feature
> Components: CayenneModeler GUI
> Reporter: Thomas Bernhard
> Assignee: Kevin Menard
> Fix For: 3.0
>
> Attachments: patch-2008-05-11.txt, patch-CAY-911-25May.txt, patch-CAY-911.txt, screen.png
>
>
> Please use JComBox with autocompletion in CM at least in places that are very repetitive like selecting Field Types.
> It is very simple to implement it and there are several extremly well documented examples how to do it. E.g.:
> http://www.orbital-computer.de/JComboBox/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAY-911) CM Usability: JComboBox Autocompletion
Posted by "Kevin Menard (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142#action_13142 ]
Kevin Menard commented on CAY-911:
----------------------------------
Not looking to be a pain in the neck, but I would like to close this out if it is indeed fixed. MacOS X testers wanted.
> CM Usability: JComboBox Autocompletion
> --------------------------------------
>
> Key: CAY-911
> URL: https://issues.apache.org/cayenne/browse/CAY-911
> Project: Cayenne
> Issue Type: New Feature
> Components: CayenneModeler GUI
> Reporter: Thomas Bernhard
> Assignee: Kevin Menard
> Fix For: 3.0
>
> Attachments: patch-2008-05-11.txt, patch-CAY-911-25May.txt, patch-CAY-911-3.txt, patch-CAY-911.txt, screen.png, screen.png
>
>
> Please use JComBox with autocompletion in CM at least in places that are very repetitive like selecting Field Types.
> It is very simple to implement it and there are several extremly well documented examples how to do it. E.g.:
> http://www.orbital-computer.de/JComboBox/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[JIRA] Commented: (CAY-911) CM Usability: JComboBox Autocompletion
Posted by "Demetrios Kyriakis (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12577 ]
Demetrios Kyriakis commented on CAY-911:
----------------------------------------
Thank you for the example link - it looks really nice. I just used it in one application :).
(I wonder why isn't that the default behaviour of JComboBox :) )
> CM Usability: JComboBox Autocompletion
> --------------------------------------
>
> Key: CAY-911
> URL: https://issues.apache.org/cayenne/browse/CAY-911
> Project: Cayenne
> Issue Type: New Feature
> Components: CayenneModeler GUI
> Reporter: Thomas Bernhard
> Assignee: Andrus Adamchik
>
> Please use JComBox with autocompletion in CM at least in places that are very repetitive like selecting Field Types.
> It is very simple to implement it and there are several extremly well documented examples how to do it. E.g.:
> http://www.orbital-computer.de/JComboBox/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAY-911) CM Usability: JComboBox Autocompletion
Posted by "Kevin Menard (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886#action_12886 ]
Kevin Menard commented on CAY-911:
----------------------------------
Odd. I primarily tested on Mac OS 10.5.2. I've since installed 10.5.3 and cannot reproduce what you're seeing. In fact, both the "inheritance" and "table/view" sections have a gray background rather than the white one you have, so I'm wondering why the LnF is different . . .
> CM Usability: JComboBox Autocompletion
> --------------------------------------
>
> Key: CAY-911
> URL: https://issues.apache.org/cayenne/browse/CAY-911
> Project: Cayenne
> Issue Type: New Feature
> Components: CayenneModeler GUI
> Reporter: Thomas Bernhard
> Assignee: Kevin Menard
> Fix For: 3.0
>
> Attachments: patch-2008-05-11.txt, patch-CAY-911-25May.txt, patch-CAY-911.txt, screen.png
>
>
> Please use JComBox with autocompletion in CM at least in places that are very repetitive like selecting Field Types.
> It is very simple to implement it and there are several extremly well documented examples how to do it. E.g.:
> http://www.orbital-computer.de/JComboBox/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.