You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/11/01 18:01:00 UTC
[jira] [Commented] (HELIX-779) Maintenance rebalancer should not
clear preference list in ideal state
[ https://issues.apache.org/jira/browse/HELIX-779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16671943#comment-16671943 ]
ASF GitHub Bot commented on HELIX-779:
--------------------------------------
GitHub user zhan849 opened a pull request:
https://github.com/apache/helix/pull/285
[HELIX-779] do not clean list field in maintenance rebalancer for new resources
Setting list fields to empty map will prevent newly added and initially rebalanced resources during maintenance mode from getting re-balanced after cluster exists maintenance mode.
The right thing to do is to clear every preference list.
Also added test case to verify
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhan849/helix harry/maintenance-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/helix/pull/285.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #285
----
commit bfaa8399529b6e63b307c1fbe60903c3ca08fbb1
Author: Harry Zhang <hr...@...>
Date: 2018-10-04T22:50:16Z
[HELIX-779] do not clean list field in maintenance rebalancer for new resources
----
> Maintenance rebalancer should not clear preference list in ideal state
> ----------------------------------------------------------------------
>
> Key: HELIX-779
> URL: https://issues.apache.org/jira/browse/HELIX-779
> Project: Apache Helix
> Issue Type: Bug
> Components: helix-core
> Reporter: Harry Zhang
> Assignee: Harry Zhang
> Priority: Major
>
> Setting list fields to empty map will prevent newly added and initially rebalanced resources during maintenance mode from getting re-balanced after cluster exists maintenance mode.
> The right thing to do is to clear every preference list.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)