[GitHub] [superset] diegomedina248 commented on a change in pull request #19328: feat(sql lab): enable ACE editor search in SQL editors

[GitBox <gi...@apache.org>]

diegomedina248 commented on a change in pull request #19328:
URL: https://github.com/apache/superset/pull/19328#discussion_r834510039



##########
File path: superset-frontend/src/SqlLab/components/AceEditorWrapper/index.tsx
##########
@@ -127,8 +127,6 @@ class AceEditorWrapper extends React.PureComponent<Props, State> {
   }
 
   onEditorLoad(editor: any) {
-    editor.commands.removeCommand('find');

Review comment:
       The editor originally trapped the find command, but it wasn't working.
   So, we removed it to offer basic search functionality using the browser.
   This re-enables search within the editor with a plugin, which is far better at searching




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org