You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "1996fanrui (via GitHub)" <gi...@apache.org> on 2026/04/07 22:08:12 UTC

[PR] [FLINK-39408][tests] Fix TestNameProvider broken after JUnit 5 migration [flink]

1996fanrui opened a new pull request, #27902:
URL: https://github.com/apache/flink/pull/27902

   ## Summary
   
   After FLINK-39124 migrated modules to JUnit 5, `TestNameProvider` (a JUnit 4 `TestRule`) is never triggered. This causes `PseudoRandomValueSelector.randomize()` to always get `null` from `getCurrentTestName()`, making all boolean config randomizations (e.g. `ENABLE_UNALIGNED`, `UNALIGNED_DURING_RECOVERY_ENABLED`, `SNAPSHOT_COMPRESSION`) select the same fixed value across all tests.
   
   **Fix:**
   - Make `TestNameProvider` also implement JUnit 5 `BeforeEachCallback` / `AfterEachCallback`
   - Register it globally via `META-INF/services/org.junit.jupiter.api.extension.Extension` in all modules
   
   ## Test plan
   
   - [x] Verified that `PseudoRandomValueSelector` log output now shows varied `true`/`false` values instead of all `false`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-39408][tests] Fix TestNameProvider broken after JUnit 5 migration [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #27902:
URL: https://github.com/apache/flink/pull/27902#issuecomment-4202503925

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "791cdbe86e3ba164c5038d09a210814255230fcf",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "791cdbe86e3ba164c5038d09a210814255230fcf",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 791cdbe86e3ba164c5038d09a210814255230fcf UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-39408][tests] Fix TestNameProvider broken after JUnit 5 migration [flink]

Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui merged PR #27902:
URL: https://github.com/apache/flink/pull/27902


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org