[jira] [Assigned] (SPARK-29635) Deduplicate test suites between Kafka micro-batch sink and Kafka continuous sink

["Marcelo Masiero Vanzin (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SPARK-29635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marcelo Masiero Vanzin reassigned SPARK-29635:
----------------------------------------------

    Assignee: Jungtaek Lim

> Deduplicate test suites between Kafka micro-batch sink and Kafka continuous sink
> --------------------------------------------------------------------------------
>
>                 Key: SPARK-29635
>                 URL: https://issues.apache.org/jira/browse/SPARK-29635
>             Project: Spark
>          Issue Type: Improvement
>          Components: Structured Streaming
>    Affects Versions: 3.0.0
>            Reporter: Jungtaek Lim
>            Assignee: Jungtaek Lim
>            Priority: Minor
>
> There's a comment in KafkaContinuousSinkSuite which is most likely explaining TODO:
> https://github.com/apache/spark/blob/37690dea107623ebca1e47c64db59196ee388f2f/external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaContinuousSinkSuite.scala#L35-L39
> {noformat}
> /**
>  * This is a temporary port of KafkaSinkSuite, since we do not yet have a V2 memory stream.
>  * Once we have one, this will be changed to a specialization of KafkaSinkSuite and we won't have
>  * to duplicate all the code.
>  */
> {noformat}
> Given latest master branch has V2 memory stream now, it is a good time to deduplicate two suites into one, via having base class and let these suites override necessary things.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org