You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/07/02 09:27:24 UTC
[GitHub] [cloudstack] ustcweizhou opened a new pull request #3945: server: update template to another template type
ustcweizhou opened a new pull request #3945:
URL: https://github.com/apache/cloudstack/pull/3945
## Description
<!--- Describe your changes in detail -->
this contains other changes
(1) add isrouting field for vm templates on UI
(2) show register URL of template/iso on UI
(3) set 'Bootable' field to changable for existing ISO
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
this provides a easy way to upload systemvm template
(1) register template
(2) update template type from USER to SYSTEM
(3) destroy ssvm/cpvm, new systemvms will be created from the new template (latest template with type=SYSTEM)
(4) change global setting router.template.kvm (or other hypervisor) to the name of new template, new VRs will be created from the new template.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3945: server: update template to another template type
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #3945:
URL: https://github.com/apache/cloudstack/pull/3945#issuecomment-652897356
@ustcweizhou do we want to restrict this to root admin only?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #3945: server: update template to another template type
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #3945:
URL: https://github.com/apache/cloudstack/pull/3945
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #3945: server: update template to another template type
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3945:
URL: https://github.com/apache/cloudstack/pull/3945#issuecomment-717301704
ping @ustcweizhou , I created https://github.com/apache/cloudstack-primate/issues/835. Can you add details there?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3945: server: update template to another template type
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3945:
URL: https://github.com/apache/cloudstack/pull/3945#issuecomment-712759863
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2213
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3945: server: update template to another template type
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #3945:
URL: https://github.com/apache/cloudstack/pull/3945#issuecomment-643536583
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #3945: server: update template to another template type
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #3945:
URL: https://github.com/apache/cloudstack/pull/3945#issuecomment-653416433
> @ustcweizhou do we want to restrict this to root admin only?
@rhtyd
I was thinking about the following change
```
- @Parameter(name = "templatetype", type = CommandType.STRING, description = "the type of the template")
+ @Parameter(name = "templatetype", type = CommandType.STRING, description = "the type of the template", authorized
+ = {RoleType.Admin})
private String templateType;
```
however, when I tested with normal user or domain admin, the api succeed without templatetype change.
```
(test1) > update template id="ce3d5211-3209-4617-b569-6c533801a20c" templatetype=SYSTEM
{
"template": {
"account": "test1",
"bits": 0,
"bootable": true,
"created": "2020-06-12T09:54:08+0000",
"crossZones": false,
"details": {
"rootDiskController": "osdefault"
},
"displaytext": "ubuntu18-minimal-test1",
"domain": "test1",
"domainid": "931bc746-8a9a-45ec-8c50-776b89aed898",
"format": "QCOW2",
"hypervisor": "KVM",
"id": "ce3d5211-3209-4617-b569-6c533801a20c",
"isdynamicallyscalable": false,
"isfeatured": false,
"ispublic": false,
"isready": false,
"name": "ubuntu18-minimal-test1",
"ostypeid": "67bad17c-186e-11ea-83e0-066004001165",
"ostypename": "Apple Mac OS X 10.6 (32-bit)",
"tags": [],
"templatetype": "USER"
}
}
```
without this change, I got following error which looks better.
```
(test1) > update template id="ce3d5211-3209-4617-b569-6c533801a20c" templatetype=SYSTEM
Error 531: Parameter templatetype can only be specified by a Root Admin, permission denied
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #3945: server: update template to another template type
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3945:
URL: https://github.com/apache/cloudstack/pull/3945#issuecomment-625137140
@weizhouapache marking for 4.14.1
It will need primate work for that, right? Can you add a ticket there?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3945: server: update template to another template type
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3945:
URL: https://github.com/apache/cloudstack/pull/3945#issuecomment-643536926
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd removed a comment on pull request #3945: server: update template to another template type
Posted by GitBox <gi...@apache.org>.
rhtyd removed a comment on pull request #3945:
URL: https://github.com/apache/cloudstack/pull/3945#issuecomment-643536583
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3945: server: update template to another template type
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3945:
URL: https://github.com/apache/cloudstack/pull/3945#issuecomment-713174200
<b>Trillian test result (tid-3017)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33032 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3945-t3017-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #3945: server: update template to another template type
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3945:
URL: https://github.com/apache/cloudstack/pull/3945#issuecomment-717302271
ping @PaulAngus @rhtyd merge this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #3945: server: update template to another template type
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #3945:
URL: https://github.com/apache/cloudstack/pull/3945
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3945: server: update template to another template type
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3945:
URL: https://github.com/apache/cloudstack/pull/3945#issuecomment-643550936
Packaging result: ✖centos7 ✖debian. JID-1367
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3945: server: update template to another template type
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3945:
URL: https://github.com/apache/cloudstack/pull/3945#issuecomment-712819740
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3945: server: update template to another template type
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #3945:
URL: https://github.com/apache/cloudstack/pull/3945#issuecomment-717832348
I see small enhanacement/improvement, tests have passed. We probably can get away with this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #3945: server: update template to another template type
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3945:
URL: https://github.com/apache/cloudstack/pull/3945#issuecomment-712819151
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3945: server: update template to another template type
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #3945:
URL: https://github.com/apache/cloudstack/pull/3945#issuecomment-643536977
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org