You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2013/05/14 03:39:06 UTC

Review Request: Updated Clock::now() and Clock::now(ProcessBase*) to return a "Seconds". (libprocess)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11137/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.


Description
-------

To make Clock fully Duration aware.


Diffs
-----

  third_party/libprocess/include/process/clock.hpp 46b737dcd680a770193dbee9ba2ffd796ec48abd 
  third_party/libprocess/include/process/statistics.hpp 3f56c078d8609041c80c312aa9a42ed24ca42e60 
  third_party/libprocess/include/process/timeout.hpp a907af19c9faa1c87864c5294a8e833bdca60252 
  third_party/libprocess/src/process.cpp 197611fffe1d6f76b011211cf153a41c79c125a1 
  third_party/libprocess/src/statistics.cpp e1fb319eff63e4b7a4c18dba43e4818018b0dd50 
  third_party/libprocess/src/tests/process_tests.cpp 8fbf19676c54eb0da6f8daa042de127608bcb00b 
  third_party/libprocess/src/tests/statistics_tests.cpp d6a53f79c8afe4cccebed2274f3dfdd1fe540d02 

Diff: https://reviews.apache.org/r/11137/diff/


Testing
-------

make check


Thanks,

Jiang Yan Xu


Re: Review Request: Updated Clock::now() and Clock::now(ProcessBase*) to return a "Seconds". (libprocess)

Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11137/
-----------------------------------------------------------

(Updated May 16, 2013, 7:53 a.m.)


Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.


Changes
-------

Rebased off master.


Description
-------

[Part 3 of Duration-Time Refactoring Chain] To make Clock fully Duration aware.

- Timeout now stored a Duration instead of a double. It will be changed to a "Time" in a later commit. https://reviews.apache.org/r/11143
- The oddity of "Seconds now();" motivated further changes to create the Time class.


Diffs (updated)
-----

  third_party/libprocess/include/process/clock.hpp 46b737dcd680a770193dbee9ba2ffd796ec48abd 
  third_party/libprocess/include/process/statistics.hpp 3f56c078d8609041c80c312aa9a42ed24ca42e60 
  third_party/libprocess/include/process/timeout.hpp a907af19c9faa1c87864c5294a8e833bdca60252 
  third_party/libprocess/src/process.cpp edcb684332590f0277bafb2d69de68413fc82828 
  third_party/libprocess/src/statistics.cpp e1fb319eff63e4b7a4c18dba43e4818018b0dd50 
  third_party/libprocess/src/tests/process_tests.cpp 8fbf19676c54eb0da6f8daa042de127608bcb00b 
  third_party/libprocess/src/tests/statistics_tests.cpp d6a53f79c8afe4cccebed2274f3dfdd1fe540d02 

Diff: https://reviews.apache.org/r/11137/diff/


Testing
-------

make check


Thanks,

Jiang Yan Xu


Re: Review Request: Updated Clock::now() and Clock::now(ProcessBase*) to return a "Seconds". (libprocess)

Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11137/
-----------------------------------------------------------

(Updated May 14, 2013, 8:19 a.m.)


Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.


Description (updated)
-------

[Part 3 of Duration-Time Refactoring Chain] To make Clock fully Duration aware.

- Timeout now stored a Duration instead of a double. It will be changed to a "Time" in a later commit. https://reviews.apache.org/r/11143
- The oddity of "Seconds now();" motivated further changes to create the Time class.


Diffs
-----

  third_party/libprocess/include/process/clock.hpp 46b737dcd680a770193dbee9ba2ffd796ec48abd 
  third_party/libprocess/include/process/statistics.hpp 3f56c078d8609041c80c312aa9a42ed24ca42e60 
  third_party/libprocess/include/process/timeout.hpp a907af19c9faa1c87864c5294a8e833bdca60252 
  third_party/libprocess/src/process.cpp 197611fffe1d6f76b011211cf153a41c79c125a1 
  third_party/libprocess/src/statistics.cpp e1fb319eff63e4b7a4c18dba43e4818018b0dd50 
  third_party/libprocess/src/tests/process_tests.cpp 8fbf19676c54eb0da6f8daa042de127608bcb00b 
  third_party/libprocess/src/tests/statistics_tests.cpp d6a53f79c8afe4cccebed2274f3dfdd1fe540d02 

Diff: https://reviews.apache.org/r/11137/diff/


Testing
-------

make check


Thanks,

Jiang Yan Xu