You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by dongjoon-hyun <gi...@git.apache.org> on 2016/03/31 21:46:00 UTC

[GitHub] spark pull request: [MINOR][SQL] Update usage of `debug` by removi...

GitHub user dongjoon-hyun opened a pull request:

    https://github.com/apache/spark/pull/12094

    [MINOR][SQL] Update usage of `debug` by removing `typeCheck` and adding `debugCodegen`

    ## What changes were proposed in this pull request?
    
    This PR updates the usage comments of `debug` according to the following commits.
    - [SPARK-9754](https://issues.apache.org/jira/browse/SPARK-9754) removed `typeCheck`.
    - [SPARK-14227](https://issues.apache.org/jira/browse/SPARK-14227) added `debugCodegen`.
    
    ## How was this patch tested?
    
    Manual.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dongjoon-hyun/spark minor_fix_debug_usage

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/12094.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #12094
    
----
commit 4fe6769f560ced5f5e561f765948d7aec7474612
Author: Dongjoon Hyun <do...@apache.org>
Date:   2016-03-31T19:33:30Z

    [MINOR][SQL][DOCS] Update usage of `debug` by removing `typeCheck` and adding `debugCodegen`

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [MINOR][SQL] Update usage of `debug` by removi...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/12094


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [MINOR][SQL] Update usage of `debug` by removi...

Posted by davies <gi...@git.apache.org>.
Github user davies commented on the pull request:

    https://github.com/apache/spark/pull/12094#issuecomment-204482908
  
    @dongjoon-hyun These tiny things may not worth a PR, could you fix it along with others next time?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [MINOR][SQL] Update usage of `debug` by removi...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/12094#issuecomment-204097841
  
    **[Test build #54658 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54658/consoleFull)** for PR 12094 at commit [`4fe6769`](https://github.com/apache/spark/commit/4fe6769f560ced5f5e561f765948d7aec7474612).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [MINOR][SQL] Update usage of `debug` by removi...

Posted by DeepSparkBot <gi...@git.apache.org>.
Github user DeepSparkBot commented on the pull request:

    https://github.com/apache/spark/pull/12094#issuecomment-204478200
  
    @nongli @davies Please advise.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [MINOR][SQL] Update usage of `debug` by removi...

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the pull request:

    https://github.com/apache/spark/pull/12094#issuecomment-204489579
  
    I see. Thank you, @davies .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [MINOR][SQL] Update usage of `debug` by removi...

Posted by davies <gi...@git.apache.org>.
Github user davies commented on the pull request:

    https://github.com/apache/spark/pull/12094#issuecomment-204483037
  
    LGTM, merged into master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org