You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Laszlo Hornyak <la...@gmail.com> on 2013/09/03 00:00:14 UTC
Review Request 13939: String join simplification
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13939/
-----------------------------------------------------------
Review request for cloudstack and David Nalley.
Repository: cloudstack-git
Description
-------
- use commons-lang stringutils
- added test to check compatibility
Diffs
-----
utils/src/com/cloud/utils/StringUtils.java 948c0ac
utils/test/com/cloud/utils/StringUtilsTest.java ae37c24
Diff: https://reviews.apache.org/r/13939/diff/
Testing
-------
Thanks,
Laszlo Hornyak
Re: Review Request 13939: String join simplification
Posted by Rajesh Battala <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13939/#review25844
-----------------------------------------------------------
Ship it!
API used will handle NULL iterator also..
Joins the elements of the provided Collection into a single String containing the provided elements.
No delimiter is added before or after the list. Null objects or empty strings within the iteration are represented by empty strings.
- Rajesh Battala
On Sept. 2, 2013, 10 p.m., Laszlo Hornyak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13939/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2013, 10 p.m.)
>
>
> Review request for cloudstack and David Nalley.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> - use commons-lang stringutils
> - added test to check compatibility
>
>
> Diffs
> -----
>
> utils/src/com/cloud/utils/StringUtils.java 948c0ac
> utils/test/com/cloud/utils/StringUtilsTest.java ae37c24
>
> Diff: https://reviews.apache.org/r/13939/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Laszlo Hornyak
>
>
Re: Review Request 13939: String join simplification
Posted by Rajesh Battala <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13939/#review25848
-----------------------------------------------------------
if the iterator is Null, then it will return null, Good you had handled the case in the new patch.
Joins the elements of the provided array into a single String containing the provided list of elements.
No delimiter is added before or after the list. Null objects or empty strings within the array are represented by empty strings.
StringUtils.join(null, *) = null
StringUtils.join([], *) = ""
StringUtils.join([null], *) = ""
StringUtils.join(["a", "b", "c"], ';') = "a;b;c"
StringUtils.join(["a", "b", "c"], null) = "abc"
StringUtils.join([null, "", "a"], ';') = ";;a"
- Rajesh Battala
On Sept. 3, 2013, 7:21 a.m., Laszlo Hornyak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13939/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2013, 7:21 a.m.)
>
>
> Review request for cloudstack and David Nalley.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> - use commons-lang stringutils
> - added test to check compatibility
>
>
> Diffs
> -----
>
> utils/src/com/cloud/utils/StringUtils.java 948c0ac
> utils/test/com/cloud/utils/StringUtilsTest.java ae37c24
>
> Diff: https://reviews.apache.org/r/13939/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Laszlo Hornyak
>
>
Re: Review Request 13939: String join simplification
Posted by Darren Shepherd <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13939/#review26682
-----------------------------------------------------------
I believe this is being blocked by 13938, can you please update to reflect that. Once 13938 is resolved, I can commit this
- Darren Shepherd
On Sept. 3, 2013, 7:21 a.m., Laszlo Hornyak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13939/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2013, 7:21 a.m.)
>
>
> Review request for cloudstack and David Nalley.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> - use commons-lang stringutils
> - added test to check compatibility
>
>
> Diffs
> -----
>
> utils/src/com/cloud/utils/StringUtils.java 948c0ac
> utils/test/com/cloud/utils/StringUtilsTest.java ae37c24
>
> Diff: https://reviews.apache.org/r/13939/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Laszlo Hornyak
>
>
Re: Review Request 13939: String join simplification
Posted by Laszlo Hornyak <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13939/
-----------------------------------------------------------
(Updated Sept. 3, 2013, 7:21 a.m.)
Review request for cloudstack and David Nalley.
Changes
-------
updated to handle null - thx Rajesh!
Repository: cloudstack-git
Description
-------
- use commons-lang stringutils
- added test to check compatibility
Diffs (updated)
-----
utils/src/com/cloud/utils/StringUtils.java 948c0ac
utils/test/com/cloud/utils/StringUtilsTest.java ae37c24
Diff: https://reviews.apache.org/r/13939/diff/
Testing
-------
Thanks,
Laszlo Hornyak