You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/03/08 14:01:00 UTC
[GitHub] [apisix-dashboard] bisakhmondal opened a new pull request #1564: feat: disable closing plugin drawer on clicking the mask
bisakhmondal opened a new pull request #1564:
URL: https://github.com/apache/apisix-dashboard/pull/1564
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [x] New feature provided
- [ ] Improve performance
- [ ] Backport patches
- Related issues
resolves #1548
### New feature or improvement
Now, clicking on the masked area of the plugin drawer does not close it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1564: feat: disable closing plugin drawer on clicking the mask
Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on pull request #1564:
URL: https://github.com/apache/apisix-dashboard/pull/1564#issuecomment-792887934
>The drawer in route and service also needs to be handled.
You can search globally for this component to prevent missing some pages
Hey @LiteSun, for the plugins @ route and service, components are reflecting the current changes. It's using the existing `PluginPage` component (on which the changes have been made) for rendering the plugins in different use cases.
for example inside `service`
https://github.com/apache/apisix-dashboard/blob/6dce9e09640b1c81f14dbb88e5f6f8c43371af31/web/src/pages/Service/Create.tsx#L133-L135
in `routes`
https://github.com/apache/apisix-dashboard/blob/6dce9e09640b1c81f14dbb88e5f6f8c43371af31/web/src/pages/Route/components/Step3/index.tsx#L86-L95
In short, if I am not mistaken, desired changes are getting reflected for plugins across the components you mentioned.
Do you want me to add an extra optional prop (`maskClosable`) for `PluginPage` itself to get a more precise control over the mask to use it from any page?
Thanks for the approval @juzhiyuan π
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1564: feat: disable closing plugin drawer on clicking the mask
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1564:
URL: https://github.com/apache/apisix-dashboard/pull/1564#issuecomment-792782216
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1564?src=pr&el=h1) Report
> Merging [#1564](https://codecov.io/gh/apache/apisix-dashboard/pull/1564?src=pr&el=desc) (f1bbfde) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/938b2b9f34c5fa5e7ef6fddef29acb29b25c09a1?el=desc) (938b2b9) will **decrease** coverage by `30.82%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1564?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1564 +/- ##
===========================================
- Coverage 70.86% 40.04% -30.83%
===========================================
Files 135 49 -86
Lines 5485 3164 -2321
Branches 583 0 -583
===========================================
- Hits 3887 1267 -2620
- Misses 1350 1628 +278
- Partials 248 269 +21
```
| Flag | Coverage Ξ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `40.04% <ΓΈ> (ΓΈ)` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1564?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `0.00% <0.00%> (-88.10%)` | :arrow_down: |
| [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `0.00% <0.00%> (-75.93%)` | :arrow_down: |
| [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `15.15% <0.00%> (-72.73%)` | :arrow_down: |
| [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `9.43% <0.00%> (-72.65%)` | :arrow_down: |
| [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | `3.38% <0.00%> (-65.79%)` | :arrow_down: |
| [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: |
| [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `27.41% <0.00%> (-56.46%)` | :arrow_down: |
| [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `33.47% <0.00%> (-44.77%)` | :arrow_down: |
| [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `30.55% <0.00%> (-41.67%)` | :arrow_down: |
| ... and [103 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1564?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1564?src=pr&el=footer). Last update [938b2b9...f1bbfde](https://codecov.io/gh/apache/apisix-dashboard/pull/1564?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1564: feat: disable closing plugin drawer on clicking the mask
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1564:
URL: https://github.com/apache/apisix-dashboard/pull/1564#issuecomment-792782216
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1564?src=pr&el=h1) Report
> Merging [#1564](https://codecov.io/gh/apache/apisix-dashboard/pull/1564?src=pr&el=desc) (f1bbfde) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/938b2b9f34c5fa5e7ef6fddef29acb29b25c09a1?el=desc) (938b2b9) will **decrease** coverage by `15.17%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1564?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1564 +/- ##
===========================================
- Coverage 70.86% 55.68% -15.18%
===========================================
Files 135 49 -86
Lines 5485 3164 -2321
Branches 583 0 -583
===========================================
- Hits 3887 1762 -2125
+ Misses 1350 1098 -252
- Partials 248 304 +56
```
| Flag | Coverage Ξ | |
|---|---|---|
| backend-e2e-test | `55.68% <ΓΈ> (+0.06%)` | :arrow_up: |
| backend-e2e-test-ginkgo | `40.04% <ΓΈ> (ΓΈ)` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1564?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `0.00% <0.00%> (-88.10%)` | :arrow_down: |
| [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `0.00% <0.00%> (-75.93%)` | :arrow_down: |
| [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `15.15% <0.00%> (-72.73%)` | :arrow_down: |
| [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: |
| [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `57.44% <0.00%> (-34.05%)` | :arrow_down: |
| [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `38.46% <0.00%> (-30.77%)` | :arrow_down: |
| [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `41.66% <0.00%> (-30.56%)` | :arrow_down: |
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `58.43% <0.00%> (-29.52%)` | :arrow_down: |
| [api/internal/filter/ip\_filter.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9pcF9maWx0ZXIuZ28=) | `48.71% <0.00%> (-23.08%)` | :arrow_down: |
| ... and [98 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1564?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1564?src=pr&el=footer). Last update [938b2b9...f1bbfde](https://codecov.io/gh/apache/apisix-dashboard/pull/1564?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on pull request #1564: feat: disable closing plugin drawer on clicking the mask
Posted by GitBox <gi...@apache.org>.
LiteSun commented on pull request #1564:
URL: https://github.com/apache/apisix-dashboard/pull/1564#issuecomment-793275805
> Do you want me to add an extra optional prop (`maskClosable`) for `PluginPage` itself to get a more precise control over the mask to use it from any page?
>
> Thanks for the approval @juzhiyuan π
The current code is ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1564: feat: disable closing plugin drawer on clicking the mask
Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on pull request #1564:
URL: https://github.com/apache/apisix-dashboard/pull/1564#issuecomment-792786009
>Very glad to see you pr! The drawer in route and service also needs to be handled.
Yeah sure. On issue #1548, you only mentioned the plugins, that's why I left the rest of them as it is.
Pushing the changes soon.
Thanks for the review @LiteSun :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1564: feat: disable closing plugin drawer on clicking the mask
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #1564:
URL: https://github.com/apache/apisix-dashboard/pull/1564
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun edited a comment on pull request #1564: feat: disable closing plugin drawer on clicking the mask
Posted by GitBox <gi...@apache.org>.
LiteSun edited a comment on pull request #1564:
URL: https://github.com/apache/apisix-dashboard/pull/1564#issuecomment-792779756
Very glad to see you pr! The drawer in route and service also needs to be handled.
You can search globally for this component to prevent missing some pages
π @bisakhmondal


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on pull request #1564: feat: disable closing plugin drawer on clicking the mask
Posted by GitBox <gi...@apache.org>.
LiteSun commented on pull request #1564:
URL: https://github.com/apache/apisix-dashboard/pull/1564#issuecomment-792779756
Very glad to see you pr! The drawer in route and service also needs to be handled.
You can search globally for this component to prevent missing some pages
π @bisakhmondal

![Uploading image.pngβ¦]()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1564: feat: disable closing plugin drawer on clicking the mask
Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on pull request #1564:
URL: https://github.com/apache/apisix-dashboard/pull/1564#issuecomment-793036844
Oops! one test is failing. But at my local machine all tests of `test:e2e` are working fine.
I have made available the full test report at [pastebin](https://pastebin.com/pF7P02U9).
Could you please look into it? Thank you.
====================================================================================================
(Run Finished)
Spec Tests Passing Failing Pending Skipped
ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ
β β consumer/create_and_delete_consumer 00:13 4 4 - - - β
β .spec.js β
ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ€
β β lang/switch-language.spec.js 00:05 1 1 - - - β
ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ€
β β metrics/metrics-smoketest.spec.js 00:02 1 1 - - - β
ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ€
β β plugin/create-edit-delete-plugin.sp 16:43 3 3 - - - β
β ec.js β
ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ€
β β pluginTemplate/create-edit-delete-p 00:12 3 3 - - - β
β lugin-template.spec.js β
ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ€
β β pluginTemplate/create-plugin-templa 00:20 4 4 - - - β
β te-with-route.spec.js β
ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ€
β β route/can-skip-upstream-when-select 00:20 4 4 - - - β
β -service-id.spec.js β
ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ€
β β route/create-edit-delete-route.spec 00:22 4 4 - - - β
β .js β
ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ€
β β route/create-route-with-upstream.sp 00:19 4 4 - - - β
β ec.js β
ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ€
β β route/import_export_route.spec.js 00:25 4 4 - - - β
ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ€
β β route/online-debug.spec.js 00:29 3 3 - - - β
ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ€
β β route/search-route.spec.js 00:25 4 4 - - - β
ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ€
β β service/create-edit-delete-service. 00:16 4 4 - - - β
β spec.js β
ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ€
β β service/edit-service-with-upstream. 00:18 4 4 - - - β
β spec.js β
ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ€
β β settings/settings-smoketest.spec.js 00:10 3 3 - - - β
ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ€
β β ssl/ssl-smoketest.spec.js 01:09 3 3 - - - β
ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ€
β β upstream/create_and_delete_upstream 00:19 6 6 - - - β
β .spec.js β
ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ€
β β user/login.spec.js 00:05 4 4 - - - β
ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ€
β β user/logout.spec.js 00:04 1 1 - - - β
ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ
β All specs passed! 22:23 64 64 - - -
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1564: feat: disable closing plugin drawer on clicking the mask
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1564:
URL: https://github.com/apache/apisix-dashboard/pull/1564#discussion_r589534022
##########
File path: web/src/components/Plugin/PluginDetail.tsx
##########
@@ -46,6 +46,7 @@ type Props = {
pluginList: PluginComponent.Meta[];
readonly?: boolean;
visible: boolean;
+ maskClosable: boolean;
Review comment:
```suggestion
maskClosable?: boolean;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org