You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by allardhoeve <gi...@git.apache.org> on 2015/03/06 15:50:58 UTC
[GitHub] libcloud pull request: Implement create_ and destroy_volume_snapsh...
GitHub user allardhoeve opened a pull request:
https://github.com/apache/libcloud/pull/478
Implement create_ and destroy_volume_snapshot for OS
The OS driver currently implements `ex_create_snapshot` and `ex_delete_snapshot` instead of `create_volume_snapshot` and `delete_volume_snapshot`. This PR fixes that.
- Add `libcloud.compute.drivers.openstack.create_volume_snapshot`.
- Add `libcloud.compute.drivers.openstack.destroy_volume_snapshot`.
- Clean up base signature to match current implementations: the name argument is considered optional by all drivers that use the signature.
- The CloudStack signature was breaking contract by not accepting the `name` argument.
- Documented that CloudStack disregards any name given to a new snapshot even though it accepts the argument.
- Fixed a lot of docstrings.
- Removes superfluous docstrings that matched the base docstring.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ByteInternet/libcloud openstack-create-volume-snapshot
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/478.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #478
----
commit 87f1c4cab27a40bc53e95170729f4a0bfd5848fc
Author: Allard Hoeve <al...@byte.nl>
Date: 2015-03-06T14:38:28Z
Document functions and update signature
- Document create_volume_snapshot arguments properly
- Document destroy_volume_snapshot arguments properly
- Update signature to match all existing implementations
- name should be optional
commit ae7e340b6289a967ffc0d7b98f7cf7eef9ce34cf
Author: Allard Hoeve <al...@byte.nl>
Date: 2015-03-06T14:46:15Z
Fix documentation string
commit 16d37e67a4ecffca71732798f9e2d8622e014c2b
Author: Allard Hoeve <al...@byte.nl>
Date: 2015-03-06T14:46:50Z
Make driver conform to interface
commit 4fab817ab32bea2d51f36045663c27c08b9403bb
Author: Allard Hoeve <al...@byte.nl>
Date: 2015-03-06T14:47:20Z
Implement general methods and deprecated ex_ methods
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] libcloud pull request: Implement create_ and destroy_volume_snapsh...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/libcloud/pull/478
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---