You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Alexander Kolbasov <ak...@gmail.com> on 2017/01/05 09:04:12 UTC
Re: Review Request 53920: SENTRY-1534: Oracle supports serializable
instead of repeatable-read
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53920/
-----------------------------------------------------------
(Updated Jan. 5, 2017, 9:04 a.m.)
Review request for sentry, Colin Ma, Hao Hao, kalyan kumar kalvagadda, Vamsee Yarlagadda, and Vadim Spector.
Changes
-------
Removed all changes not directly related to the fix.
Bugs: SENTRY-1534
https://issues.apache.org/jira/browse/SENTRY-1534
Repository: sentry
Description
-------
SENTRY-1534: Oracle supports serializable instead of repeatable-read
Diffs (updated)
-----
sentry-service/sentry-service-common/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 919fdaf11c36b412211176ede3c98170a2e34235
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java f83d72160e1c44442d3d1ec1b870ea4b4d5dda1a
Diff: https://reviews.apache.org/r/53920/diff/
Testing
-------
Thanks,
Alexander Kolbasov
Re: Review Request 53920: SENTRY-1534: Oracle supports serializable
instead of repeatable-read
Posted by Alexander Kolbasov <ak...@gmail.com>.
> On Jan. 5, 2017, 9:33 p.m., kalyan kumar kalvagadda wrote:
> > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java, line 154
> > <https://reviews.apache.org/r/53920/diff/3/?file=1597183#file1597183line154>
> >
> > Trying to understand your statement about oracle not supporting repeatable-read. How did you conclude it? I see what you are saying in some websites but the oracle documentation says they support it.
Take a look at http://docs.oracle.com/database/121/ADFNS/adfns_sqlproc.htm#ADFNS99871, for example. In particular, it says that you get
REPEATABLE READ if you set the transaction isolation level to SERIALIZABLE.
The problem is that an attempt to set isolation level to repeatable read is rejected by Oracle and you get an error.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53920/#review160634
-----------------------------------------------------------
On Jan. 5, 2017, 9:04 a.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53920/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2017, 9:04 a.m.)
>
>
> Review request for sentry, Colin Ma, Hao Hao, kalyan kumar kalvagadda, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1534
> https://issues.apache.org/jira/browse/SENTRY-1534
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1534: Oracle supports serializable instead of repeatable-read
>
>
> Diffs
> -----
>
> sentry-service/sentry-service-common/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 919fdaf11c36b412211176ede3c98170a2e34235
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java f83d72160e1c44442d3d1ec1b870ea4b4d5dda1a
>
> Diff: https://reviews.apache.org/r/53920/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 53920: SENTRY-1534: Oracle supports serializable
instead of repeatable-read
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53920/#review160634
-----------------------------------------------------------
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 154)
<https://reviews.apache.org/r/53920/#comment231770>
Trying to understand your statement about oracle not supporting repeatable-read. How did you conclude it? I see what you are saying in some websites but the oracle documentation says they support it.
- kalyan kumar kalvagadda
On Jan. 5, 2017, 9:04 a.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53920/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2017, 9:04 a.m.)
>
>
> Review request for sentry, Colin Ma, Hao Hao, kalyan kumar kalvagadda, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1534
> https://issues.apache.org/jira/browse/SENTRY-1534
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1534: Oracle supports serializable instead of repeatable-read
>
>
> Diffs
> -----
>
> sentry-service/sentry-service-common/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 919fdaf11c36b412211176ede3c98170a2e34235
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java f83d72160e1c44442d3d1ec1b870ea4b4d5dda1a
>
> Diff: https://reviews.apache.org/r/53920/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 53920: SENTRY-1534: Oracle supports serializable
instead of repeatable-read
Posted by Hao Hao <ha...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53920/#review160957
-----------------------------------------------------------
Ship it!
Ship It!
- Hao Hao
On Jan. 5, 2017, 9:04 a.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53920/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2017, 9:04 a.m.)
>
>
> Review request for sentry, Colin Ma, Hao Hao, kalyan kumar kalvagadda, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1534
> https://issues.apache.org/jira/browse/SENTRY-1534
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1534: Oracle supports serializable instead of repeatable-read
>
>
> Diffs
> -----
>
> sentry-service/sentry-service-common/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 919fdaf11c36b412211176ede3c98170a2e34235
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java f83d72160e1c44442d3d1ec1b870ea4b4d5dda1a
>
> Diff: https://reviews.apache.org/r/53920/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>