You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/31 12:57:17 UTC
[GitHub] [doris] Gabriel39 opened a new pull request, #13840: [Bug](delete) Fix wrong delete operation
Gabriel39 opened a new pull request, #13840:
URL: https://github.com/apache/doris/pull/13840
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Gabriel39 merged pull request #13840: [Bug](delete) Fix wrong delete operation
Posted by GitBox <gi...@apache.org>.
Gabriel39 merged PR #13840:
URL: https://github.com/apache/doris/pull/13840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13840: [Bug](delete) Fix wrong delete operation
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13840:
URL: https://github.com/apache/doris/pull/13840#issuecomment-1297533616
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 39.38 seconds
load time: 573 seconds
storage size: 17154655421 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221031185845_clickbench_pr_36847.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13840: [Bug](delete) Fix wrong delete operation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13840:
URL: https://github.com/apache/doris/pull/13840#issuecomment-1297533232
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #13840: [Bug](delete) Fix wrong delete operation
Posted by GitBox <gi...@apache.org>.
HappenLee commented on code in PR #13840:
URL: https://github.com/apache/doris/pull/13840#discussion_r1009432301
##########
be/src/olap/null_predicate.h:
##########
@@ -59,6 +59,14 @@ class NullPredicate : public ColumnPredicate {
}
}
+ bool evaluate_del(const std::pair<WrapperField*, WrapperField*>& statistic) const override {
+ if (_is_null) {
Review Comment:
seems only check `min/max` one side is ok ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13840: [Bug](delete) Fix wrong delete operation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13840:
URL: https://github.com/apache/doris/pull/13840#issuecomment-1297533286
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #13840: [Bug](delete) Fix wrong delete operation
Posted by GitBox <gi...@apache.org>.
HappenLee commented on code in PR #13840:
URL: https://github.com/apache/doris/pull/13840#discussion_r1009439655
##########
be/src/olap/in_list_predicate.h:
##########
@@ -266,6 +266,28 @@ class InListPredicateBase : public ColumnPredicate {
}
}
+ bool evaluate_del(const std::pair<WrapperField*, WrapperField*>& statistic) const override {
+ if (statistic.first->is_null() || statistic.second->is_null()) {
Review Comment:
if max value is null, should return `true`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org