[GitHub] Antonio-Maranhao opened a new pull request #989: Basic validation of key values provided in the Query Options panel

[gi...@git.apache.org]

Antonio-Maranhao opened a new pull request #989: Basic validation of key values provided in the Query Options panel
URL: https://github.com/apache/couchdb-fauxton/pull/989
 
 
   
   ## Overview
   
   A common (newbiew) user mistake is to forget to include double quotes in the By Keys and Between Keys fields (Query Options panel) for String values. (See https://github.com/apache/couchdb-fauxton/issues/957)
   Since CouchDB accepts arbitrary JSON values as key, automatically adding the quotes is not ideal. Instead, the panel does some basic validation and displays a warning when necessary.
   
   ## Testing recommendations
   
   - Between Keys filter
     - It should display the warning for String values without quotes (e.g.: abc)
     - It should NOT display the warning for numbers and boolean.
   - By Keys filter
     - It should display the warning if the value is not enclosed in square brackets (e.g.: "abc")
   
   ## GitHub issue number
   
   Related to https://github.com/apache/couchdb-fauxton/issues/957
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services