Re: [PR] [WIP][SPARK-49665][SQL] Trim collation support for string functions [spark]

["uros-db (via GitHub)" <gi...@apache.org>]

uros-db commented on code in PR #48521:
URL: https://github.com/apache/spark/pull/48521#discussion_r1804892106


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##########
@@ -796,6 +812,7 @@ case class MakeValidUTF8(input: Expression) extends RuntimeReplaceable with Impl
 
 }
 
+// TODO: fix

Review Comment:
   usually in the Spark repo, we tend to tag TODOs using a corresponding Jira ticket, our your github username
   
   the point is that we make TODOs less random and provide concrete references



##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##########
@@ -796,6 +812,7 @@ case class MakeValidUTF8(input: Expression) extends RuntimeReplaceable with Impl
 
 }
 
+// TODO: fix

Review Comment:
   usually in the Spark repo, we tend to tag TODOs using a corresponding Jira ticket, or your github username
   
   the point is that we make TODOs less random and provide concrete references



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org