You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/09/02 04:38:26 UTC
[GitHub] [iceberg] JonasJ-ap commented on a diff in pull request #5684: AWS: refactor the three AwsClientFactories
JonasJ-ap commented on code in PR #5684:
URL: https://github.com/apache/iceberg/pull/5684#discussion_r961280351
##########
aws/src/main/java/org/apache/iceberg/aws/AwsClientFactories.java:
##########
@@ -143,31 +134,12 @@ public DynamoDbClient dynamo() {
@Override
public void initialize(Map<String, String> properties) {
+ this.awsProperties = new AwsProperties(properties);
this.glueEndpoint = properties.get(AwsProperties.GLUE_CATALOG_ENDPOINT);
Review Comment:
Thank you for your suggestions. I moved all endpoint fields: `glueEndpoint`, `s3Endpoint`, and `dynamodbEndpoint` to `AwsProperties` so that we do not have to parse them separately in every client factory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org