[jira] [Commented] (FLINK-7389) Remove Calcite PushProjector

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16255003#comment-16255003 ] 

ASF GitHub Bot commented on FLINK-7389:
---------------------------------------

GitHub user twalthr opened a pull request:

    https://github.com/apache/flink/pull/5022

    [FLINK-7389] [table] Remove Calcite PushProjector

    ## What is the purpose of the change
    
    Removes copied Calcite class `PushProjector`. All tests are successful.
    
    ## Brief change log
    
    Removed class.
    
    
    ## Verifying this change
    
    Modified some existing tests.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
      - The S3 file system connector: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? not applicable


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twalthr/flink FLINK-7389

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5022.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5022
    
----
commit 3202dbedfeec2919eab4ccd055b04fa74292e96c
Author: twalthr <tw...@apache.org>
Date:   2017-11-16T09:20:16Z

    [FLINK-7389] [table] Remove Calcite PushProjector

----


> Remove Calcite PushProjector
> ----------------------------
>
>                 Key: FLINK-7389
>                 URL: https://issues.apache.org/jira/browse/FLINK-7389
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>
> The PushProjector class is copied from Apache Calcite except that it does not automatically name the field using the name of the operators as the Table API rejects special characters like '-' in the field names.
> We need to find a solution without copying Calcite classes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)